Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

Mobile shell: video pinned on top, one status strip, bottom tabs, a snap-point drive sheet - and exactly ONE stop button #62

Parked opened this in answer to
Closed without merging

The phone viewer now has one STOP button: a single [data-stop] element in every layout and every tab. The video is pinned on top, a status strip sits under it, and Drive · Queue · Chat (· Admin) tabs sit at the bottom, with Drive as a two-position bottom sheet.

Notes

stopped parked by the crew deploy 05182a5

opened this

The phone viewer now has one STOP button: a single [data-stop] element in every layout and every tab. The video is pinned on top, a status strip sits under it, and Drive · Queue · Chat (· Admin) tabs sit at the bottom, with Drive as a two-position bottom sheet. The new browser test suite has never run, and there are no screenshots: Chromium can't start in the sandbox this was built in, so those 10 tests were skipped. Their first real run is the forge check on this push.

What changed (Software/so101/src/viewer.html)

  • STOP: the second Stop button (the soft "end what the arm is doing" one) is gone, along with the landscape Hide/Show toggle. The emergency stop is at least 56 px and fires the moment a finger touches it, not when it lifts. When stopped, a full-width banner says so and the button becomes Resume for the owner. Resuming takes a second "Tap again to resume" tap within 4 s, which replaces the old confirm() dialog. Esc is still the emergency stop and Space still ends the current move.
  • Portrait: the video's 16:9 box is reserved before a frame arrives, so nothing shifts. Under it, one status strip shows the driver and time left, your place in the line, Live/Reconnecting/No arm, the turn's button, and STOP. Tabs are 56 px plus the bottom safe-area inset. People who aren't driving see a short card in the Drive tab saying how to get a turn.
  • Drive sheet: it rests either at peek (96 px: arm state and gripper Open/Close) or open (about 45 % of the screen: joints, poses, hold/release, record/play, leader). Drag the handle, flick it, or tap it. The snap logic is plain data in src/ui/sheet.js, with unit tests in sheet.test.ts.
  • Landscape phones (height up to 500 px): the video fills the screen, the strip floats top-left, STOP is top-right, and the drive controls sit in the lower corners. Queue/Chat/Admin open as a drawer, and tapping the same tab again closes it.
  • The Play button becomes "■ End playback" during playback, since the soft Stop button is gone.

Tests

  • src/server.test.ts now checks that the served page has exactly one data-stop, that it uses pointerdown, the two-tap resume, and the 16:9 reservation.
  • src/mobile-shell.test.ts is the new browser suite. It covers 390×844 and 412×915, portrait and landscape, light and dark, and checks:

- exactly one visible STOP of at least 56 px, top-right in landscape; - nothing under the forge pill, no sideways overflow, and tabs at least 44 px; - the sheet snaps between peek and open; - STOP fires on the touch, the banner is full width, and one tap does not resume.

  • It uses the system Chromium through playwright-core, added as a dev-only dependency (no browser downloads) and justified in the README. It skips itself by name where no Chromium can start.
  • bun test on sheet.test.ts, mobile-shell.test.ts and server.test.ts: 51 pass, 10 skip, 0 fail.
  • bun x tsc --noEmit shows one error, in src/admin-relay.test.ts:101. It's the same on main without this change.

Not done: joystick controls in the landscape corners use the existing pad, not a nipple.js-style floating joystick. No dependency was added for that.

To try it: open the preview at 390×844 in device mode, take control, then drag the sheet handle and press STOP. To save a screenshot of every state, run SO101_SHOTS=<dir> bun test src/mobile-shell.test.ts from Software/so101 on a machine with Chromium.

🤖 Generated with Claude Code

Closes #49

commented

The phone viewer now has one STOP button: a single [data-stop] element in every layout and every tab. The video is pinned on top, a status strip sits under it, and Drive · Queue · Chat (· Admin) tabs sit at the bottom, with Drive as a two-position bottom sheet. The new browser test suite has never run, and there are no screenshots: Chromium can't start in the sandbox this was built in, so those 10 tests were skipped. Their first real run is the forge check on this push.

What changed (Software/so101/src/viewer.html)

  • STOP: the second Stop button (the soft "end what the arm is doing" one) is gone, along with the landscape Hide/Show toggle. The emergency stop is at least 56 px and fires the moment a finger touches it, not when it lifts. When stopped, a full-width banner says so and the button becomes Resume for the owner. Resuming takes a second "Tap again to resume" tap within 4 s, which replaces the old confirm() dialog. Esc is still the emergency stop and Space still ends the current move.
  • Portrait: the video's 16:9 box is reserved before a frame arrives, so nothing shifts. Under it, one status strip shows the driver and time left, your place in the line, Live/Reconnecting/No arm, the turn's button, and STOP. Tabs are 56 px plus the bottom safe-area inset. People who aren't driving see a short card in the Drive tab saying how to get a turn.
  • Drive sheet: it rests either at peek (96 px: arm state and gripper Open/Close) or open (about 45 % of the screen: joints, poses, hold/release, record/play, leader). Drag the handle, flick it, or tap it. The snap logic is plain data in src/ui/sheet.js, with unit tests in sheet.test.ts.
  • Landscape phones (height up to 500 px): the video fills the screen, the strip floats top-left, STOP is top-right, and the drive controls sit in the lower corners. Queue/Chat/Admin open as a drawer, and tapping the same tab again closes it.
  • The Play button becomes "■ End playback" during playback, since the soft Stop button is gone.

Tests

  • src/server.test.ts now checks that the served page has exactly one data-stop, that it uses pointerdown, the two-tap resume, and the 16:9 reservation.
  • src/mobile-shell.test.ts is the new browser suite. It covers 390×844 and 412×915, portrait and landscape, light and dark, and checks:

- exactly one visible STOP of at least 56 px, top-right in landscape; - nothing under the forge pill, no sideways overflow, and tabs at least 44 px; - the sheet snaps between peek and open; - STOP fires on the touch, the banner is full width, and one tap does not resume.

  • It uses the system Chromium through playwright-core, added as a dev-only dependency (no browser downloads) and justified in the README. It skips itself by name where no Chromium can start.
  • bun test on sheet.test.ts, mobile-shell.test.ts and server.test.ts: 51 pass, 10 skip, 0 fail.
  • bun x tsc --noEmit shows one error, in src/admin-relay.test.ts:101. It's the same on main without this change.

Not done: joystick controls in the landscape corners use the existing pad, not a nipple.js-style floating joystick. No dependency was added for that.

To try it: open the preview at 390×844 in device mode, take control, then drag the sheet handle and press STOP. To save a screenshot of every state, run SO101_SHOTS=<dir> bun test src/mobile-shell.test.ts from Software/so101 on a machine with Chromium.

🤖 Generated with Claude Code

commented

Parked by the crew: the preview's deploy failed in the place it ran, not in the change, and it could not be run again

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs