Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

Mobile chat: the keyboard never covers the composer, the video shrinks to a mini player, and chat floats over the video for watchers #55

Closed opened this in answer to
Closed without merging

This pull finishes the phone chat layout in viewer.html, but I couldn't test any of it in a browser or take the screenshots. The sandbox has no Playwright browser, so there are no 390x844 or 412x915 runs and no keyboard-open check. My new test only confirms the markup is in the served page.

Notes

stopped closed without shipping deploy 3a98050

opened this

This pull finishes the phone chat layout in viewer.html, but I couldn't test any of it in a browser or take the screenshots. The sandbox has no Playwright browser, so there are no 390x844 or 412x915 runs and no keyboard-open check. My new test only confirms the markup is in the served page. Please try it on a real phone or in emulation before sending it out.

The page already pinned the shell to the visual viewport, set interactive-widget=resizes-content, used a 16 px composer font and overscroll-behavior: contain, and muted system lines. I added the rest:

  • Mini player: when the composer has focus the video drops to a fixed 120 px (it was 24% of the screen).
  • New messages pill: auto-scroll still happens only when you're near the bottom. Otherwise a "New messages ↓" pill appears and clears when you tap it or scroll down.
  • Watcher overlay: the last three chat lines show as a transparent overlay on the video. It never blocks taps, and it hides while typing, for whoever is driving, and in the wide desktop layout.
  • Muted system lines: these are slightly smaller and dimmer now, in the chat and in the overlay.
  • Two stop buttons: the strip's plain "Stop" is now "End move" and the red one is "E-STOP". The two had the same label.

The remaining server.test.ts failure ("serves the model, its meshes and the vendored libraries") also fails on a clean checkout. The vendored model libraries aren't installed here because bun install can't write its temp dir. I added a test that checks the new markup is in the page. I didn't run tsc.

Not done: long-press moderation was already in the page, so I left it alone. I didn't build the Vaul-style snap-point sheet or the virtual joystick.

🤖 Generated with Claude Code

Closes #51

2 earlier comments · 1 event
commented

This pull finishes the phone chat layout in viewer.html, but I couldn't test any of it in a browser or take the screenshots. The sandbox has no Playwright browser, so there are no 390x844 or 412x915 runs and no keyboard-open check. My new test only confirms the markup is in the served page. Please try it on a real phone or in emulation before sending it out.

The page already pinned the shell to the visual viewport, set interactive-widget=resizes-content, used a 16 px composer font and overscroll-behavior: contain, and muted system lines. I added the rest:

  • Mini player: when the composer has focus the video drops to a fixed 120 px (it was 24% of the screen).
  • New messages pill: auto-scroll still happens only when you're near the bottom. Otherwise a "New messages ↓" pill appears and clears when you tap it or scroll down.
  • Watcher overlay: the last three chat lines show as a transparent overlay on the video. It never blocks taps, and it hides while typing, for whoever is driving, and in the wide desktop layout.
  • Muted system lines: these are slightly smaller and dimmer now, in the chat and in the overlay.
  • Two stop buttons: the strip's plain "Stop" is now "End move" and the red one is "E-STOP". The two had the same label.

The remaining server.test.ts failure ("serves the model, its meshes and the vendored libraries") also fails on a clean checkout. The vendored model libraries aren't installed here because bun install can't write its temp dir. I added a test that checks the new markup is in the page. I didn't run tsc.

Not done: long-press moderation was already in the page, so I left it alone. I didn't build the Vaul-style snap-point sheet or the virtual joystick.

🤖 Generated with Claude Code

Changes requested — before the latest push

Changes requested. First fix: a moderated or deleted message stays on the video for every watcher. The 'unsaid' handler only removes the line from #chat. The #ticker is rebuilt only inside addChat, so a deleted line keeps showing over the video until three newer lines push it out. That undoes moderation on the surface everyone sees. Rebuild the ticker from #chat in one small function and call it from both addChat and the 'unsaid' branch.

Also:

  1. The test only greps served markup (the 120px CSS string, ids and button labels). It would not fail if the ticker, the pill or the scroll logic were broken. Add a test for behaviour, or at least pin the unsaid-clears-ticker case once it is fixed.
  2. I could not reach the preview from my sandbox (network denied), so I could not confirm it renders. The author also says nothing was run in a browser at 360/390px with the keyboard open, so the keyboard-covers-composer claim is unverified. Please attach a real check.
  3. The tty door is untouched. That is fine for a layout change, but the README should note that the E-STOP / End move label change applies to the page only.
  4. #newMsgs is outside the #say form and has no type attribute; add type=button. It is also positioned at bottom:74px, a magic number that will overlap the composer when #sayNote is visible. Anchor it to the chat box instead.
  5. The ticker is aria-hidden, which is right, but 'New messages' is not announced either: #chat is role=log, so that is fine. No change needed there.

Good: the ticker never takes taps (pointer-events none), hides while typing and while driving, and its text comes from cloned DOM nodes, so there is no new escaping risk.

commented

Deleted chat messages now leave the video overlay too, but I still couldn't check any of this in a browser. The sandbox has no browser, so the keyboard-covers-composer claim and the 360/390px renders remain unverified. A real run needs Playwright at 390x844 and 412x915 with the keyboard open. I'm not claiming that check was done.

  • Deleted messages stay on video (fixed): the ticker is now rebuilt from #chat by one function, syncTicker, in the new src/ui/chat-ticker.js. Both addChat and the unsaid branch call it, so a moderated or deleted line leaves the overlay at once and an older line takes its place.
  • Tests: the new src/ui/chat-ticker.test.ts covers behaviour, not markup. It checks that the ticker shows the last three lines with system lines marked, that a line removed from the log disappears from the ticker after a rebuild, and the near-bottom threshold. They use a minimal fake DOM, so they pin the logic but not rendering.
  • New-messages pill: it now has type="button" and sits inside a #chatWrap around the chat log, anchored at bottom: 8px. The magic number is gone, so it can't overlap the composer or #sayNote.
  • README: it now says the E-STOP and End move labels are the page's own and the terminal door keeps its commands. The same sentence also names the owner's Stop pointer from the label change.
  • Item 5: no change, as you said.

In the tests I ran, the only failure is "serves the model, its meshes and the vendored libraries". It fails on a clean checkout too, because bun install can't write its temp dir here. The type check couldn't run for the same reason.

🤖 Generated with Claude Code

commented

Declined: I found nothing in this pull's code that could have failed the preview deploy, so I changed and pushed nothing. Run log: https://forge.open-platform.sh/trevato/arm/runs/01m5djkhpht44jthvm77epktyx

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs