Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

workbenchthis machine

main's tests pass again: the #notesPill fade rules move from src/ui/notes.css into viewer.html's <style> #526

Parked opened this
Closed without merging

quill/arm:quill/512-main-s-tests-pass-again-the-notespill-fa → main 1 commit fork

  • Closed without merging. Nothing was applied to main.

Review

Sign in to review this change.
3 files changed +7 −3
Software/so101/src/stop-layout.test.ts +5
@@ -171,4 +171,9 @@ describe("notes on the served page", () => {
171171 // styled by the page, so it never shows unstyled while the stylesheet loads
172172 expect(notesCss.some((r) => r.selector.includes("notesPill"))).toBe(false);
173173 });
174
175 test("the pill fades out on the page's own rules: .fading takes it to opacity 0 over 0.4 s", () => {
176 expect(body("#notesPill")).toMatch(/transition:\s*opacity\s+\.4s/);
177 expect(body("#notesPill.fading")).toMatch(/opacity:\s*0\b/);
178 });
174179 });
Software/so101/src/ui/notes.css −2
@@ -1,4 +1,2 @@
11 #notesList { position: fixed; z-index: 9; left: 8px; right: 8px; bottom: calc(8px + var(--safe-b)); max-height: 40vh; overflow: auto; margin: 0 auto; max-width: 480px; padding: 6px; border: 1px solid var(--line); border-radius: 10px; background: var(--surface); }
22 .note { display: flex; gap: 8px; padding: 8px; border-left: 3px solid var(--blue); font-size: 14px; overflow-wrap: anywhere; } .note span { flex: 1; } .note button { flex: none; min-height: 44px; min-width: 44px; }
3 #notesPill { transition: opacity .4s ease; }
4 #notesPill.fading { opacity: 0; }
Software/so101/src/viewer.html +2 −1
@@ -137,7 +137,8 @@
137137 #tabs .badge { display: inline-block; min-width: 18px; margin-left: 4px; padding: 0 5px; border-radius: 9px; background: var(--blue); color: var(--on-blue); font-size: 11px; line-height: 18px; }
138138 #tabs .badge:empty { display: none; }
139139
140 #notesPill { flex: none; min-height: 44px; min-width: 44px; padding: 0 12px; border-radius: 22px; background: var(--blue-soft); }
140 #notesPill { flex: none; min-height: 44px; min-width: 44px; padding: 0 12px; border-radius: 22px; background: var(--blue-soft); transition: opacity .4s ease; }
141 #notesPill.fading { opacity: 0; }
141142
142143 /* chat */
143144 #tab-chat { padding: 0; gap: 0; }

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs