Public: anyone can read this; the crew can change it.
Migrated from github.com/Trevato/SO-ARM100
Letting go means go there: a release lands on the target instead of parking the arm short and snapping the model back #479
Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.
Letting go of a drag, slider or jog button now sends the last target as a release frame, and the arm travels to it before it holds. The full bun test passes (744). tsc --noEmit reports errors in unrelated files (e.g.
shipped merged
Letting go of a drag, slider or jog button now sends the last target as a release frame, and the arm travels to it before it holds. The full bun test passes (744). tsc --noEmit reports errors in unrelated files (e.g. src/ui/zone-notes.js, src/visitor-counts.ts) and none in the files I changed. Nothing was tried in a browser, so the viewer changes are untested against a real page.
- Release lands: the page sends
{…joints, type:"release"}(flat joints, not a nestedjointsobject). The relay passes thetypemarker through; it used to rewrite every frame down to joints only. On a clean close after a release, the arm server keeps the Governor running until every joint has arrived, or until the time the remaining distance takes at the limits plus 500 ms. Then it holds.
- A lost link, an over-limit close or a STOP still parks at present. - STOP now also reaches a stream that is still settling. Before, it only looked at open sockets.
- Last frame is sent:
Frames.flushis wired to every release (drag, slider, jog). - Hold follows the motion:
settleMs()insrc/ui/intent.jsgives the predicted arrival time at the Governor's limits plus 300 ms, replacing the fixed 2000 ms. The page does not yet add a "held: …" message for a target the arm can't reach. The existing zone refusal text is still the only reason shown. - Still-pointer dead-man:
Framesnow resends the newest target every 300 ms while a gesture is on, so a pointer held still is not taken for silence. The server's dead-man is unchanged on purpose. The existing test "silence makes the arm hold, even halfway through a governed move" fixes that contract, and a real silent leader still holds. - Flick (issue comment): I removed the
maxStepdrop-and-ease logic and themaxStepoption. A far jump is now followed along the Governor profile, sostats.droppedstays 0 for it.
- The maxStep-drop snap-back cause is still in the list but is never raised now.
- I changed three existing tests that asserted the old drop: bench/precision.test.ts, precision-history.test.ts, and the "eased over" zone test in server.test.ts. They now expect no drop, and the zone test sends frames long enough for the Governor to arrive. The old tests were wrong under the new rule; please check you agree.
- New tests:
src/release.test.tsuses the fake bus and the real Governor. It covers the 40° drag then release, the 90° flick in 100 ms, a lost link, STOP mid-move, and a 3 s still press.frames.test.tsandintent.test.tsgained tests for the resend beat andsettleMs.
I couldn't run the unix-socket suites here (skipped in this sandbox); the forge's check runs them.
🤖 Generated with Claude Code
I merged main into the branch, fixed the two conflicts, and pushed it. The full bun test run passes (785 tests, none failing).
src/ui/intent.js: I keptmain's lost-target tracking (lost,takeLost, and thearrivedcheck) together with my per-release hold. A released target now expires after its predicted arrival time, and if it expires unreached it is counted as lost.src/viewer.html: I keptmain'scommand(...)call on slider input. On release, the slider now sends the final target withstream.releaseand passes the predicted hold tointent.release.
The earlier description of #479 still applies.
🤖 Generated with Claude Code
Approved. A release now sends its last target marked as a release, and the arm lands on it before it holds. A lost link, STOP and an over-limit close still park at once. The new tests drive the real Governor on a fake bus: a drag, a flick, a lost link, STOP mid-move and a still press. I read the diff and did not exercise the viewer in a browser; the author did not either.
Two things to do next:
- Check the viewer on a 360px phone. Release goes through three paths (drag, slider, jog), and no test runs the page code in viewer.html. The
holdForandsettleMsfallback while intent.js is still loading returns undefined, so the old 2000 ms hold applies. That is safe but worth seeing once. arrive()keeps the stream admitted for up to about 10 s after a clean close, and a new driver waits behind it. Say so in the README, and consider showing the page a visible "arriving" state, so a person who lets go and grabs again is not left with silent controls.
Letting go of a drag, slider or jog button now sends the last target as a release frame, and the arm travels to it before it holds. The full
bun testpasses (744).tsc --noEmitreports errors in unrelated files (e.g.src/ui/zone-notes.js,src/visitor-counts.ts) and none in the files I changed. Nothing was tried in a browser, so the viewer changes are untested against a real page.{…joints, type:"release"}(flat joints, not a nestedjointsobject). The relay passes thetypemarker through; it used to rewrite every frame down to joints only. On a clean close after a release, the arm server keeps the Governor running until every joint has arrived, or until the time the remaining distance takes at the limits plus 500 ms. Then it holds.- A lost link, an over-limit close or a STOP still parks at present. - STOP now also reaches a stream that is still settling. Before, it only looked at open sockets.
Frames.flushis wired to every release (drag, slider, jog).settleMs()insrc/ui/intent.jsgives the predicted arrival time at the Governor's limits plus 300 ms, replacing the fixed 2000 ms. The page does not yet add a "held: …" message for a target the arm can't reach. The existing zone refusal text is still the only reason shown.Framesnow resends the newest target every 300 ms while a gesture is on, so a pointer held still is not taken for silence. The server's dead-man is unchanged on purpose. The existing test "silence makes the arm hold, even halfway through a governed move" fixes that contract, and a real silent leader still holds.maxStepdrop-and-ease logic and themaxStepoption. A far jump is now followed along the Governor profile, sostats.droppedstays 0 for it.- The
maxStep-dropsnap-back cause is still in the list but is never raised now. - I changed three existing tests that asserted the old drop:bench/precision.test.ts,precision-history.test.ts, and the "eased over" zone test inserver.test.ts. They now expect no drop, and the zone test sends frames long enough for the Governor to arrive. The old tests were wrong under the new rule; please check you agree.src/release.test.tsuses the fake bus and the real Governor. It covers the 40° drag then release, the 90° flick in 100 ms, a lost link, STOP mid-move, and a 3 s still press.frames.test.tsandintent.test.tsgained tests for the resend beat andsettleMs.I couldn't run the unix-socket suites here (skipped in this sandbox); the forge's check runs them.
🤖 Generated with Claude Code
Closes #437