Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

docs/launch-check.md lists the signed-in half of the launch check as steps a person ticks on the real arm #423

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

docs/launch-check.md now has a "Signed in" section under the anonymous results. It has one checkbox per step, each with its expected result. The steps are sign in, queue, drive, turn handoff, E-stop, admin pause and end turn, mute, ban, remove, report, word filter and crew moderation.

Notes

shipped merged

opened this

docs/launch-check.md now has a "Signed in" section under the anonymous results. It has one checkbox per step, each with its expected result. The steps are sign in, queue, drive, turn handoff, E-stop, admin pause and end turn, mute, ban, remove, report, word filter and crew moderation. The change is docs only, and forge.json is untouched.

bun --cwd Software/so101 test does not pass here: 642 pass and 1 fails. The failure is in src/server.test.ts:545, where /vendor/three/build/three.module.js returns 404. I didn't touch that code, and the likely cause is that the vendored three build isn't in this sandbox's node_modules. I did not confirm that, so the forge's check will show whether it fails there too.

I wrote each step from the page and the code, not from a run on the live arm. A few button names in the steps are therefore my best reading and may need a tweak when someone ticks them: "Take control", the Mute 10m choice in the mod menu, and the owner-side Remove and Restore buttons.

Closes #402

1 earlier comment · 1 event
commented

docs/launch-check.md now has a "Signed in" section under the anonymous results. It has one checkbox per step, each with its expected result. The steps are sign in, queue, drive, turn handoff, E-stop, admin pause and end turn, mute, ban, remove, report, word filter and crew moderation. The change is docs only, and forge.json is untouched.

bun --cwd Software/so101 test does not pass here: 642 pass and 1 fails. The failure is in src/server.test.ts:545, where /vendor/three/build/three.module.js returns 404. I didn't touch that code, and the likely cause is that the vendored three build isn't in this sandbox's node_modules. I did not confirm that, so the forge's check will show whether it fails there too.

I wrote each step from the page and the code, not from a run on the live arm. A few button names in the steps are therefore my best reading and may need a tweak when someone ticks them: "Take control", the Mute 10m choice in the mod menu, and the owner-side Remove and Restore buttons.

Changes requested — before the latest push

Docs-only and in direction, but a checklist a person ticks must name the buttons that exist, and two steps name ones that do not. Fix first: make every button label match the source (src/admin-page.ts, src/ui/mod-menu.js, src/ui/lobby-panel.js). (1) Report step: /admin buttons are "Remove", "Mute", "Dismiss", not "Remove line"/"Mute author". (2) Mute step: the admin button that clears a mute is "Unmute" ("Unban" for bans), not "Lift". The Ban step says "Lift it from /admin" without the label; say "Unban". The other labels you were unsure of check out: "Take control", "Mute 10m", owner "Remove"/"Restore" all exist. Also the PR note says one test failed (three.module.js 404) in your sandbox; fine for docs, but confirm the forge check is green.

commented

The signed-in section of docs/launch-check.md now uses the button names from src/admin-page.ts. I only edited and read the doc and the source. I haven't clicked through the steps on the live arm.

  • Mute: the button on /admin that clears a mute is "Unmute" (was "Lift").
  • Ban: the step now says to press "Unban" on /admin, where it only said "Lift it".
  • Report: the report buttons are "Remove", "Mute" and "Dismiss". The step quotes the messages each one shows: "Line removed; report closed.", "Author muted; report closed." and "Report dismissed."

I haven't seen the forge check's verdict, so I can't say it's green. The one failing test I saw (the three.module.js 404 in src/server.test.ts) came from my sandbox, and this change is docs only. The forge's own run on this push will show whether it passes there.

Approved

Docs-only, 17 lines, one checkbox per signed-in step with an expected result. I spot-checked the button and message names against the source (Join queue, Take control, Pause/Resume the queue, Turn ended, Unmute, Unban, Mute 10m, Resume driving, Word filter, Crew moderator, the banned text) and each exists. No code, secrets or dependencies touched, and nothing beyond the issue. Two things I would do next: (1) run the list once on the real arm and put the date and commit beside the first run, since the steps were written from the code and not from a run; (2) add a line for the 360px phone, since the long-press mod dialog and the 44px Report button are only proven by tests, not by thumb.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs