Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

Owners and moderators get a 44 px menu button on each other person's chat line that opens the moderator menu; Escape or an outside tap closes it #421

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

Owners and moderators now get a 44 px "⋯" menu button on other people's chat lines, beside Report. The button opens the moderator menu beneath it. Picking an item sends its /live frame and closes the menu.

Notes

shipped merged

opened this

Owners and moderators now get a 44 px "⋯" menu button on other people's chat lines, beside Report. The button opens the moderator menu beneath it. Picking an item sends its /live frame and closes the menu. Escape or a tap outside also closes it.

  • Where it shows: the button is drawn on lines where menuItems is non-empty (lobby-panel.js). That excludes plain users, guests and your own line. It carries an aria-label naming the author, and it is part of the line from the start, so opening the menu shifts nothing.
  • Open and close: one menu is open at a time. Opening a second closes the first. The Escape and outside-tap listeners exist only while a menu is open.
  • Styling: viewer.html gives .modbtn the same 44 px minimum as .report. The menu is positioned under its line.
  • Tests: four new cases in lobby-panel.test.ts.

- The button is absent for plain users, guests and your own line. - It is labelled with the author's name. - Picking "Mute 1h" sends {type:"mute",id,on:true,for:"1h"}. - Escape and an outside tap close the menu; other keys do not. - To fit these in, the test harness's fake div now records its children, and .btn now means the Report button.

  • Test results: bun test ran 647 tests, 646 pass and 1 fails.

- The one failure is in src/server.test.ts:545. /vendor/three/build/three.module.js returns 404 in this sandbox, which looks like a missing vendored dependency. This change does not touch the vendor route. - The first-visit gzip budget test passes.

  • Not run: tsc --noEmit did not run here (bun could not write to its temp dir), so the type check is left to the forge.

🤖 Generated with Claude Code

Closes #385

commented

Owners and moderators now get a 44 px "⋯" menu button on other people's chat lines, beside Report. The button opens the moderator menu beneath it. Picking an item sends its /live frame and closes the menu. Escape or a tap outside also closes it.

  • Where it shows: the button is drawn on lines where menuItems is non-empty (lobby-panel.js). That excludes plain users, guests and your own line. It carries an aria-label naming the author, and it is part of the line from the start, so opening the menu shifts nothing.
  • Open and close: one menu is open at a time. Opening a second closes the first. The Escape and outside-tap listeners exist only while a menu is open.
  • Styling: viewer.html gives .modbtn the same 44 px minimum as .report. The menu is positioned under its line.
  • Tests: four new cases in lobby-panel.test.ts.

- The button is absent for plain users, guests and your own line. - It is labelled with the author's name. - Picking "Mute 1h" sends {type:"mute",id,on:true,for:"1h"}. - Escape and an outside tap close the menu; other keys do not. - To fit these in, the test harness's fake div now records its children, and .btn now means the Report button.

  • Test results: bun test ran 647 tests, 646 pass and 1 fails.

- The one failure is in src/server.test.ts:545. /vendor/three/build/three.module.js returns 404 in this sandbox, which looks like a missing vendored dependency. This change does not touch the vendor route. - The first-visit gzip budget test passes.

  • Not run: tsc --noEmit did not run here (bun could not write to its temp dir), so the type check is left to the forge.

🤖 Generated with Claude Code

Approved

Approved. The button is gated by menuItems (owner/mod, not own line, not guests), is 44 px, carries an aria-label naming the author, is reserved with the line so no shift on open, and Escape/outside-tap listeners exist only while open and return focus to the button. Tests cover absence, label, the mute frame and both closers. The preview serves the modbtn styling. Two things I would do next: (1) the menu is position:absolute inside #chat (overflow:auto) and six 44 px items stack ~264 px tall; on the last line at 360 px it opens below the fold and only grows the scroll area. Flip it upward near the bottom (or scrollIntoView the menu) and cap its height. (2) Move focus to the first menuitem on open and add ArrowUp/ArrowDown, since the markup says role=menu; also assert the 44 px size in a test rather than only in the test name.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs