Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

Phone watchers see the last 3 chat lines faintly over the bottom of the video, never while driving #378

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

Phone watchers now see the last 3 chat lines faintly over the bottom of the camera, and the driver never does. I haven't opened it in a browser, and tsc wouldn't run here (bun couldn't write its temp dir), so the type check is also unrun. The whole suite is 622 pass, 2 fail.

Notes

shipped merged

opened this

Phone watchers now see the last 3 chat lines faintly over the bottom of the camera, and the driver never does. I haven't opened it in a browser, and tsc wouldn't run here (bun couldn't write its temp dir), so the type check is also unrun. The whole suite is 622 pass, 2 fail. bun test on the UI, portrait-layout and landscape-layout tests is green after I fixed one of the two.

  • Behaviour: src/ui/chat-glass.js keeps the last 3 lines and drops each after about 6 s. A tap on the overlay hides what is showing, and a line that arrives afterwards shows again. For the driver it returns nothing, and the lines clear the moment a turn starts.
  • Escaping: lines are drawn with textContent. Control characters are stripped and each line is capped at 160 characters.
  • Not over the model: #chatGlass sits in the camera's row only, in the phone-portrait stylesheet (src/ui/mobile.css). It is display: none everywhere else, including landscape and desktop.
  • Wiring: lobby-panel.js hands only newly said lines to page.said, not the history replay. viewer.html loads the overlay module on first use in phone portrait.
  • Tests: src/ui/chat-glass.test.ts covers watcher sees 3, driver sees 0, fading, tap, and escaping. forge.json is untouched.
  • Failures:

- The new overlay: my first CSS draft added an @keyframes rule that broke the portrait-layout test (every rule in mobile.css must sit under the portrait media query). I removed it, so the lines appear without a fade-in. - The two failing tests: one is the portrait-layout test above, now passing. The other, "serves the model, its meshes and the vendored libraries" in server.test.ts, also fails with my changes stashed. It looks unrelated to this change, and I didn't dig into why.

🤖 Generated with Claude Code

Closes #288

commented

Phone watchers now see the last 3 chat lines faintly over the bottom of the camera, and the driver never does. I haven't opened it in a browser, and tsc wouldn't run here (bun couldn't write its temp dir), so the type check is also unrun. The whole suite is 622 pass, 2 fail. bun test on the UI, portrait-layout and landscape-layout tests is green after I fixed one of the two.

  • Behaviour: src/ui/chat-glass.js keeps the last 3 lines and drops each after about 6 s. A tap on the overlay hides what is showing, and a line that arrives afterwards shows again. For the driver it returns nothing, and the lines clear the moment a turn starts.
  • Escaping: lines are drawn with textContent. Control characters are stripped and each line is capped at 160 characters.
  • Not over the model: #chatGlass sits in the camera's row only, in the phone-portrait stylesheet (src/ui/mobile.css). It is display: none everywhere else, including landscape and desktop.
  • Wiring: lobby-panel.js hands only newly said lines to page.said, not the history replay. viewer.html loads the overlay module on first use in phone portrait.
  • Tests: src/ui/chat-glass.test.ts covers watcher sees 3, driver sees 0, fading, tap, and escaping. forge.json is untouched.
  • Failures:

- The new overlay: my first CSS draft added an @keyframes rule that broke the portrait-layout test (every rule in mobile.css must sit under the portrait media query). I removed it, so the lines appear without a fade-in. - The two failing tests: one is the portrait-layout test above, now passing. The other, "serves the model, its meshes and the vendored libraries" in server.test.ts, also fails with my changes stashed. It looks unrelated to this change, and I didn't dig into why.

🤖 Generated with Claude Code

Approved

Does what #378 asks and nothing more. Lines go in with textContent, control characters are stripped, each line is capped at 160, and the overlay is CSS-hidden outside phone portrait. It sits in the camera row only and aria-hidden, so the real chat log stays the accessible copy. The driver gets nothing, and the lines clear when the turn changes. The module is small, has no new dependency, and the tests cover 3 lines, driver 0, fade, tap and escaping. The preview answers 200. I did not open it in a browser.

Two things to do next:

  1. The glass is only reachable by tap. When it has lines, #chatGlass is a click target over the bottom of the camera, so it can swallow taps meant for the video. Set pointer-events:none on it unless a tap-to-hide is truly wanted, and then test it on a 360px phone.
  2. The author says server.test.ts "serves the model, its meshes and the vendored libraries" fails even without this change. Open an issue for it rather than leaving it red. The mountGlass wiring in viewer.html also has no test, only createGlass does.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs