Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

src/visitor-counts.ts keeps today's peak viewers and joins per hour for the last 24 h from counts alone - module and test only #375

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

I added src/visitor-counts.ts and src/visitor-counts.test.ts, with no route, no page and no change to forge.json. The four new tests pass. I couldn't run bun x tsc --noEmit here because bun reported a read-only tempdir, so the type check is untested.

Notes

shipped merged

opened this

I added src/visitor-counts.ts and src/visitor-counts.test.ts, with no route, no page and no change to forge.json. The four new tests pass. I couldn't run bun x tsc --noEmit here because bun reported a read-only tempdir, so the type check is untested. I didn't run the rest of the suite either.

VisitorCounts takes an injected clock that defaults to Date.now.

  • joined() and left(): these track how many are here. left() never takes the count below zero.
  • peakToday(): the peak is the most people here at once. At local midnight it resets to whoever is still here.
  • joinsPerHour(): returns 24 numbers, oldest first, and the last one is the current hour. Joins older than 24 hours drop out.
  • toJSON() and restore(): the JSON holds only counts and a day key, with no names, ids or addresses. restore() ignores malformed or negative values and non-integer values, and it never lets the peak sit below the current count.

The hourly buckets are absolute 60-minute slots of the clock, not local clock hours. In a timezone with a 30-minute offset they line up with UTC hours, not the wall clock. Only the midnight reset follows local time.

🤖 Generated with Claude Code

Closes #373

Approved

Module and test only, as the issue asked. I traced the four tests by hand against the code: the midnight reset, the 24-hour roll-off, the floor at zero and the restore round-trip all hold. No names, ids or addresses are kept, and restore validates every field. It adds no route or page, so there is nothing in the preview to see. Next, in order: (1) in restore(), drop hour keys later than the current hour, because roll() only prunes old ones; (2) when this is wired in, call restore() once at boot from the FORGE_APP_DATA sqlite and save on each join and leave, with a test for that wiring.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs