Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

workbenchthis machine

While the keyboard is open on a phone, the camera shrinks to a 120 px mini player and returns when it closes #351

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

smith/arm:smith/287-while-the-keyboard-is-open-on-a-phone-th → main 1 commit fork

  • Merged. smith/287-while-the-keyboard-is-open-on-a-phone-th was merged into main as e8b1177.

Review

Sign in to review this change.
3 files changed +8 −2
Software/so101/src/composer-viewport.test.ts +6
@@ -22,3 +22,9 @@ test("the composer's input is at least 16px, so iOS does not zoom", () => {
2222 const rule = html.match(/select, input\[type=number\], input\[type=text\] \{([^}]*)\}/)?.[1] ?? "";
2323 expect(Number(rule.match(/font-size: (\d+)px/)?.[1])).toBeGreaterThanOrEqual(16);
2424 });
25
26 test("while typing, the camera is a 120px mini player on every phone layout", async () => {
27 const mobile = await Bun.file(new URL("./ui/mobile.css", import.meta.url)).text();
28 expect(html).toMatch(/#shell\.typing \{ --view: 120px; \}/);
29 expect(mobile).toMatch(/#shell\.typing \{ grid-template-rows: 120px auto 0 minmax\(0, 1fr\); \}/);
30 });
Software/so101/src/ui/mobile.css +1 −1
@@ -22,7 +22,7 @@
2222 /* The model is always on here, so its view button goes; the camera buttons pick which camera is on top. */
2323 #v3 { display: none; }
2424 /* The keyboard is up: the view gives way to the chat, as it does on every layout, and the model folds away. */
25 #shell.typing { grid-template-rows: minmax(0, var(--view)) auto 0 minmax(0, 1fr); }
25 #shell.typing { grid-template-rows: 120px auto 0 minmax(0, 1fr); }
2626 /* One status line: the arm's state moves from over the video into the strip, and the driver's name over the video goes,
2727 since the strip already says who drives. */
2828 #top .info, #driverTag { display: none; }
Software/so101/src/viewer.html +1 −1
@@ -57,7 +57,7 @@
5757 [inert] { opacity: .5; }
5858
5959 #shell { position: fixed; left: 0; right: 0; top: var(--vvtop, 0px); height: var(--vvh, 100dvh); display: grid; grid-template-columns: 100%; grid-template-rows: minmax(0, var(--view)) auto minmax(0, 1fr); grid-template-areas: "view" "strip" "sheet"; }
60 #shell.typing { --view: 24%; }
60 #shell.typing { --view: 120px; }
6161
6262 /* the view: cameras and the 3D model, always on black */
6363 #app { grid-area: view; position: relative; min-height: 0; background: #000; color: #e8eaed; overflow: hidden; }

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs