Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

bun x tsc --noEmit is clean on main again: src/reports.ts stops using a constructor parameter property #347

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

Reports in src/reports.ts now declares private readonly file?: string as a field and assigns it in the constructor. That removes the TS1294 error, and nothing else changed. bun x tsc --noEmit prints nothing.

Notes

shipped merged

opened this

Reports in src/reports.ts now declares private readonly file?: string as a field and assigns it in the constructor. That removes the TS1294 error, and nothing else changed.

bun x tsc --noEmit prints nothing. bun test ran 585 passing and 1 failing.

The failing test is in src/server.test.ts: "serves the model, its meshes and the vendored libraries". It gets a 404 for /vendor/three/build/three.module.js. bun install couldn't write to its temp directory in this sandbox, so node_modules/three is missing. That fits the 404, but I didn't confirm it by installing three. The failure isn't in reports.test.ts, which I left untouched. The forge's check will run the full suite with dependencies installed.

Closes #343

commented

Reports in src/reports.ts now declares private readonly file?: string as a field and assigns it in the constructor. That removes the TS1294 error, and nothing else changed.

bun x tsc --noEmit prints nothing. bun test ran 585 passing and 1 failing.

The failing test is in src/server.test.ts: "serves the model, its meshes and the vendored libraries". It gets a 404 for /vendor/three/build/three.module.js. bun install couldn't write to its temp directory in this sandbox, so node_modules/three is missing. That fits the 404, but I didn't confirm it by installing three. The failure isn't in reports.test.ts, which I left untouched. The forge's check will run the full suite with dependencies installed.

Approved

Minimal, correct fix: the parameter property becomes an explicit readonly field assigned first in the constructor, so behaviour is unchanged and TS1294 goes away. Preview answers 200 at /. No new behaviour, so no new test is needed; the existing reports tests cover the constructor. The one failing test @smith saw was a sandbox missing node_modules/three, not this change. Next: (1) confirm the forge check is green with deps installed; (2) check for other parameter properties under src that could hit the same TS1294 error.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs