Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

Phone portrait shows every joint slider at once in a collapsible tray under the model, in place of the one-joint lever #346

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

On a phone held upright (up to 600 px wide), the Drive tab now shows every joint and the gripper at once instead of the one-joint lever. Each is a compact row with its name, slider and value, and its rail has the intent mark and the actual mark. The rows sit in a tray under the 3D model.

Notes

shipped merged

opened this

On a phone held upright (up to 600 px wide), the Drive tab now shows every joint and the gripper at once instead of the one-joint lever. Each is a compact row with its name, slider and value, and its rail has the intent mark and the actual mark. The rows sit in a tray under the 3D model. A one-line Joints button folds the tray and opens it again. Folded, the poses, Hold, Record and the rest of the controls fold with it, so the model takes the room. STOP stays in the strip either way.

  • viewer.html: the #touch section (chips, lever, ▲/▼) and its script are gone. #joints is wrapped in <section id="tray"> with #trayToggle. The rule that hid #joints in portrait is gone too. Rows get short labels (Base, Shoulder… Grip) for the narrow width, and the slider keeps the full name as its accessible label.
  • ui/drive.js: now bindTray. It sets .shut and aria-expanded, and remembers the choice in localStorage (so101.tray). If storage refuses, it still works and starts open. Only the lever and nudges used the old velocity Drive/Driver/bindSurface, so they are deleted with their tests, as #328 did for the sticks. The "end of range" buzz went with the lever.
  • ui/mobile.css: the compact rows ("name slide val", one 44 px line each, −/+ and temperature hidden), the tray button, and the folded state (#tray.shut #joints, #tray.shut ~ *). ui/tabs.css: the lever's rules are removed.
  • Tests:

- ui/drive.test.ts checks that a tap folds and opens the tray, that the choice persists, and that a refusing store doesn't break it. - portrait-layout.test.ts at 390x844 checks: - the lever is gone, and the tray holds one row per joint, each with a slider and both marks; - no portrait rule hides the rows, their sliders or STOP, except a folded tray (the old #joints { display: none !important } would fail this); - open, all six rows fit without scrolling with the model above them; - folded, the tray is one line, the model grows and STOP's row stays. - server.test.ts now asserts the lever is gone. That changed because the behaviour changed, not because the test was wrong.

bun --cwd Software/so101 test: 569 pass, 0 fail. bun x tsc --noEmit reports one error, in src/reports.ts line 29 (erasableSyntaxOnly); that file isn't part of this change. forge.json is untouched, and the README's phone-controls section is rewritten. I haven't seen it rendered on a phone yet; the layout tests read the stylesheets rather than a browser.

To try it, open the preview at 390x844 and take a turn: the Drive tab shows every joint's slider under the model. Tap Joints to fold the tray and again to open it.

🤖 Generated with Claude Code

Closes #276

commented

On a phone held upright (up to 600 px wide), the Drive tab now shows every joint and the gripper at once instead of the one-joint lever. Each is a compact row with its name, slider and value, and its rail has the intent mark and the actual mark. The rows sit in a tray under the 3D model. A one-line Joints button folds the tray and opens it again. Folded, the poses, Hold, Record and the rest of the controls fold with it, so the model takes the room. STOP stays in the strip either way.

  • viewer.html: the #touch section (chips, lever, ▲/▼) and its script are gone. #joints is wrapped in <section id="tray"> with #trayToggle. The rule that hid #joints in portrait is gone too. Rows get short labels (Base, Shoulder… Grip) for the narrow width, and the slider keeps the full name as its accessible label.
  • ui/drive.js: now bindTray. It sets .shut and aria-expanded, and remembers the choice in localStorage (so101.tray). If storage refuses, it still works and starts open. Only the lever and nudges used the old velocity Drive/Driver/bindSurface, so they are deleted with their tests, as #328 did for the sticks. The "end of range" buzz went with the lever.
  • ui/mobile.css: the compact rows ("name slide val", one 44 px line each, −/+ and temperature hidden), the tray button, and the folded state (#tray.shut #joints, #tray.shut ~ *). ui/tabs.css: the lever's rules are removed.
  • Tests:

- ui/drive.test.ts checks that a tap folds and opens the tray, that the choice persists, and that a refusing store doesn't break it. - portrait-layout.test.ts at 390x844 checks: - the lever is gone, and the tray holds one row per joint, each with a slider and both marks; - no portrait rule hides the rows, their sliders or STOP, except a folded tray (the old #joints { display: none !important } would fail this); - open, all six rows fit without scrolling with the model above them; - folded, the tray is one line, the model grows and STOP's row stays. - server.test.ts now asserts the lever is gone. That changed because the behaviour changed, not because the test was wrong.

bun --cwd Software/so101 test: 569 pass, 0 fail. bun x tsc --noEmit reports one error, in src/reports.ts line 29 (erasableSyntaxOnly); that file isn't part of this change. forge.json is untouched, and the README's phone-controls section is rewritten. I haven't seen it rendered on a phone yet; the layout tests read the stylesheets rather than a browser.

To try it, open the preview at 390x844 and take a turn: the Drive tab shows every joint's slider under the model. Tap Joints to fold the tray and again to open it.

🤖 Generated with Claude Code

Approved

Approved from the diff. The preview answered 503 (no available server) when I tried it, so I could not see it rendered. Nothing in the diff gives me a reason to block.

What I checked in the diff: every joint and the gripper get a 44px row with a real range input, and its accessible name is the full joint name (the short label is aria-hidden). The Joints button is a real button with aria-expanded and aria-controls. The folded state hides only #joints and the controls after the tray, never STOP or the strip. The old #joints{display:none!important} is gone. The tray choice is kept in localStorage and survives a refusing store. Tests cover the fold, the persistence and the layout geometry at 390x844. The dead lever code, its CSS and its tests are removed with it, as #328 did for the sticks. It adds no new write path, no dependency and nothing outside the issue.

Two things I would do next:

  1. Look at it on a real 360px phone, or in the preview once it is back up. The layout tests read stylesheets, not a browser, and the author has not seen it rendered either. Check that the Base/Shoulder/Elbow/Wrist/Roll/Grip labels, the slider and the 4.5ch value all fit at 360px without the value clipping.
  2. Say when a joint hits the end of its range. The lever buzzed and flashed at that point and the sliders do not, so a person pushing the slider gets no word that the limit stopped them.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs