Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

Phone on its side: STOP fixed top-right inside the safe area, sticks in the lower corners once a turn starts, proven by a stylesheet test #329

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

This carries the #301 work (aa0a25e and 46e5866) onto main as one commit. It applied cleanly, with no other edits.

Notes

shipped merged

opened this

This carries the #301 work (aa0a25e and 46e5866) onto main as one commit. It applied cleanly, with no other edits.

Phone on its side ((orientation: landscape) and (max-height: 500px), in Software/so101/src/viewer.html):

  • STOP: it is now position: fixed in the top-right corner, inside the top and right safe-area insets (the patch adds a --safe-t variable for the top one). It has a fixed width --stop-w: 112px, so "Stop" and "Stopped" sit in the same place.
  • Strip and buttons: the strip's backdrop-filter moves onto #strip::before, so the strip no longer pins STOP to itself. The strip, the view buttons (#top) and the sheet's top padding all leave STOP's corner free.
  • Sticks: applyLock now puts the sheet away when a turn starts with the phone already on its side, so the joint sticks show in the lower corners straight away.

Portrait and desktop are unchanged: there is still one [data-stop], and it is still in the strip's markup.

The new test, src/landscape-layout.test.ts, starts the server and reads the stylesheet it serves. It checks the STOP position and width, that nothing around STOP has a filter or transform, the sticks, the free corner, the JavaScript guard, and that only the sideways layout moves STOP. Against main's viewer.html it fails 5 of its 8 tests; with the change all 8 pass. stop-layout, stop and portrait-layout also pass, as does the under-52 KB gzipped first-visit test in server.test.ts. tsc --noEmit is clean. The README's landscape note now says where STOP goes.

The old preview failure was likely the one sandbox-only install miss the issue mentions: bun install here only works with BUN_TMPDIR pointed at $TMPDIR, and nothing in the repository needed changing for it. This pull's preview had not shown up in the list of reachable previews when this was written, so I have not checked that it deploys or that / answers on it. If its deploy fails, the forge's log names the cause. No browser dependency was added, and, as the issue says, there are no Playwright tests or screenshots.

To try it: bun --cwd Software/so101 test src/landscape-layout.test.ts. Or open the preview in a phone-sized landscape viewport (844x390), take a turn, and STOP sits top-right with the sticks in the lower corners.

🤖 Generated with Claude Code

Closes #312

commented

This carries the #301 work (aa0a25e and 46e5866) onto main as one commit. It applied cleanly, with no other edits.

Phone on its side ((orientation: landscape) and (max-height: 500px), in Software/so101/src/viewer.html):

  • STOP: it is now position: fixed in the top-right corner, inside the top and right safe-area insets (the patch adds a --safe-t variable for the top one). It has a fixed width --stop-w: 112px, so "Stop" and "Stopped" sit in the same place.
  • Strip and buttons: the strip's backdrop-filter moves onto #strip::before, so the strip no longer pins STOP to itself. The strip, the view buttons (#top) and the sheet's top padding all leave STOP's corner free.
  • Sticks: applyLock now puts the sheet away when a turn starts with the phone already on its side, so the joint sticks show in the lower corners straight away.

Portrait and desktop are unchanged: there is still one [data-stop], and it is still in the strip's markup.

The new test, src/landscape-layout.test.ts, starts the server and reads the stylesheet it serves. It checks the STOP position and width, that nothing around STOP has a filter or transform, the sticks, the free corner, the JavaScript guard, and that only the sideways layout moves STOP. Against main's viewer.html it fails 5 of its 8 tests; with the change all 8 pass. stop-layout, stop and portrait-layout also pass, as does the under-52 KB gzipped first-visit test in server.test.ts. tsc --noEmit is clean. The README's landscape note now says where STOP goes.

The old preview failure was likely the one sandbox-only install miss the issue mentions: bun install here only works with BUN_TMPDIR pointed at $TMPDIR, and nothing in the repository needed changing for it. This pull's preview had not shown up in the list of reachable previews when this was written, so I have not checked that it deploys or that / answers on it. If its deploy fails, the forge's log names the cause. No browser dependency was added, and, as the issue says, there are no Playwright tests or screenshots.

To try it: bun --cwd Software/so101 test src/landscape-layout.test.ts. Or open the preview in a phone-sized landscape viewport (844x390), take a turn, and STOP sits top-right with the sticks in the lower corners.

🤖 Generated with Claude Code

Approved

Does what #329 asks and nothing more. The preview answers 200 and serves the new rule: STOP is fixed top-right inside --safe-t and --safe-r, with a fixed --stop-w width so Stop and Stopped sit in the same place. The strip, the view buttons and the sheet padding leave that corner free. Moving the blur to #strip::before keeps the strip from pinning the fixed STOP. The new stylesheet test fails without the change, and the README says where STOP goes. Portrait and desktop are untouched. No new dependency. I only read the served CSS; I did not look at it in a browser on a 360px phone. Two things to do next: 1) Add a real landscape screenshot or Playwright check at 844x390 and 915x412 once a browser is allowed, because the CSS parser in the test only proves declarations, not that STOP does not overlap the strip or #top. 2) Check that the 112px STOP is not covered by the sheet header or its toggle when the sheet is out. The sheet is z-index 7 and STOP is 9, so it should be fine, but confirm it on a device.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs