Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

On a phone the chat composer stays above the keyboard, and typing never zooms the page #308

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

The viewport fix is in place, but the Playwright check at 390x844 and 412x915 is not done. There is no browser in this sandbox, so I only read the page's code and CSS in tests. Nothing has been checked on a phone or an emulated keyboard.

Notes

shipped merged

opened this

The viewport fix is in place, but the Playwright check at 390x844 and 412x915 is not done. There is no browser in this sandbox, so I only read the page's code and CSS in tests. Nothing has been checked on a phone or an emulated keyboard.

  • Viewer page (Software/so101/src/viewer.html): the page already had most of this. The meta tag had interactive-widget=resizes-content, the text inputs were 16 px, and #shell was fixed to the visual viewport. I made two small changes. The visualViewport resize and scroll handler now sets --vvh and --vvtop on the root element. They were --vv-h and --vv-top on the shell before. #shell reads the new names, and it is the box the composer sits at the bottom of.
  • New test (src/composer-viewport.test.ts): it checks four things: the meta tag, that resize and scroll both set --vvh, that the shell is pinned to the visual viewport, and that the input font is at least 16 px.
  • Test run: the new test and the portrait-layout test pass (12 tests). bun x tsc --noEmit failed with a read-only temp directory error, so the type check did not run. I did not run the full bun --cwd Software/so101 test, and forge.json is untouched.

Closes #285

commented

The viewport fix is in place, but the Playwright check at 390x844 and 412x915 is not done. There is no browser in this sandbox, so I only read the page's code and CSS in tests. Nothing has been checked on a phone or an emulated keyboard.

  • Viewer page (Software/so101/src/viewer.html): the page already had most of this. The meta tag had interactive-widget=resizes-content, the text inputs were 16 px, and #shell was fixed to the visual viewport. I made two small changes. The visualViewport resize and scroll handler now sets --vvh and --vvtop on the root element. They were --vv-h and --vv-top on the shell before. #shell reads the new names, and it is the box the composer sits at the bottom of.
  • New test (src/composer-viewport.test.ts): it checks four things: the meta tag, that resize and scroll both set --vvh, that the shell is pinned to the visual viewport, and that the input font is at least 16 px.
  • Test run: the new test and the portrait-layout test pass (12 tests). bun x tsc --noEmit failed with a read-only temp directory error, so the type check did not run. I did not run the full bun --cwd Software/so101 test, and forge.json is untouched.
Approved

Approved. The preview serves the interactive-widget=resizes-content meta, the shell pinned to --vvtop/--vvh, and the 16px composer input (#sayText, type=text, covered by the 16px rule). The change is a small, safe rename that moves the vars to the root, plus a source-reading test. Honest caveat: nothing was checked in a real browser or with a keyboard, as the pull says. Two things next: (1) run the 390x844 and 412x915 Playwright check somewhere with a browser, since the new tests only grep the HTML and would pass even if the layout broke; (2) add a fallback so --vvh also tracks window.innerHeight when visualViewport is missing, and keep the 100dvh default.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs