Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

Mobile landscape: video fills the screen, controls overlay the lower corners, STOP top-right #301

Parked opened this
Closed without merging

On a phone on its side ((orientation: landscape) and (max-height: 500px), which covers 844x390 and 915x412), STOP now sits in the top-right corner, inside the safe-area insets. The joint sticks come up in the lower corners as soon as a turn starts. Portrait and desktop are unchanged.

Notes

stopped parked by the crew

opened this

On a phone on its side ((orientation: landscape) and (max-height: 500px), which covers 844x390 and 915x412), STOP now sits in the top-right corner, inside the safe-area insets. The joint sticks come up in the lower corners as soon as a turn starts. Portrait and desktop are unchanged.

What changed (Software/so101/src/viewer.html)

  • STOP: in this layout it is position: fixed at top-right. Its offsets include var(--vv-top), env(safe-area-inset-top) (as the new --safe-t) and --safe-r. It has one fixed width (--stop-w: 112px), so the switch from "Stop" to "Stopped" doesn't move anything. It sits over the sheet when the sheet is out, and the sheet gets top padding so STOP doesn't cover its content.
  • The strip's blur: it moved off the strip onto a #strip::before layer behind the content. A backdrop-filter on the strip itself would have pinned the fixed STOP to the strip instead of the screen. The strip looks the same.
  • Room for STOP: with the sheet away, the strip's max-width and the view buttons' right and max-width now leave STOP's corner free. The strip also respects the top inset.
  • Sticks: a turn that starts with the phone already on its side now puts the sheet away, so the sticks show. Before, that only happened when the phone was rotated. The README already said the sheet tucks away "when your turn starts", which this makes true; its landscape note now also says where STOP sits.
  • Video: it already filled 100dvh and is unchanged.

Test: src/landscape-layout.test.ts serves the page and reads the stylesheet's rules for this media query. It checks:

  • the 100dvh single-row shell;
  • STOP fixed top-right with the inset variables and no left;
  • nothing on the strip or shell (backdrop-filter, transform, filter) that would pin a fixed child to it;
  • the sticks shown while driving in the lower corners, inside the insets;
  • the strip and view buttons kept clear of STOP's corner;
  • the new auto-hide line in the script;
  • STOP's position set only in the landscape block, and still in the strip's markup for portrait and desktop.

5 of its 8 cases fail against main. src/stop-layout.test.ts (still exactly one [data-stop], never hidden, fires on pointerdown) and src/stop.test.ts pass. tsc --noEmit has one error, in src/lobby.ts:357; that file is unchanged here.

Not done: there is no Playwright test and there are no screenshots. #91 had already dropped the browser test because the repository has no browser dependency, and I didn't add one. Chromium is installed in the sandbox, but it can't start here because it needs a unix socket, so I had no way to render the page. To try it: open the preview in a phone emulator at 844x390 or 915x412 landscape and take a turn (fake arm). The sheet slides away, the sticks fill the lower corners and STOP stays top-right; tap Show and STOP stays put over the sheet.

🤖 Generated with Claude Code

Closes #93

commented

On a phone on its side ((orientation: landscape) and (max-height: 500px), which covers 844x390 and 915x412), STOP now sits in the top-right corner, inside the safe-area insets. The joint sticks come up in the lower corners as soon as a turn starts. Portrait and desktop are unchanged.

What changed (Software/so101/src/viewer.html)

  • STOP: in this layout it is position: fixed at top-right. Its offsets include var(--vv-top), env(safe-area-inset-top) (as the new --safe-t) and --safe-r. It has one fixed width (--stop-w: 112px), so the switch from "Stop" to "Stopped" doesn't move anything. It sits over the sheet when the sheet is out, and the sheet gets top padding so STOP doesn't cover its content.
  • The strip's blur: it moved off the strip onto a #strip::before layer behind the content. A backdrop-filter on the strip itself would have pinned the fixed STOP to the strip instead of the screen. The strip looks the same.
  • Room for STOP: with the sheet away, the strip's max-width and the view buttons' right and max-width now leave STOP's corner free. The strip also respects the top inset.
  • Sticks: a turn that starts with the phone already on its side now puts the sheet away, so the sticks show. Before, that only happened when the phone was rotated. The README already said the sheet tucks away "when your turn starts", which this makes true; its landscape note now also says where STOP sits.
  • Video: it already filled 100dvh and is unchanged.

Test: src/landscape-layout.test.ts serves the page and reads the stylesheet's rules for this media query. It checks:

  • the 100dvh single-row shell;
  • STOP fixed top-right with the inset variables and no left;
  • nothing on the strip or shell (backdrop-filter, transform, filter) that would pin a fixed child to it;
  • the sticks shown while driving in the lower corners, inside the insets;
  • the strip and view buttons kept clear of STOP's corner;
  • the new auto-hide line in the script;
  • STOP's position set only in the landscape block, and still in the strip's markup for portrait and desktop.

5 of its 8 cases fail against main. src/stop-layout.test.ts (still exactly one [data-stop], never hidden, fires on pointerdown) and src/stop.test.ts pass. tsc --noEmit has one error, in src/lobby.ts:357; that file is unchanged here.

Not done: there is no Playwright test and there are no screenshots. #91 had already dropped the browser test because the repository has no browser dependency, and I didn't add one. Chromium is installed in the sandbox, but it can't start here because it needs a unix socket, so I had no way to render the page. To try it: open the preview in a phone emulator at 844x390 or 915x412 landscape and take a turn (fake arm). The sheet slides away, the sticks fill the lower corners and STOP stays top-right; tap Show and STOP stays put over the sheet.

🤖 Generated with Claude Code

commented

Parked by the crew: the preview's deploy failed and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs