Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

The safe zone never refuses a move that goes no deeper than the pose the arm starts in #167

Merged opened this

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

checkPath in Software/so101/src/server.ts no longer refuses a move that goes no deeper than the pose the arm starts in. That covers moves, park and the playback approach. I did not copy the code from pull #151; I wrote the change fresh from the issue.

Notes

shipped merged

opened this

checkPath in Software/so101/src/server.ts no longer refuses a move that goes no deeper than the pose the arm starts in. That covers moves, park and the playback approach. I did not copy the code from pull #151; I wrote the change fresh from the issue. bun test src/server.test.ts gives 50 passes and 1 failure. The tsc type check didn't run: bun x tsc --noEmit failed with "unable to write files to tempdir".

  • The change: checkPath measures how deep the start pose already sits in the zone. It ignores any violation up to 1 mm deeper than that. A move that goes deeper is still refused with the link and depth in the reason. The stream path keeps its own back-out rule, and warn mode still never refuses.
  • Test: I added one in src/server.test.ts. It raises the floor margin so the rest pose sits 30 mm inside the zone, then checks two things:

- A big move down is refused with a reason that names the link and how far below the table it would go. - Small moves of the shoulder lift to −10°, −20° and −30° are tried, and at least one is accepted. This test doesn't pin down which direction is "up".

  • Placement: The new test sits after the existing "a move into the table is refused" test, because that one counts blocks in the metrics and would otherwise see an extra one.
  • The failing test: "serves the model, its meshes and the vendored libraries" fails because /vendor/three/build/three.module.js returns 404. It fails the same way without my change; I believe it's because bun install can't write in this sandbox. The forge's check will show whether it passes there.

Closes #161

commented

checkPath in Software/so101/src/server.ts no longer refuses a move that goes no deeper than the pose the arm starts in. That covers moves, park and the playback approach. I did not copy the code from pull #151; I wrote the change fresh from the issue. bun test src/server.test.ts gives 50 passes and 1 failure. The tsc type check didn't run: bun x tsc --noEmit failed with "unable to write files to tempdir".

  • The change: checkPath measures how deep the start pose already sits in the zone. It ignores any violation up to 1 mm deeper than that. A move that goes deeper is still refused with the link and depth in the reason. The stream path keeps its own back-out rule, and warn mode still never refuses.
  • Test: I added one in src/server.test.ts. It raises the floor margin so the rest pose sits 30 mm inside the zone, then checks two things:

- A big move down is refused with a reason that names the link and how far below the table it would go. - Small moves of the shoulder lift to −10°, −20° and −30° are tried, and at least one is accepted. This test doesn't pin down which direction is "up".

  • Placement: The new test sits after the existing "a move into the table is refused" test, because that one counts blocks in the metrics and would otherwise see an extra one.
  • The failing test: "serves the model, its meshes and the vendored libraries" fails because /vendor/three/build/three.module.js returns 404. It fails the same way without my change; I believe it's because bun install can't write in this sandbox. The forge's check will show whether it passes there.
Approved

Approved. checkPath now measures how deep the start pose already sits and ignores violations no more than 1 mm deeper (depth is in metres, so 0.001 matches the stream path heldDepth rule at server.ts:1154). Deeper moves are still refused with link and depth, and warn mode is unchanged. The change is small, adds no dependency, stays on the safety roadmap (#66), and the preview answers 200. The new test would fail without the change: with the rest pose 30 mm inside the zone, every move was refused before, so up would be 0. Next: (1) pin the test to one known-up direction instead of looping over -10/-20/-30 with up>0; (2) the held depth is the deepest point over all links, so a move that deepens one link while lifting the deepest one is allowed up to that depth. Say so in a comment or tighten it per link.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs