Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

TOP: the arm moves when you drive it - the collision guard blocks every move because the virtual table is 3 cm too high, and the driver is not registered #151

Parked opened this in answer to
Closed without merging

This pull covers part of #144. The driver is now in /status, the zone guard only refuses a move that goes deeper, and the table height can be set. The UI and Machine panel refusal display, the admin control for the table height and the "set the table here" button are not done.

Notes

stopped parked by the crew deploy 0e76704

opened this

This pull covers part of #144. The driver is now in /status, the zone guard only refuses a move that goes deeper, and the table height can be set. The UI and Machine panel refusal display, the admin control for the table height and the "set the table here" button are not done. I couldn't run the type check (bun can't write its tempdir here). The targeted tests pass, except the vendored three.js test in server.test.ts. It failed the same way before my change.

  • Driver in /status: src/relay.ts now adds driver: {id, name, owner} | null from the turn holder, owner included. Before, the driver key was always null even while someone held the turn. The existing turn logic already lets the owner jump the line, so I changed nothing there.
  • Zone guard never blocks backing out: In src/server.ts, checkPath (used by moves, park and the playback approach) now ignores any penetration no deeper than the pose the arm starts in. A move that goes deeper is still refused with the "below the table" reason. The stream path already allowed backing out, and warn mode already never refused.
  • Table calibration: A new tableOffsetMm setting (±100, saved in settings) lowers the virtual table. POST /settings/table-here sets it from the arm's lowest point right now, rounded up so the resting arm is not flagged. The configured margin still applies above the table.
  • Tests:

- Backing out: an arm in the table can move up but not deeper, and "table here" clears the violation (server.test.ts). - /status driver: it is null at first, then shows alice, then the owner after they take over (stop.test.ts). - Not tested: "a driver's slider move reaches the fake Pi within one frame."

Left undone:

  • Showing refusals in the UI and the Machine panel.
  • The admin control for the table height and the "set the table here" button.
  • A table default taken from the arm at rest.

I did not check the real arm, since its failure was likely the unregistered driver rather than the guard.

🤖 Generated with Claude Code

Closes #144

commented

This pull covers part of #144. The driver is now in /status, the zone guard only refuses a move that goes deeper, and the table height can be set. The UI and Machine panel refusal display, the admin control for the table height and the "set the table here" button are not done. I couldn't run the type check (bun can't write its tempdir here). The targeted tests pass, except the vendored three.js test in server.test.ts. It failed the same way before my change.

  • Driver in /status: src/relay.ts now adds driver: {id, name, owner} | null from the turn holder, owner included. Before, the driver key was always null even while someone held the turn. The existing turn logic already lets the owner jump the line, so I changed nothing there.
  • Zone guard never blocks backing out: In src/server.ts, checkPath (used by moves, park and the playback approach) now ignores any penetration no deeper than the pose the arm starts in. A move that goes deeper is still refused with the "below the table" reason. The stream path already allowed backing out, and warn mode already never refused.
  • Table calibration: A new tableOffsetMm setting (±100, saved in settings) lowers the virtual table. POST /settings/table-here sets it from the arm's lowest point right now, rounded up so the resting arm is not flagged. The configured margin still applies above the table.
  • Tests:

- Backing out: an arm in the table can move up but not deeper, and "table here" clears the violation (server.test.ts). - /status driver: it is null at first, then shows alice, then the owner after they take over (stop.test.ts). - Not tested: "a driver's slider move reaches the fake Pi within one frame."

Left undone:

  • Showing refusals in the UI and the Machine panel.
  • The admin control for the table height and the "set the table here" button.
  • A table default taken from the arm at rest.

I did not check the real arm, since its failure was likely the unregistered driver rather than the guard.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs