Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

Phone portrait: the video is pinned on top with its 16:9 box reserved (no layout shift), and one status strip sits under it #147

Closed opened this
Closed without merging

On a phone held upright, the video is now pinned to the top of the screen with its 16:9 space held before the first frame arrives, and one status strip sits directly under it. The desktop and landscape layouts don't change. Why the last pull went red.

Notes

stopped closed without shipping deploy a1f5fa6

opened this

On a phone held upright, the video is now pinned to the top of the screen with its 16:9 space held before the first frame arrives, and one status strip sits directly under it. The desktop and landscape layouts don't change.

Why the last pull went red. The check failed in 0.02 s with forge.json: check.run is required, so it never got as far as this change. Main's 8190a91 added a check block with only limits. The preview deploy for the same commit ran the tests and passed. This pull gives the check a command that runs the type check and the tests: cd Software/so101 && bun install --frozen-lockfile && bun x tsc --noEmit && bun test. This is the one new commit; until it lands on main, every other pull's check will fail the same way. Here, tsc --noEmit is clean and src/server.test.ts passes 50 of 50. I didn't rerun the full suite after the fix; an earlier run had one failure, which came from a half-installed node_modules in my sandbox.

The phone layout (unchanged from #115).

  • src/ui/mobile.css: a new file, linked from viewer.html under (max-width: 600px) and (orientation: portrait), so other layouts never load its rules.

- The video box is full-bleed, position: sticky; top: 0, with aspect-ratio: 16 / 9, so nothing moves when the picture arrives. - The notch (env(safe-area-inset-top)) is a black band above the picture and doesn't change the 16:9 ratio.

  • One status strip: it shows who drives, the time left and your place in line. It now also shows the arm's state (live or reconnecting) in a new #armLine, which copies the words the overlay already shows. On phones the overlay's status line and the driver's name tag over the video are hidden, so nothing appears twice.
  • src/server.ts: stylesheets in src/ui are served like the page's scripts: text/css, an immutable cache, and a path that changes when the file does.
  • Test: a new test in src/server.test.ts checks that the page links the stylesheet with that media query and that it answers 200 with text/css.

Not done: the rest of #90 (the controls below the strip). It also hasn't been checked in a real browser at 390×844 or 412×915; only the server test covers the CSS and markup.

To try it: open the preview in a 390×844 or 412×915 portrait viewport and reload. The box under the browser bar stays black and still until the picture arrives, and the strip under it reads, for example, "Live arm · … · camera live".

Closes #112

🤖 Generated with Claude Code

Closes #112

commented

On a phone held upright, the video is now pinned to the top of the screen with its 16:9 space held before the first frame arrives, and one status strip sits directly under it. The desktop and landscape layouts don't change.

Why the last pull went red. The check failed in 0.02 s with forge.json: check.run is required, so it never got as far as this change. Main's 8190a91 added a check block with only limits. The preview deploy for the same commit ran the tests and passed. This pull gives the check a command that runs the type check and the tests: cd Software/so101 && bun install --frozen-lockfile && bun x tsc --noEmit && bun test. This is the one new commit; until it lands on main, every other pull's check will fail the same way. Here, tsc --noEmit is clean and src/server.test.ts passes 50 of 50. I didn't rerun the full suite after the fix; an earlier run had one failure, which came from a half-installed node_modules in my sandbox.

The phone layout (unchanged from #115).

  • src/ui/mobile.css: a new file, linked from viewer.html under (max-width: 600px) and (orientation: portrait), so other layouts never load its rules.

- The video box is full-bleed, position: sticky; top: 0, with aspect-ratio: 16 / 9, so nothing moves when the picture arrives. - The notch (env(safe-area-inset-top)) is a black band above the picture and doesn't change the 16:9 ratio.

  • One status strip: it shows who drives, the time left and your place in line. It now also shows the arm's state (live or reconnecting) in a new #armLine, which copies the words the overlay already shows. On phones the overlay's status line and the driver's name tag over the video are hidden, so nothing appears twice.
  • src/server.ts: stylesheets in src/ui are served like the page's scripts: text/css, an immutable cache, and a path that changes when the file does.
  • Test: a new test in src/server.test.ts checks that the page links the stylesheet with that media query and that it answers 200 with text/css.

Not done: the rest of #90 (the controls below the strip). It also hasn't been checked in a real browser at 390×844 or 412×915; only the server test covers the CSS and markup.

To try it: open the preview in a 390×844 or 412×915 portrait viewport and reload. The box under the browser bar stays black and still until the picture arrives, and the strip under it reads, for example, "Live arm · … · camera live".

Closes #112

🤖 Generated with Claude Code

commented

Declined: I can't fix this from the branch. The check reads forge.json from main, not from the pull: the log says main: forge.json: check.run is required. Pushing to main is refused for agents. Run log: https://forge.open-platform.sh/trevato/arm/runs/01m5e1cjmnyc0g3h7x25e15a16

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs