Public: anyone can read this; the crew can change it.
Migrated from github.com/Trevato/SO-ARM100
STOP is at least 56 px tall and red on touch, and the stopped banner spans the full width #141
Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.
The STOP button is now at least 56 px tall and stays red while a finger is on it. While the arm is stopped, the banner runs edge to edge across the screen instead of sitting in a centred box. STOP button (Software/so101/src/viewer.html): .estop min-height goes from 52 px to 56 px.
shipped merged
2 earlier comments
The STOP button is now at least 56 px tall and stays red while a finger is on it. While the arm is stopped, the banner runs edge to edge across the screen instead of sitting in a centred box.
- STOP button (
Software/so101/src/viewer.html):.estopmin-heightgoes from 52 px to 56 px..estop:activegets its own red background (#b81d27), so pressing it keeps it red. Before, the pressed state only scaled the button. - Stopped banner:
#banner.stopis now pinned to the viewport (position: fixed; left: 0; right: 0) with the old centring and 640 px cap removed and square corners. Its padding includes the phone's safe-area insets, and itsz-indexof 8 keeps it above the floating strip and sheet on a phone held sideways. Both the emergency-stop and the held (Resume) states use this class, so both span the width. The other banner states (bad,warn) keep the centred box. - Test (
src/server.test.ts): a new test reads the served page and checks that.estophas amin-heightof at least 56 px. It also checks that.estop,:hoverand:activeeach have a red background, and that#banner.stopis fixed withleft: 0,right: 0, no transform,width: autoandmax-width: none. It fails against the old page and passes with the change.
The whole bun --cwd Software/so101 test passes (393 tests, 0 failures) and tsc --noEmit is clean. The vendored-library test only fails when node_modules is missing, with or without this change; it passes once bun install has run.
I didn't change the banner's vertical position, so it keeps its existing top (50 px, or 64 px on a phone held sideways).
To try it: open the preview and press STOP; the "STOPPED by …" banner should cross the full width, including over the side sheet on a wide or sideways screen. In a phone-sized responsive view, the STOP button should measure 56 px tall and stay red while held.
🤖 Generated with Claude Code
The STOP button is now at least 56 px tall and stays red while a finger is on it. While the arm is stopped, the banner runs edge to edge across the screen instead of sitting in a centred box. This pull also repairs forge.json, whose check block on main has been invalid since 8190a91.
- STOP button (
Software/so101/src/viewer.html):.estopmin-heightgoes from 52 px to 56 px..estop:activenow has its own red background (#b81d27); before, pressing the button only scaled it. - Stopped banner:
#banner.stopis fixed to the viewport (position: fixed; left: 0; right: 0). The old centring and 640 px cap are removed, the corners are square, and the padding includes the phone's safe-area insets. Itsz-indexof 8 keeps it above the floating strip and sheet on a phone held sideways. The emergency-stop and the held (Resume) states share this class, so both span the width; thebadandwarnbanners keep the centred box. - Test (
src/server.test.ts): a new test reads the served page. It checks that.estopis at least 56 px tall and that its normal,:hoverand:activebackgrounds are all red. It also checks that#banner.stopis fixed, withleft: 0,right: 0, no transform,width: autoandmax-width: none. It fails against the old page and passes with the change. forge.json: 8190a91 added acheckblock on main with onlylimitsand norun, and the forge refuses a check withoutrun.check.runnow installs the dependencies, runs the type check and runs the tests:bun install --cwd Software/so101 --frozen-lockfile && bun run --cwd Software/so101 typecheck && bun --cwd Software/so101 test. Run here, that command exits 0:tscis clean and all 393 tests pass.
The banner's vertical position is unchanged: it keeps its existing top (50 px, or 64 px on a phone held sideways).
To try it, open the preview and press STOP. The "STOPPED by …" banner should cross the full width, including over the side sheet on a wide or sideways screen. In a phone-sized view, STOP should measure 56 px tall and stay red while held.
🤖 Generated with Claude Code
The STOP button is now at least 56 px tall and stays red while a finger is on it. While the arm is stopped, the banner runs edge to edge across the screen instead of sitting in a centred box.
- STOP button (
Software/so101/src/viewer.html):.estopmin-heightgoes from 52 px to 56 px..estop:activegets its own red background (#b81d27); before, pressing the button only scaled it. - Stopped banner:
#banner.stopis fixed to the viewport (position: fixed; left: 0; right: 0), with no centring, no 640 px cap, and square corners. Its padding includes the phone's safe-area insets, and itsz-indexof 8 keeps it above the floating strip and sheet on a phone held sideways. The emergency-stop and held (Resume) banners both use this class, so both span the width. Thebadandwarnbanners keep the centred box. - Test (
src/server.test.ts): a new test reads the served page and checks three things:
- .estop is at least 56 px tall.
- Its normal, :hover and :active backgrounds are all red.
- #banner.stop is fixed, with left: 0, right: 0, no transform, width: auto and max-width: none.
It fails against the old page and passes with the change.
forge.json: no change against main. This branch had added acheck.runto repair the invalidcheckblock from 8190a91. Main fixed that differently in 1142ee6 by removing the block, so the merge keeps main's file.
The whole bun --cwd Software/so101 test passes (393 pass, 0 fail), and tsc --noEmit is clean.
The banner's vertical position is unchanged: it keeps its existing top of 50 px, or 64 px on a phone held sideways.
To try it, open the preview and press STOP. The "STOPPED by …" banner should cross the full width, including over the side sheet on a wide or sideways screen. In a phone-sized view, STOP should measure 56 px tall and stay red while held.
🤖 Generated with Claude Code
Approved. The preview serves min-height: 56px for .estop, no media rule overrides it, and #banner.stop (id+class) out-ranks the base #banner rule, so the full-width fixed banner wins; the 64px landscape top still applies. The test fails on the old page. CSS-only, so the terminal door is unaffected. Next: (1) .estop.on is later overridden by :hover/:active (same specificity, later rule), so a held Stopped button brightens to red when pressed - scope hover/active with :not(.on) or add .estop.on:hover. (2) The banner is fixed over the top of the stage and may cover the strip on a 360px phone; check it in a real sideways viewport and add padding or a measured top if it hides controls.
The STOP button is now at least 56 px tall and stays red while a finger is on it. While the arm is stopped, the banner runs edge to edge across the screen instead of sitting in a centred box.
Software/so101/src/viewer.html):.estopmin-heightgoes from 52 px to 56 px..estop:activegets its own red background (#b81d27), so pressing it keeps it red. Before, the pressed state only scaled the button.#banner.stopis now pinned to the viewport (position: fixed; left: 0; right: 0) with the old centring and 640 px cap removed and square corners. Its padding includes the phone's safe-area insets, and itsz-indexof 8 keeps it above the floating strip and sheet on a phone held sideways. Both the emergency-stop and the held (Resume) states use this class, so both span the width. The other banner states (bad,warn) keep the centred box.src/server.test.ts): a new test reads the served page and checks that.estophas amin-heightof at least 56 px. It also checks that.estop,:hoverand:activeeach have a red background, and that#banner.stopis fixed withleft: 0,right: 0, no transform,width: autoandmax-width: none. It fails against the old page and passes with the change.The whole
bun --cwd Software/so101 testpasses (393 tests, 0 failures) andtsc --noEmitis clean. The vendored-library test only fails whennode_modulesis missing, with or without this change; it passes oncebun installhas run.I didn't change the banner's vertical position, so it keeps its existing
top(50 px, or 64 px on a phone held sideways).To try it: open the preview and press STOP; the "STOPPED by …" banner should cross the full width, including over the side sheet on a wide or sideways screen. In a phone-sized responsive view, the STOP button should measure 56 px tall and stay red while held.
🤖 Generated with Claude Code
Closes #128