Public: anyone can read this; the crew can change it.

Migrated from github.com/Trevato/SO-ARM100

The page's queue, join and chat script lives in src/ui/lobby-panel.js - no behaviour change #132

Parked opened this
Closed without merging

Issue #95 is done on this branch. The queue, join and chat script now lives in src/ui/lobby-panel.js, with no behaviour change. viewer.html loads it instead of carrying it inline.

Notes

stopped parked by the crew deploy 5b5d88d

opened this

Issue #95 is done on this branch. The queue, join and chat script now lives in src/ui/lobby-panel.js, with no behaviour change. viewer.html loads it instead of carrying it inline. The commit is dd221a2, and the branch already matches origin, so there was nothing new to push.

I added src/ui/lobby-panel.test.ts, and src/server.test.ts has a 4-line adjustment. lobby-panel.test.ts and server.test.ts give 52 passes and 1 failure. The failure is "serves the model, its meshes and the vendored libraries, and nothing outside them". It fails the same way on main, so this change didn't cause it. It is probably a limit of this sandbox, but I didn't check.

The type check didn't run: bun x tsc --noEmit stopped with "bun is unable to write files to tempdir" in this sandbox. The forge's check on the push will cover the type check and the full suite.

The earlier parked failure (pull #117) was a preview deploy that failed where it ran, not in this change.

🤖 Generated with Claude Code

Closes #95

3 earlier comments
commented

Issue #95 is done on this branch. The queue, join and chat script now lives in src/ui/lobby-panel.js, with no behaviour change. viewer.html loads it instead of carrying it inline. The commit is dd221a2, and the branch already matches origin, so there was nothing new to push.

I added src/ui/lobby-panel.test.ts, and src/server.test.ts has a 4-line adjustment. lobby-panel.test.ts and server.test.ts give 52 passes and 1 failure. The failure is "serves the model, its meshes and the vendored libraries, and nothing outside them". It fails the same way on main, so this change didn't cause it. It is probably a limit of this sandbox, but I didn't check.

The type check didn't run: bun x tsc --noEmit stopped with "bun is unable to write files to tempdir" in this sandbox. The forge's check on the push will cover the type check and the full suite.

The earlier parked failure (pull #117) was a preview deploy that failed where it ran, not in this change.

🤖 Generated with Claude Code

commented

The check failed because forge.json declared check.limits but no check.run. I added check.run, set to bun --cwd Software/so101 run typecheck && bun --cwd Software/so101 test, so the check now runs the type check and then the tests. I pushed it as 808f2ea.

I haven't run that command here. In this sandbox tsc can't write to its temp directory, and server.test.ts has one failing test ("serves the model, its meshes and the vendored libraries, and nothing outside them"). That test fails the same way on main, so it may fail the new check too. I didn't check why.

The refactor is unchanged: the queue, join and chat script still lives in src/ui/lobby-panel.js, with no behaviour change.

🤖 Generated with Claude Code

commented

This branch's forge.json now has check.run, but the "main: forge.json: check.run is required" failure may not clear. The prefix suggests the check read main's forge.json, which has no check.run. I can't push to main, so that file needs a person to add it. If the check really does read main's file, it will keep failing until then.

I haven't run the type check or the tests here. The check.run line is bun --cwd Software/so101 run typecheck && bun --cwd Software/so101 test.

I merged current main into this branch (5b5d88d) so the change doesn't undo main's newer "health": "/". The refactor is unchanged: the queue, join and chat script still lives in src/ui/lobby-panel.js, with no behaviour change.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs