Public: anyone can read this; the crew can change it.

The signed-out front page shows what the desk does before anyone signs in #18

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The signed-out / now shows an example desk row and three steps under the existing headline and sign-in button. I ran src/server.test.ts (27 pass) and bun run lint:design (passes). I haven't looked at the page on a phone, so "one screen" is untested.

Notes

shipped production is serving it deploy aba151a

opened this

The signed-out / now shows an example desk row and three steps under the existing headline and sign-in button. I ran src/server.test.ts (27 pass) and bun run lint:design (passes). I haven't looked at the page on a phone, so "one screen" is untested.

  • Example row: it uses the real row and clock markup and classes (.lead-row, .clock, chip, badge), with the 0:42 clock in the "ok" tone. It sits under a label reading "Example, not a real lead". It is fixed text in src/pages/desk.ts and never touches the database, so read lead and the contract are unchanged.
  • Static, not a link: the row isn't a link, and the clock has no data-since, so the clock script never ticks it.
  • Steps: three short steps: a lead comes in and the clock starts; you approve the drafted reply in one tap; the app drafts follow-ups for day 1, 3, 7, 14 and 30 until they're qualified or gone.
  • CSS: static/app.css gets a small .example-label and .steps block, using existing tokens only. No new JavaScript.
  • Tests: signed out, / shows the label, the row, 0:42, the three steps and the sign-in link, and has no ticking clock. It also contains none of the names in src/sample.ts, which the test reads from that file. Signed in, the desk has no example block.

I did not use the issue's "Maria G." example. "Maria Gonzalez" is a real sample lead, so I made up "Sample: Dana P." with "Can we see 12 Example St this weekend?" so the example can't be mistaken for live data.

scripts/gate.ts doesn't exist in this repo, so I skipped it. bun x tsc --noEmit only printed the compiler help because the repo has no tsconfig.json, so the type check didn't run.

Closes #15

commented

The signed-out / now shows an example desk row and three steps under the existing headline and sign-in button. I ran src/server.test.ts (27 pass) and bun run lint:design (passes). I haven't looked at the page on a phone, so "one screen" is untested.

  • Example row: it uses the real row and clock markup and classes (.lead-row, .clock, chip, badge), with the 0:42 clock in the "ok" tone. It sits under a label reading "Example, not a real lead". It is fixed text in src/pages/desk.ts and never touches the database, so read lead and the contract are unchanged.
  • Static, not a link: the row isn't a link, and the clock has no data-since, so the clock script never ticks it.
  • Steps: three short steps: a lead comes in and the clock starts; you approve the drafted reply in one tap; the app drafts follow-ups for day 1, 3, 7, 14 and 30 until they're qualified or gone.
  • CSS: static/app.css gets a small .example-label and .steps block, using existing tokens only. No new JavaScript.
  • Tests: signed out, / shows the label, the row, 0:42, the three steps and the sign-in link, and has no ticking clock. It also contains none of the names in src/sample.ts, which the test reads from that file. Signed in, the desk has no example block.

I did not use the issue's "Maria G." example. "Maria Gonzalez" is a real sample lead, so I made up "Sample: Dana P." with "Can we see 12 Example St this weekend?" so the example can't be mistaken for live data.

scripts/gate.ts doesn't exist in this repo, so I skipped it. bun x tsc --noEmit only printed the compiler help because the repo has no tsconfig.json, so the type check didn't run.

Approved

Clean. The signed-out / in the preview shows the example row (fixed text, no data-since, not a link) and the three steps. No database read, no contract change, no new input or output path to escape. The test would fail without the change and checks that no sample lead names leak. Only static markup and CSS were added, using existing tokens, with no new JS or dependencies. Nit, not blocking: aria-label on a plain div has no role, so screen readers may ignore it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs