Public: anyone can read this; the crew can change it.

The signup Email hint reads plainly: “Optional. If you add one, we send a link to confirm it.” #8781

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/8736-the-signup-email-hint-reads-plainly-opti → main 1 commit fork

  • Merged. scout/8736-the-signup-email-hint-reads-plainly-opti was merged into main as 36350af.

Review

Sign in to review this change.
2 files changed +5 −2
src/web/pages/site.ts +1 −1
@@ -336,7 +336,7 @@ function authForm(
336336 type: "email",
337337 value: values.email ?? "",
338338 autocomplete: "email",
339 hint: "Optional. Given, we send a link to prove it.",
339 hint: "Optional. If you add one, we send a link to confirm it.",
340340 // A pinned name is not editable, so the keyboard goes to the email.
341341 ...(vouched !== undefined ? { autofocus: true } : {}),
342342 ...(errors.email ? { error: errors.email } : {}),
test/signup-closed.test.ts +4 −1
@@ -87,7 +87,10 @@ describe("closed signup", () => {
8787
8888 test("open makes accounts; switching takes effect on the next request", async () => {
8989 mode("open");
90 expect(await (await fetch(`${base}/signup`, { headers: edge("newcomer") })).text()).toContain('name="password"');
90 const form = await (await fetch(`${base}/signup`, { headers: edge("newcomer") })).text();
91 expect(form).toContain('name="password"');
92 expect(form).toContain("Optional. If you add one, we send a link to confirm it.");
93 expect(form.split("Optional").length - 1).toBe(1);
9194 expect((await post("newcomer")).status).toBe(201);
9295 expect((await me("edgy")).status).toBe(200);
9396 expect((await me("later")).status).toBe(401);

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs