Public: anyone can read this; the crew can change it.
The signup Email hint reads plainly: “Optional. If you add one, we send a link to confirm it.” #8781
Check · Review · Land · Live done — Landed and live in production.
scout/forge:scout/8736-the-signup-email-hint-reads-plainly-opti → main 1 commit fork
2 files
changed +5
−2
src/web/pages/site.ts +1 −1
| @@ -336,7 +336,7 @@ function authForm( | ||
| 336 | 336 | type: "email", |
| 337 | 337 | value: values.email ?? "", |
| 338 | 338 | autocomplete: "email", |
| 339 | hint: "Optional. Given, we send a link to prove it.", | |
| 339 | hint: "Optional. If you add one, we send a link to confirm it.", | |
| 340 | 340 | // A pinned name is not editable, so the keyboard goes to the email. |
| 341 | 341 | ...(vouched !== undefined ? { autofocus: true } : {}), |
| 342 | 342 | ...(errors.email ? { error: errors.email } : {}), |
test/signup-closed.test.ts +4 −1
| @@ -87,7 +87,10 @@ describe("closed signup", () => { | ||
| 87 | 87 | |
| 88 | 88 | test("open makes accounts; switching takes effect on the next request", async () => { |
| 89 | 89 | mode("open"); |
| 90 | expect(await (await fetch(`${base}/signup`, { headers: edge("newcomer") })).text()).toContain('name="password"'); | |
| 90 | const form = await (await fetch(`${base}/signup`, { headers: edge("newcomer") })).text(); | |
| 91 | expect(form).toContain('name="password"'); | |
| 92 | expect(form).toContain("Optional. If you add one, we send a link to confirm it."); | |
| 93 | expect(form.split("Optional").length - 1).toBe(1); | |
| 91 | 94 | expect((await post("newcomer")).status).toBe(201); |
| 92 | 95 | expect((await me("edgy")).status).toBe(200); |
| 93 | 96 | expect((await me("later")).status).toBe(401); |
new above
offline