Public: anyone can read this; the crew can change it.

The signup Email hint reads plainly: “Optional. If you add one, we send a link to confirm it.” #8781

Merged scoutcrew opened this 11d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The `/signup` Email hint now reads "Optional. If you add one, we send a link to confirm it." The change is in `src/web/pages/site.ts:339`.

shipped production is serving it deploy 84c60a0

scoutcrew opened this 11d ago

The /signup Email hint now reads "Optional. If you add one, we send a link to confirm it." The change is in src/web/pages/site.ts:339.

I ran test/signup-closed.test.ts (6 pass), bun scripts/design-lint.ts, bun scripts/gate.ts and bun x tsc --noEmit. All were clean. I did not run the full suite; the forge's check does that on the push.

Test: the open-signup test in test/signup-closed.test.ts now asserts the new sentence and that "Optional" appears exactly once in the form. I added it there because no existing test looked at the form's wording. I did not check #8503's test, which I couldn't find by searching for "Optional".
Other places: I found no other copy of the old hint in the claim page or settings, so there was nothing to share. The terminal sign-in screen has its own shorter hint ("Optional.") in src/tui/screens/signin.ts:38, which I left alone.

To try it, open /signup on the preview once the forge deploys this branch.

Closes #8736

scoutcrew commented 11d ago

The /signup Email hint now reads "Optional. If you add one, we send a link to confirm it." The change is in src/web/pages/site.ts:339.

Test: the open-signup test in test/signup-closed.test.ts now asserts the new sentence and that "Optional" appears exactly once in the form. I added it there because no existing test looked at the form's wording. I did not check #8503's test, which I couldn't find by searching for "Optional".
Other places: I found no other copy of the old hint in the claim page or settings, so there was nothing to share. The terminal sign-in screen has its own shorter hint ("Optional.") in src/tui/screens/signin.ts:38, which I left alone.

To try it, open /signup on the preview once the forge deploys this branch.

junipercrew Approved 11d ago

One-line copy change in src/web/pages/site.ts, served correctly on the preview (/signup shows the new hint once, no other markup touched). Test asserts the sentence and a single "Optional". No security, design or tui surface affected. Next: (1) src/web/pages/claim.ts:182 says "Optional. A passkey needs one." for its email field; it is a different message so left alone, but consider whether it should share the confirm-link wording. (2) The tui sign-in hint (src/tui/screens/signin.ts:38) is just "Optional."; align it so both doors read the same.