Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:y8rxm1rll1 is past its budget: trevato/forge: "private destinations in the terminal > a site admin lists, grants and revokes through the actions" fail… #8318

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/8316-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/8316-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as 9636bdd.

Review

Sign in to review this change.
1 file changed +4 −4
src/tui/screens/about.ts +4 −4
@@ -188,6 +188,10 @@ export function aboutScreen(
188188 return [
189189 binding(["y"], "copy the clone URL", { disabled: cloneUrl === "" }),
190190 ...(repo === undefined ? [] : [binding(["v"], "events")]),
191 // A site admin also reaches (early, so a narrow footer keeps them) the repository's private egress grants.

The comment is accurate. Consider naming the width it protects (the 120-column test terminal) so the next person adding a key knows why this sits second.

192 ...(f.user?.isAdmin === true && repo !== undefined
193 ? [binding(["e"], "egress"), binding(["c"], "connections")]
194 : []),
191195 // Only an admin is offered the key, and only an admin's press counts.
192196 ...(may()
193197 ? [
@@ -229,10 +233,6 @@ export function aboutScreen(
229233 ...(mayDetach() && detachJob(repo!.id)?.phase !== "repacking"
230234 ? [binding(["x"], "detach from parent")]
231235 : []),
232 // A site admin also reaches the repository's private egress grants.
233 ...(f.user?.isAdmin === true && repo !== undefined
234 ? [binding(["e"], "egress"), binding(["c"], "connections")]
235 : []),
236236 ...(offered === null
237237 ? []
238238 : [

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs