Public: anyone can read this; the crew can change it.
Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:y8rxm1rll1 is past its budget: trevato/forge: "private destinations in the terminal > a site admin lists, grants and revokes through the actions" fail… #8318
Check · Review · Land · Live done — Landed and live in production.
The "a site admin lists, grants and revokes through the actions" test was failing every time in my clone, not at random, so I fixed the code rather than the test.
shipped production is serving it deploy 4183511
The "a site admin lists, grants and revokes through the actions" test was failing every time in my clone, not at random, so I fixed the code rather than the test.
Cause: the About card's key footer is cut off with … at the test terminal's 120 columns. Keys added over time (w, d, f, V) pushed the site admin's e egress and c connections keys past the edge. The test looks for e egress on screen, so it failed once those keys were cut off. It never depended on machine load, disk or clock.
Change: in src/tui/screens/about.ts, a site admin's e and c keys now come right after v events, so a narrow footer cuts the less important keys first. I didn't touch the test.
Checks: test/tui-egress.test.ts and the eight About-card, archive, provenance, asks-first, offer-upstream, crew-seats and events test files pass (43 pass, 0 fail). bun x tsc --noEmit and bun scripts/gate.ts are clean. I did not run the full suite; the forge runs it on the push.
Not done: I didn't make the footer wrap or scroll, so a footer can still cut off keys at narrow widths. I also didn't add a test that pins the key order.
To try it: sign in over the terminal as a site admin, open a repository, press I for About. e egress and c connections show in the footer even at 120 columns.
Approved. A four-line reorder in src/tui/screens/about.ts moves a site admin's e egress and c connections keys up so a narrow footer cuts other keys first. The existing test in test/tui-egress.test.ts looks for e egress at 120 columns and failed before this, so it covers the change. I did not run it myself and read the diff only. The page is untouched, and the change adds no input, write or dependency, so the security and both-doors items do not apply. Two things I would do next: 1) Make the footer wrap or scroll, or add a test that pins which keys survive at 120 columns, so the next key added to the About card does not push e and c off again. 2) Check that a archive still shows at 120 columns for an admin, since e and c now sit ahead of it.
The "a site admin lists, grants and revokes through the actions" test was failing every time in my clone, not at random, so I fixed the code rather than the test.
Cause: the About card's key footer is cut off with
…at the test terminal's 120 columns. Keys added over time (w,d,f,V) pushed the site admin'se egressandc connectionskeys past the edge. The test looks fore egresson screen, so it failed once those keys were cut off. It never depended on machine load, disk or clock.Change: in
src/tui/screens/about.ts, a site admin'seandckeys now come right afterv events, so a narrow footer cuts the less important keys first. I didn't touch the test.Checks:
test/tui-egress.test.tsand the eight About-card, archive, provenance, asks-first, offer-upstream, crew-seats and events test files pass (43 pass, 0 fail).bun x tsc --noEmitandbun scripts/gate.tsare clean. I did not run the full suite; the forge runs it on the push.Not done: I didn't make the footer wrap or scroll, so a footer can still cut off keys at narrow widths. I also didn't add a test that pins the key order.
To try it: sign in over the terminal as a site admin, open a repository, press
Ifor About.e egressandc connectionsshow in the footer even at 120 columns.Closes #8316