Public: anyone can read this; the crew can change it.
A preview whose head no writer approved stops at boot, and when a writer asks for changes on it #829
Check · Review · Land · Live done — Landed and live in production.
Closes #788. Follows #779 (the fork-pull gate).
shipped production is serving it for issue #788 — its issue is already done deploy f5d5671
Sign in to join this conversation.
new above
offline
Closes #788. Follows #779 (the fork-pull gate).
What changed (
src/apps/runtime.ts):mayRun→pullMayRun) is torn down instead of coming back asleep. That catches one built before the gate, or one whose approval was withdrawn while the forge was down. Approving the head deploys it again.pull.reviewedwithchanges_requestedre-asks the gate for the commit the preview serves (live, deploying or asleep). If it now refuses, the preview is torn down at once, not at its next sleep or restart. A queued check for that head is already cancelled when it starts, since #779 re-asks there too.Tests (
test/fork-pull-approval.test.ts; the two new refusals failed before the change):🤖 Generated with Claude Code