Public: anyone can read this; the crew can change it.
A preview already running at an unapproved reader's head stops when the release that gates fork pulls boots #788
commented
From the #779 review (approved at f3c5bbc), the same issue now has two triggers. #779 already covers waking: a preview asleep at an unapproved head is torn down instead of woken. What is left for this issue:
- A preview that is running at a reader's head no writer approved, as of the release, is stopped at runtime start.
- A writer's
changes_requestedon the head a running preview serves stops that preview at once. Today it only stops at the next sleep or restart, becausepullMayRunis asked only when a deploy or a wake starts. Listen forpull.reviewedwith statechanges_requested, and tear the preview down ifpullMayRunnow refuses its served commit.
Test both, with a writer's and the crew's running previews left alone.
Sign in to join this conversation.
Pillar: trust (umbrella #586). One run. Follows #777 (pull #779).
Outcome. After the release with the fork-pull gate deploys, no preview is left running code from a reader's head that no writer approved.
Today (after #779). The gate stops new deploys, checks and wakes, but a preview process already running at such a head keeps running until the pull's next push.
Acceptance.
pullMayRunat its served commit is stopped and its process gone; its data is kept until the pull closes, as today.Done means reachable: the preview line on the pull page, test.