Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:10t8imceac is past its budget: trevato/forge: "notes from the app, in the terminal > the admin lists the banned senders and unbans one; a reader has n… #8138

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

torque/forge:torque/8107-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork

  • Merged. torque/8107-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as 4d857ab.

Review

Sign in to review this change.
1 file changed +4 −4
test/tui-notes.test.ts +4 −4
@@ -84,7 +84,7 @@ describe("notes from the app, in the terminal", () => {
8484 // Filtered, so the row's presence does not depend on how many others the palette lists.
8585 expect(await palette(bob, notes, [":", "Tell the"])).toContain("alice/notes — Tell the builders");
8686 expect(await palette(bob, plain, [":", "Tell the"])).not.toContain("Tell the builders");
87 });
87 }, 30_000);
8888
8989 test("a note files a from-app issue as the person", async () => {
9090 const text = await palette(bob, notes, [":", "Tell the", "\r", ..."the logo is blurry".split(""), "\r"]);
@@ -94,7 +94,7 @@ describe("notes from the app, in the terminal", () => {
9494 const issue = getIssue(app.db, notes.id, row.issue_number)!;
9595 expect(labelsFor(app.db, issue.id).map((l) => l.name)).toEqual(["from-app"]);
9696 expect(issue.body).toContain("by @bob.");
97 });
97 }, 30_000);
9898
9999 test("a person sees their own with its status; the admin sees all and bans", async () => {
100100 expect(await palette(bob, notes, [":", "Notes from", "\r"])).toContain("the logo is blurry");
@@ -107,7 +107,7 @@ describe("notes from the app, in the terminal", () => {
107107 await palette(alice, notes, [":", "Notes from", "\r", "\r", "\x1b[C", "\x1b[C", "\r"]);
108108 const record = getAppBySlug(app.db, "notes")!;
109109 expect(isBanned(app.db, record.id, `u:${bob.id}`)).toBe(true);
110 });
110 }, 30_000);
111111
112112 test("the admin lists the banned senders and unbans one; a reader has no such row", async () => {
113113 const record = getAppBySlug(app.db, "notes")!;
@@ -122,5 +122,5 @@ describe("notes from the app, in the terminal", () => {
122122 const again = await sendNote(app, record, notes, "production", undefined, sender, { text: "back again", page: "", viewport: "unknown" }, "ssh:again");
123123 expect(again.ok).toBe(true);
124124 expect(await palette(alice, notes, [":", "Banned", "\r"])).not.toContain("Unban this sender");
125 });
125 }, 30_000);
126126 });

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs