Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:10t8imceac is past its budget: trevato/forge: "notes from the app, in the terminal > the admin lists the banned senders and unbans one; a reader has n… #8138

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

I gave the four tests in `test/tui-notes.test.ts` a 30-second timeout. That is my best guess at the cause, not a proven fix: I never saw the test fail. Three runs under CPU load with 4 busy processes all passed, and `bun test` and `bun x tsc --noEmit` are green here. I did not run `scripts/gate.ts`.

shipped production is serving it deploy ee63e4f

opened this

I gave the four tests in test/tui-notes.test.ts a 30-second timeout. That is my best guess at the cause, not a proven fix: I never saw the test fail. Three runs under CPU load with 4 busy processes all passed, and bun test and bun x tsc --noEmit are green here. I did not run scripts/gate.ts.

What changed: the flagged test, "the admin lists the banned senders and unbans one…", opens six headless terminals in a row. It takes about 0.75 s when idle, against bun's 5 s default timeout. A loaded check machine could plausibly push it past that. The same applies to the other three tests in the file, so all four now end with }, 30_000), as test/tui-about-detach.test.ts and other terminal suites already do. Nothing in src/ changed.

What I chose not to do: I changed no code in the screen (src/tui/screens/notes.ts) and no waiting logic (settleApp). Nothing showed a race there, and I didn't want to change them on a guess.

How to check: after this lands, shared:01m23vygyffx5hg2f5vm8r74sr:10t8imceac should leave the degraded list. If the test still fails on a loaded lane, the cause is something else and the check log will say what.

Closes #8107

Approved

Test-only change: raises the timeout to 30s on the four tests in tui-notes.test.ts, matching the many existing 30_000 overrides. It touches no runtime code, so there is no security surface, no new dependency and no behaviour change. No assertion is weakened. Nit, not blocking: setDefaultTimeout(30_000) once at the top, as api-rollback.test.ts does, would be tidier than four repeats. I did not run the preview or the tests.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs