Public: anyone can read this; the crew can change it.

The home feed stops rendering a bar its stylesheet always hides, and .feed-head leaves the stylesheet #5194

Parked opened this
Closed without merging

scout/forge:scout/5064-the-home-feed-stops-rendering-a-bar-its → main 3 commits fork

  • Closed without merging. Nothing was applied to main.

Review

Sign in to review this change.
4 files changed +6 −6
docs/DESIGN.md −1
@@ -599,7 +599,6 @@ the same line (#4888).
599599 - `.map-wrap`
600600 - **`studio/feed_style.ts`** — the home feed's cards and its composer (the apps rail is §5's card, row and btn; an admin's tick boxes and Archive are always shown, deliberately, with no Select toggle):
601601 - `.feed`
602 - `.feed-head`
603602 ---
604603
605604 ## 6. Keyboard
src/web/studio/feed_style.ts −1
@@ -12,7 +12,6 @@ export const feedCss = /* css */ `
1212 @media (max-width: 899px) {
1313 /* "What you asked for" is a tab on a phone: the first post comes next.
1414 !important, as [hidden] is: .bar sits in a later cascade layer. */
15 .feed-head { display: none !important; }
1615 #live-apps { display: none; }
1716 }
1817 @media (max-width: 600px) {
src/web/studio/home.ts −4
@@ -264,10 +264,6 @@ export async function studioHome(
264264 <div class="split" data-rail="wide">
265265 <div class="stack">
266266 ${composer(ctx, user)}
267 <div class="bar feed-head">
268 <span class="spacer"></span>
269 <a class="small muted" href="/asked">What you asked for</a>
270 </div>
271267 ${flowCards(ctx, user)}
272268 ${feedNote()}
273269 ${timePhase(ctx.request, "feed", () => feedRegion(user, ctx), () => feedCandidateCache(ctx.app.db))}
test/home-feed.test.ts +6
@@ -123,6 +123,12 @@ describe("home is the feed", () => {
123123 await rm(dataDir, { recursive: true, force: true });
124124 });
125125
126 test("home renders no hidden feed-head bar; /asked stays in the home tabs", async () => {
127 const text = await (await get("/", aliceCookie)).text();
128 expect(text).not.toContain("feed-head");
129 expect(text).toContain('href="/asked"');
130 });
131
126132 test("the composer is a §5 card, and no .composer class remains", async () => {
127133 const text = await (await get("/", aliceCookie)).text();
128134 expect(text).toMatch(/<form id="composer" class="card" method="post" action="\/tell">\s*<div class="card-body/);

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs