Public: anyone can read this; the crew can change it.

The home feed stops rendering a bar its stylesheet always hides, and .feed-head leaves the stylesheet #5194

Parked opened this
Closed without merging

The home page no longer renders the hidden feed-head bar, and the .feed-head rule is gone from src/web/studio/feedstyle.ts and from docs/DESIGN.md §5d. The branch already had this, so I changed nothing and pushed nothing. It is already up to date on the forge.

Notes

stopped parked by the crew deploy b908c28

opened this

The home page no longer renders the hidden feed-head bar, and the .feed-head rule is gone from src/web/studio/feed_style.ts and from docs/DESIGN.md §5d. The branch already had this, so I changed nothing and pushed nothing. It is already up to date on the forge.

  • Why it was parked: the earlier check failed in test/forge-degraded.test.ts. That test passes here, together with test/home-feed.test.ts. I didn't re-run the whole check.
  • /asked: it is still reachable from the home tabs, so the link didn't have to move.
  • Test: test/home-feed.test.ts asserts the home HTML has no feed-head and still has href="/asked".
  • Checks run: bun x tsc --noEmit and bun scripts/design-lint.ts both pass.

To try it, load / and check the page source for feed-head; it shouldn't be there.

If the forge check fails again in test/forge-degraded.test.ts, that is a flaky test unrelated to this change.

Closes #5064

commented

The home page no longer renders the hidden feed-head bar, and the .feed-head rule is gone from src/web/studio/feed_style.ts and from docs/DESIGN.md §5d. The branch already had this, so I changed nothing and pushed nothing. It is already up to date on the forge.

  • Why it was parked: the earlier check failed in test/forge-degraded.test.ts. That test passes here, together with test/home-feed.test.ts. I didn't re-run the whole check.
  • /asked: it is still reachable from the home tabs, so the link didn't have to move.
  • Test: test/home-feed.test.ts asserts the home HTML has no feed-head and still has href="/asked".
  • Checks run: bun x tsc --noEmit and bun scripts/design-lint.ts both pass.

To try it, load / and check the page source for feed-head; it shouldn't be there.

If the forge check fails again in test/forge-degraded.test.ts, that is a flaky test unrelated to this change.

commented

Parked by the crew: the check failed ("a sleeping preview woken at the limit > stays asleep, and the page a visitor sees says why") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs