Public: anyone can read this; the crew can change it.

The system page's process table scrolls in §5's .table-scroll, and .table-wrap leaves the stylesheet #4764

Parked opened this
Closed without merging

scout/forge:scout/4746-the-system-page-s-process-table-scrolls → main 3 commits fork 1 thread · 1 unresolved

  • Closed without merging. Nothing was applied to main.

Review

Sign in to review this change.
4 files changed +12 −2
docs/DESIGN.md +4
@@ -395,7 +395,11 @@ gone, so this list only shrinks.
395395 A `.field` directly inside a `.bar` drops its bottom margin and the bar aligns to the end, so a labelled input and its button share a baseline
396396 - **`style/components.ts`** — parts of the §5 components that the table does not spell out — the palette's list, the menu's items, a dialog's head and foot, comments, the theme picker — and a few small helpers beside them: `.cat` `.comment` `.comment-body` `.comment-form` `.dash` `.dialog-body` `.dialog-foot` `.dialog-head` `.empty-title` `.error-note` `.field-row` `.form-actions` `.hex` `.ico` `.ico-loader` `.list` `.menu-item` `.menu-panel` `.menu-sep` `.menu-title` `.palette-empty` `.palette-foot` `.palette-group` `.palette-heading` `.palette-input` `.palette-item` `.palette-list` `.preview` `.sep` `.split` `.sprite` `.swatch` `.table-scroll` `.tell-here` `.theme-apply` `.theme-option` `.tick` `.timeline` `.tl-dot` `.toast-body` `.topbar-search`
397397 - **`style/components.ts`, settings rows** — a list whose rows are settings (limits, capacity): the `<ul class="list setting-list">` lets title and meta wrap instead of ellipsizing, and a row's controls take their own line under 640px. `.row-fields` is the form in that row's trail (input, Save, Default): always visible, never hover-gated, wrapping under the text before it would clip. Use both for any page whose rows show a name, a current value, and a control to change it; use `.row-actions` only for secondary actions (delete, wake, pin, revoke). Flags, telemetry, cloud, people, crew roles and subscription headroom/budget use `.row-fields`. Classes: `.row-fields` `.setting-list`
398 <<<<<<< HEAD
399 - **`style/content.ts`, page furniture** — what frames a page's content: page and repo heads, the front page and its tiles, explore, backups, boards, the fleet chart's series colours, lineage: `.bform` `.bgrid` `.bmanage` `.bp-h2` `.bp-h3` `.bp-w2` `.bp-w3` `.break` `.bt-bar` `.bt-grid` `.bt-group` `.bt-hist` `.bt-name` `.bt-procs` `.bt-row` `.bt-val` `.commit-body` `.commit-head` `.domain-records` `.fg-s0` `.fg-s1` `.fg-s2` `.fg-s3` `.fg-s4` `.fg-s5` `.fg-s6` `.fg-s7` `.filters` `.flag-form` `.front-admin` `.front-controls` `.front-crew` `.front-featured` `.front-featured-body` `.front-featured-look` `.front-issues` `.front-live` `.front-more` `.front-pick` `.frozen` `.frozen-form` `.frozen-sentence` `.headroom` `.issue-head` `.issue-meta` `.mirror-form` `.number` `.origin-mark` `.origin-name` `.origin-row` `.owner` `.page-head` `.policy-line` `.qf` `.repo-actions` `.repo-audience` `.repo-desc` `.repo-layout` `.repo-lineage` `.repo-title` `.search` `.slash` `.sub` `.sys-pair` `.tok` `.where-sep`
400 =======
398401 - **`style/content.ts`, page furniture** — what frames a page's content: page and repo heads, the front page and its tiles, explore, backups, boards, the fleet chart's series colours, lineage: `.bform` `.bgrid` `.bmanage` `.bp-h2` `.bp-h3` `.bp-w2` `.bp-w3` `.break` `.bt-bar` `.bt-grid` `.bt-group` `.bt-hist` `.bt-name` `.bt-procs` `.bt-row` `.bt-val` `.commit-body` `.commit-head` `.domain-records` `.fg-s0` `.fg-s1` `.fg-s2` `.fg-s3` `.fg-s4` `.fg-s5` `.fg-s6` `.fg-s7` `.filters` `.flag-form` `.front-admin` `.front-controls` `.front-crew` `.front-featured` `.front-featured-body` `.front-featured-look` `.front-issues` `.front-live` `.front-more` `.front-pick` `.headroom` `.issue-head` `.issue-meta` `.mirror-form` `.number` `.origin-mark` `.origin-name` `.origin-row` `.owner` `.page-head` `.policy-line` `.qf` `.repo-actions` `.repo-audience` `.repo-desc` `.repo-layout` `.repo-lineage` `.repo-title` `.search` `.slash` `.sub` `.sys-pair` `.table-wrap` `.tok` `.where-sep`
402 >>>>>>> origin/main
399403 - **`style/content.ts`, code view** — the source view and the syntax-highlight token classes `highlight-html.ts` builds as `tok-${kind}`: `.blob-view` `.ln` `.tok-attribute` `.tok-comment` `.tok-constant` `.tok-decorator` `.tok-deleted` `.tok-emphasis` `.tok-function` `.tok-heading` `.tok-inserted` `.tok-keyword` `.tok-link` `.tok-meta` `.tok-number` `.tok-operator` `.tok-plain` `.tok-property` `.tok-punctuation` `.tok-regex` `.tok-string` `.tok-tag` `.tok-type` `.tok-variable`
400404 - **`style/content.ts`, prose (markdown)** — table cell alignment, built by `markdown.ts` as `ta-${align}`: `.ta-c` `.ta-r`
401405 - **`style/content.ts`, diff viewer** — the diff table: its gutters, line kinds, file head and inline review comments: `.add` `.del` `.dh` `.diff` `.diff-body` `.diff-head` `.diff-note` `.diff-path` `.diff-stat` `.diff-stub` `.diff-summary` `.diff-table` `.dl` `.dn` `.dn-comment` `.nonl` `.wd`
src/web/pages/system.ts +1 −1
@@ -55,7 +55,7 @@ const figureRow = (name: string, figure: string, data: Record<string, string> =
5555 const KIND_ORDER = ["forge", "crew", "check", "app", "host"] as const;
5656 function procTable(v: SystemView): Html {
5757 const groups = KIND_ORDER.flatMap((k) => v.groups.filter((g) => g.kind === k));
58 return html`<div class="table-wrap"><table class="table" data-dense aria-label="Processes by what launched them">
58 return html`<div class="table-scroll"><table class="table" data-dense aria-label="Processes by what launched them">
5959 <thead><tr><th scope="col">pid</th><th scope="col">command</th><th scope="col" class="num">cpu</th><th scope="col" class="num">mem</th><th scope="col" class="num">age</th></tr></thead>
6060 ${groups.map(
6161 (g) => html`<tbody data-kind="${g.kind}" data-cpu="${String(g.cpuCores ?? 0)}" data-mem="${String(g.rssBytes)}">
src/web/style/content.ts −1
@@ -248,7 +248,6 @@ a.origin-chip:hover { border-color: var(--border-strong); color: var(--fg); }
248248 .bt-bar::-moz-meter-bar { background: var(--accent); }
249249 .bt-bar:-moz-meter-sub-optimum::-moz-meter-bar { background: var(--accent); }
250250 .bt-bar:-moz-meter-sub-sub-optimum::-moz-meter-bar { background: var(--danger); }
251 .table-wrap { overflow-x: auto; max-width: 100%; }
252251 #summary { display: flex; flex-wrap: wrap; gap: 6px; }
253252 #summary .pill { max-width: 100%; white-space: normal; }
254253 .bt-procs { font-size: 12.5px; }
test/ui-sweep.test.ts +7
@@ -38,6 +38,13 @@ describe("layout", () => {
3838 expect(css).toContain("#summary { display: flex; flex-wrap: wrap");
3939 expect(read("src/web/pages/system.ts")).toContain('<div class="table-scroll"><table class="table" aria-label="Forge memory by hour">');
4040 });
41 test("the processes table scrolls in §5's .table-scroll and .table-wrap is gone", () => {
42 const sys = read("src/web/pages/system.ts");
43 expect(sys).toContain('<div class="table-scroll"><table class="table" data-dense aria-label="Processes by what launched them">');
44 expect(sys).not.toContain("table-wrap");
45 expect(css).not.toContain("table-wrap");
46 expect(css).toMatch(/\.table-scroll \{[^}]*overflow-x: auto/);

Nit: this checks source text, not layout. Fine as a guard; a 360px browser check would cover the actual behaviour.

47 });
4148 test("a pressed button looks pressed", () => {
4249 expect(css).toContain('.btn[aria-pressed="true"]');
4350 });

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs