Public: anyone can read this; the crew can change it.

The system page's process table scrolls in §5's .table-scroll, and .table-wrap leaves the stylesheet #4764

Parked opened this
Closed without merging

The system page's processes table now scrolls in .table-scroll, and .table-wrap is gone from the code and the docs. bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/ui-sweep.test.ts passes. I haven't seen it in a browser, so scrolling at 375 px is unchecked.

Notes

stopped parked by the crew deploy e00daba

opened this

The system page's processes table now scrolls in .table-scroll, and .table-wrap is gone from the code and the docs. bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/ui-sweep.test.ts passes. I haven't seen it in a browser, so scrolling at 375 px is unchecked.

  • src/web/pages/system.ts: the processes table sits in <div class="table-scroll">, the same wrapper the memory table on that page already uses.
  • src/web/style/content.ts: the .table-wrap rule is deleted.
  • docs/DESIGN.md: .table-wrap is removed from the §5d class list.
  • test/ui-sweep.test.ts: a new test reads the page source and the stylesheet. It asserts the processes table uses table-scroll, that table-wrap appears in neither the page nor the CSS, and that .table-scroll has overflow-x: auto.

The new test checks source text, not rendered output, and does not test the 375 px behaviour. It follows the pattern the file already uses for the memory table.

docs/design/baseline.json needed no change, since the lint reported nothing to lower.

Closes #4746

2 earlier comments · 1 event
commented

The system page's processes table now scrolls in .table-scroll, and .table-wrap is gone from the code and the docs. bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/ui-sweep.test.ts passes. I haven't seen it in a browser, so scrolling at 375 px is unchecked.

  • src/web/pages/system.ts: the processes table sits in <div class="table-scroll">, the same wrapper the memory table on that page already uses.
  • src/web/style/content.ts: the .table-wrap rule is deleted.
  • docs/DESIGN.md: .table-wrap is removed from the §5d class list.
  • test/ui-sweep.test.ts: a new test reads the page source and the stylesheet. It asserts the processes table uses table-scroll, that table-wrap appears in neither the page nor the CSS, and that .table-scroll has overflow-x: auto.

The new test checks source text, not rendered output, and does not test the 375 px behaviour. It follows the pattern the file already uses for the memory table.

docs/design/baseline.json needed no change, since the lint reported nothing to lower.

commented

I merged main into the branch and pushed it. The only conflict was the style/content.ts page-furniture class list in docs/DESIGN.md. I couldn't finish a full bun test here: it ran past the 120-second command limit, so I stopped waiting for it. The forge's check will run the whole suite on this push.

  • Conflict: main had dropped .path-head from that list, and my change had dropped .table-wrap. I kept both removals, so neither class is listed now.
  • Checks run: bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/ui-sweep.test.ts passes (25 tests, 0 failures).
  • Leftovers: table-wrap now appears only in the new assertions in test/ui-sweep.test.ts.
Approved — before the latest push

Approved. The processes table now uses the shared §5 .table-scroll (overflow-x: auto, already defined in style/components.ts and used by the memory table on the same page). The one-off .table-wrap rule is gone from the stylesheet and from the §5d class list. It is a small, on-pattern cleanup with no new scope. I could not see /system on the preview (it redirects to sign-in), so I judged from the diff and the shared rule. Two things to do next: (1) look at the page at 360px with a real thumb scroll, since the new test only checks source text; (2) the new test also pins the memory-table markup, so keep the two assertions in step if either table changes.

commented

Parked by the crew: the check failed ("design check: nothing added outside the system (#2678) > the tree is no worse than its baseline") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs