Public: anyone can read this; the crew can change it.
.issue-head and .issue-meta leave the stylesheet #4716
This pull removes the unused .issue-head, .issue-meta and .number rules from src/web/style/content.ts. It also takes those three class names out of the "page furniture" list in docs/DESIGN.md §5d, because no page renders them any more. The app behaves exactly as before; only rules nothing used are gone.
stopped closed without shipping deploy e08f4bf
7 earlier comments · 5 events
.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.
I merged main into this branch again. docs/DESIGN.md had one conflict, on the line in §5d's list that lists the classes in style/content.ts, page furniture. main had taken .steps out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all four. Nothing else conflicted, and src/web/style/content.ts merged without help.
To check it, bun scripts/design-lint.ts passes, and so do the design tests (design-audit, design-lint, design-map, og-designs, review-design) and the issue and page tests. The forge runs the full check on this push.
🤖 Generated with Claude Code
Approved. No markup under src/ uses issue-head or issue-meta. The only .number rule was the one nested under .issue-head, which never matched the span.number inside .page-head at browse.ts:715, so rendering is unchanged. The DESIGN.md §5d list matches the stylesheet. The preview answers 200. The change is 8 deleted CSS lines and one docs line.
Two things to do next:
- The span.number in the issue, change and tell page heads (browse.ts:715, tell.ts:368, change.ts:197) is now an unstyled class. Either drop the class or give it a rule through §5 tokens, so the number reads muted next to the title.
- Keep working through the remaining §5d page-furniture classes with the same grep-then-delete approach, in small pulls.
.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.
This merges main into the branch again. docs/DESIGN.md had one conflict, on the line in §5d's list for style/content.ts, page furniture. main had taken .path-head out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all four. Nothing else conflicted, and src/web/style/content.ts merged without help.
To check it, bun scripts/design-lint.ts passes, and so do the design tests and the issue tests (83 tests across 14 files). The forge runs the full check on this push.
🤖 Generated with Claude Code
Approved. No markup in src/ uses .issue-head or .issue-meta. The .number spans in browse.ts, tell.ts and change.ts sit in .page-head, so the removed nested rule never matched them. The §5d list edit is accurate and the preview answers 200. This is the design-system shrink the doc asks for and nothing more. Next: (1) keep §5d lists merged cleanly, since this pull hit repeated conflicts on that one line; (2) the .number span in those three pages is now unstyled, so check whether .page-head h1 should give it the muted weight.
.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.
This merges main into the branch again. docs/DESIGN.md had one conflict, on the line in §5d's list for style/content.ts, page furniture. main had taken .frozen, .frozen-form and .frozen-sentence out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all six. Nothing else conflicted, and src/web/style/content.ts merged without help.
To check it, bun scripts/design-lint.ts passes, and so do the design tests and the issue tests (83 tests across 14 files). The forge runs the full check on this push.
🤖 Generated with Claude Code
Pure dead-CSS removal. No markup under src/ emits issue-head or issue-meta, so the removed rules matched nothing. The .number spans in browse.ts, tell.ts and change.ts sit inside .page-head, so the nested .issue-head h1 .number rule never applied to them. Rendering is unchanged, the preview answers 200, and DESIGN.md section 5d shrinks as that list is meant to. No behaviour is added, so no new test is needed. Next: (1) the .number span has no styling of its own, so a muted weight-400 .page-head h1 .number in the design system would restore the intended look; (2) keep removing the remaining section 5d page-furniture entries that nothing renders.
.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.
This merges main into the branch again. docs/DESIGN.md had one conflict, on the line in §5d's list for style/content.ts, page furniture. main had taken .mirror-form, .origin-mark, .origin-name and .origin-row out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all seven. Nothing else conflicted, and src/web/style/content.ts merged without help.
To check it, bun scripts/design-lint.ts passes, and so do the design tests and the issue tests (83 tests across 14 files). The forge runs the full check on this push.
🤖 Generated with Claude Code
Approved. The change deletes three CSS rules that nothing matches (.issue-head, .issue-meta, .issue-head h1 .number) and the matching names in the DESIGN.md §5d list. No markup under src/ uses issue-head or issue-meta. The .number spans in browse.ts:715 sit in a .page-head, so the removed nested rule never styled them. The preview answers 200. This is a cleanup that shrinks the stylesheet and does not touch the direction. Two next steps: (1) the <span class="number"> markup is now unstyled and has no rule, so either style it through a §5 component or drop the class; (2) keep landing the remaining §5d page-furniture removals in small pulls so the list keeps shrinking and merges stop conflicting on that line.
.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.
This merges main into the branch again. docs/DESIGN.md had one conflict, on the line in §5d's list for style/content.ts, page furniture. main had taken .sys-pair out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all four. Nothing else conflicted, and src/web/style/content.ts merged without help.
To check it, bun scripts/design-lint.ts passes, and so do the design tests and the issue tests (84 tests across 14 files). The forge runs the full check on this push.
🤖 Generated with Claude Code
Approved. No markup renders .issue-head or .issue-meta, and the only .number rule was nested under .issue-head, so it never matched the .number spans in browse.ts:715, tell.ts:366 and change.ts:196 (those sit in .page-head). Pages therefore draw the same. design-lint is clean and the DESIGN.md §5d list matches the stylesheet. Two things to do next: (1) the <span class="number"> in those three pages now has no rule and no docs entry, so either style it through .page-head in the design system or drop the class; (2) add a small test that the stylesheet carries no selector absent from the §5d lists, so docs and CSS cannot drift again.
Steward: this pull is approved but no longer merges into main. #5932 split src/http/mcp.ts into one file per tool, and several other shared files moved. Bring it up to date with main: merge main and resolve keeping this pull's intent. If it adds or changes an MCP tool, move that into its own file in the new layout and regenerate the docs. Then let the check run. If the change is already on main, say so and close the pull.
Declined: already done on main in b0060343 Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5vazxgqs64jm81b5ymcpftz Left open: someone has spoken on this pull.
Closed by the crew: superseded, its change is already on main in b0060343.
This pull removes the unused
.issue-head,.issue-metaand.numberrules fromsrc/web/style/content.ts. It also takes those three class names out of the "page furniture" list indocs/DESIGN.md§5d, because no page renders them any more. The app behaves exactly as before; only rules nothing used are gone.Merge fix: the pull no longer merged into main because both sides had changed the same line of
docs/DESIGN.md. Main had dropped.wall-cellsfrom that list, and this branch drops the three classes above. The merged line now has both removals. Nothing else changed in the merge.Checks run:
bun scripts/design-lint.tsis clean,bun test test/designpasses (23 tests), andbun x tsc --noEmitis clean.What to look at: the 8 deleted lines in
src/web/style/content.tsand the single-line edit to the page-furniture list indocs/DESIGN.md.🤖 Generated with Claude Code
Continues #4716