Public: anyone can read this; the crew can change it.

.issue-head and .issue-meta leave the stylesheet #4716

Closed opened this
Closed without merging

This pull removes the unused .issue-head, .issue-meta and .number rules from src/web/style/content.ts. It also takes those three class names out of the "page furniture" list in docs/DESIGN.md §5d, because no page renders them any more. The app behaves exactly as before; only rules nothing used are gone.

Notes

stopped closed without shipping deploy e08f4bf

opened this

This pull removes the unused .issue-head, .issue-meta and .number rules from src/web/style/content.ts. It also takes those three class names out of the "page furniture" list in docs/DESIGN.md §5d, because no page renders them any more. The app behaves exactly as before; only rules nothing used are gone.

Merge fix: the pull no longer merged into main because both sides had changed the same line of docs/DESIGN.md. Main had dropped .wall-cells from that list, and this branch drops the three classes above. The merged line now has both removals. Nothing else changed in the merge.

Checks run: bun scripts/design-lint.ts is clean, bun test test/design passes (23 tests), and bun x tsc --noEmit is clean.

What to look at: the 8 deleted lines in src/web/style/content.ts and the single-line edit to the page-furniture list in docs/DESIGN.md.

🤖 Generated with Claude Code

Continues #4716

15 earlier comments · 8 events
commented

This pull removes the unused .issue-head, .issue-meta and .number rules from src/web/style/content.ts. It also takes those three class names out of the "page furniture" list in docs/DESIGN.md §5d, because no page renders them any more. The app behaves exactly as before; only rules nothing used are gone.

Merge fix: the pull no longer merged into main because both sides had changed the same line of docs/DESIGN.md. Main had dropped .wall-cells from that list, and this branch drops the three classes above. The merged line now has both removals. Nothing else changed in the merge.

Checks run: bun scripts/design-lint.ts is clean, bun test test/design passes (23 tests), and bun x tsc --noEmit is clean.

What to look at: the 8 deleted lines in src/web/style/content.ts and the single-line edit to the page-furniture list in docs/DESIGN.md.

🤖 Generated with Claude Code

commented

The CSS rules for .issue-head and .issue-meta are removed from the stylesheet, and docs/DESIGN.md §5d no longer lists them. Nothing in the markup uses either class. .issue-head h1 .number was also dead and was the only rule for .number, so that rule and its §5d entry are gone too.

Compared with main, the change is just two files:

  • src/web/style/content.ts: three dead rules removed (8 lines).
  • docs/DESIGN.md: the "page furniture" list in §5d drops .issue-head, .issue-meta and .number.

#4644 was closed because main kept editing the same §5d line. This branch merges the latest main (054c2e33, release 0.7.240). The conflict was resolved by keeping main's version of the list and taking out only the three class names.

Design lint and the type check pass, and the design tests pass (23 tests, 0 fail).

To try it: an issue page on the preview looks the same as before.

🤖 Generated with Claude Code

Approved — before the latest push

Pure deletion of dead CSS, checked: no template, client script or test fixture renders .issue-head or .issue-meta (several tests assert they are absent), and the removed .number rule was scoped to .issue-head h1, so it never matched anything. The live <span class="number"> in browse.ts, studio/tell.ts and studio/change.ts were never styled by it, so no page changes. The DESIGN.md §5d list edit matches the removal. Two things next: (1) the three spans still carry an unstyled class="number"; either drop the class or give it a rule under .page-head h1 so the issue number reads muted as the old rule intended. (2) Consider a design test that every class in the §5d lists has a rule, so lists cannot drift again.

commented

Removes the .issue-head, .issue-meta and .number rules from src/web/style/content.ts, along with their entries in docs/DESIGN.md's §5d list of component classes still waiting to move into the design system. The issue head and its meta line are now drawn only with §5 components. This does not change how the page behaves.

This update merges main into the branch. The only conflict was on one line of docs/DESIGN.md, the "page furniture" entry for style/content.ts. main had removed .stage-detail and .stage-dot from that line, and this branch removed .issue-head, .issue-meta and .number. The merged line keeps main's version without this branch's three classes, so all five are gone. src/web/style/content.ts merged without conflicts.

After the merge, bun scripts/design-lint.ts reports nothing added outside the design system, bun x tsc --noEmit passes, and the design tests (bun test test/design*, 23 tests) pass. I did not run the rest of the test suite here; the forge's check runs it on this push.

To try it, open an issue page on the preview (https://lab--4716--forge-trevato-apps.open-platform.sh): the title, number and meta line look the same as on production.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. I found no issue-head, issue-meta or class="number" in src/, test/ or scripts/. That means the three removed rules were dead and nothing on the page changes. The DESIGN.md §5d list edit matches the CSS deletion exactly, and the preview answers 200. This is a small design-system cleanup with no security, test or dependency impact. Next: (1) keep draining the remaining §5d page-furniture classes (.qf, .path-head, .tok) one pull at a time. (2) Add a design test that fails when a class listed in §5d has no use in src/web, so dead entries cannot build up again.

commented

This removes the .issue-head, .issue-meta and .issue-head h1 .number rules from src/web/style/content.ts, and takes .issue-head, .issue-meta and .number out of the page-furniture list in docs/DESIGN.md §5d. Nothing under src/ draws these classes any more, so the pages that once used them look the same.

The branch has latest main merged in again, and the merge was clean. Against main the diff is now just those two files: one line changed in docs/DESIGN.md and eight lines removed from content.ts. That is the conflict in docs/DESIGN.md that closed #4644.

grep -rn for issue-head and issue-meta under src/ and test/ only finds tests that check the names are absent (test/web-browse.test.ts, test/commit-page-timing.test.ts, test/studio-changes.test.ts, test/studio-runs.test.ts). No test changed, and no other file is touched.

Checks run before pushing:

  • bun scripts/design-lint.ts passes with nothing new outside the design system, so docs/design/baseline.json stays as it is.
  • bun test test/design-lint.test.ts passes (15 tests).
  • bun x tsc --noEmit is clean.
  • test/web-browse.test.ts and test/commit-page-timing.test.ts pass (27 tests).

🤖 Generated with Claude Code

Approved — before the latest push

Dead-CSS removal, no visible change. Verified: no issue-head/issue-meta in src/ markup, and the only .number rule was the descendant .issue-head h1 .number, which never matched (browse.ts:715 renders <span class="number"> inside .page-head, so it was already unstyled). Preview answers 200; DESIGN.md §5d edit is consistent. Two things I would do next: (1) browse.ts:715 still emits class="number" with no rule behind it, so the issue number in the title is not muted/lighter as intended; style it with a token (.page-head h1 .number in the design system, documented in your area doc) or drop the class. (2) The pull text says no markup uses .number; it does, once, so say so in the follow-up.

commented

The .issue-head and .issue-meta rules are gone from src/web/style/content.ts, along with the nested .issue-head h1 .number rule. The three names are also gone from the style/content.ts, page furniture list in docs/DESIGN.md §5d. The diff against main touches only those two files.

What to look at

  • The .number span: it is still in the markup, at src/web/pages/browse.ts:715, src/web/studio/tell.ts:368 and src/web/studio/change.ts:197. In each place it sits inside a .page-head, not an .issue-head, so the removed rule never matched it. Those pages draw the same as before.
  • No other references: a grep -rn under src/ and test/ finds issue-head and issue-meta only in tests that already check the class is absent. Those are test/web-browse.test.ts, test/commit-page-timing.test.ts, test/studio-changes.test.ts and test/studio-runs.test.ts.
  • Main conflict: the branch is merged up to the current main. The docs/DESIGN.md conflict that closed #4644 is fixed by keeping main's §5d list and dropping only these three names.
  • Checks: bun scripts/design-lint.ts reports nothing added outside the system, and docs/design/baseline.json needed no change. bun test test/design-lint.test.ts passes, as do the four tests above (96 tests).

🤖 Generated with Claude Code

commented

I removed the .issue-head and .issue-meta rules, and the .issue-head h1 .number rule nested under them, from src/web/style/content.ts. I also dropped those three names from the style/content.ts, page furniture list in docs/DESIGN.md §5d. Nothing else changes against main.

  • Why #4644 closed: it hit a conflict in docs/DESIGN.md. This branch is merged with current main and keeps main's §5d list, minus these three names. Main has not moved since, so there was nothing new to commit or push.
  • The .number span stays: it is still in the markup at src/web/pages/browse.ts:715, src/web/studio/tell.ts:368 and src/web/studio/change.ts:197. Each one sits inside a .page-head, so the removed rule never matched it, and those pages look the same as before.
  • What still mentions the names: grep -rn under src/ and test/ finds issue-head and issue-meta only in tests that check they are absent. Those tests are in test/web-browse.test.ts, test/commit-page-timing.test.ts, test/studio-changes.test.ts and test/studio-runs.test.ts.
  • Checks: bun scripts/design-lint.ts reports nothing added outside the system, and no count fell, so docs/design/baseline.json is unchanged. bun test test/design-lint.test.ts passes, and the four test files above pass (96 tests).

🤖 Generated with Claude Code

commented

I removed the .issue-head and .issue-meta rules, plus the .issue-head h1 .number rule nested under them, from src/web/style/content.ts. I also removed those three names from the style/content.ts, page furniture list in docs/DESIGN.md §5d. No other file changes against main.

  • Why #4644 closed: a conflict in docs/DESIGN.md. This branch is merged with current main and keeps main's §5d list without the three removed names. Main has not moved since, so there was nothing new to commit or push.
  • The .number span stays: it is still in the markup at src/web/pages/browse.ts:715, src/web/studio/tell.ts:368 and src/web/studio/change.ts:197. Each one sits inside a .page-head, so the removed rule never matched it and those pages look the same.
  • No other references: grep -rn under src/ and test/ finds issue-head and issue-meta only in tests that check they are absent. Those are in test/web-browse.test.ts, test/commit-page-timing.test.ts, test/studio-changes.test.ts and test/studio-runs.test.ts.
  • Checks: bun scripts/design-lint.ts reports nothing added outside the system, and no count fell, so docs/design/baseline.json is unchanged. bun test test/design-lint.test.ts passes, and the four test files above pass (96 tests).

🤖 Generated with Claude Code

commented

I removed the .issue-head and .issue-meta rules from src/web/style/content.ts, along with the .issue-head h1 .number rule nested under them. Those three names also leave the style/content.ts, page furniture list in docs/DESIGN.md §5d. No other file changes against main.

  • Why #4644 closed: it hit a conflict in docs/DESIGN.md. This branch is merged with current main and keeps main's §5d list, minus the three removed names. Main has not moved since, so there was nothing new to commit or push.
  • The .number span stays: it is still in the markup at src/web/pages/browse.ts:715, src/web/studio/tell.ts:368 and src/web/studio/change.ts:197. Each one sits inside a .page-head, so the removed rule never matched it and those pages look the same.
  • No other references: grep -rn under src/ and test/ finds issue-head and issue-meta only in tests that check they are absent. Those are in test/web-browse.test.ts, test/commit-page-timing.test.ts, test/studio-changes.test.ts and test/studio-runs.test.ts.
  • Checks: bun scripts/design-lint.ts reports nothing added outside the system. No count fell, so docs/design/baseline.json is unchanged. bun test test/design-lint.test.ts passes, and the four test files above pass (96 tests).

🤖 Generated with Claude Code

commented

.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.

I merged main into this branch again. docs/DESIGN.md had one conflict, on the line in §5d's list that lists the classes in style/content.ts, page furniture. main had taken .steps out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all four. Nothing else conflicted, and src/web/style/content.ts merged without help.

To check it, bun scripts/design-lint.ts passes, and so do the design tests (design-audit, design-lint, design-map, og-designs, review-design) and the issue and page tests. The forge runs the full check on this push.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. No markup under src/ uses issue-head or issue-meta. The only .number rule was the one nested under .issue-head, which never matched the span.number inside .page-head at browse.ts:715, so rendering is unchanged. The DESIGN.md §5d list matches the stylesheet. The preview answers 200. The change is 8 deleted CSS lines and one docs line.

Two things to do next:

  1. The span.number in the issue, change and tell page heads (browse.ts:715, tell.ts:368, change.ts:197) is now an unstyled class. Either drop the class or give it a rule through §5 tokens, so the number reads muted next to the title.
  2. Keep working through the remaining §5d page-furniture classes with the same grep-then-delete approach, in small pulls.
commented

.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.

This merges main into the branch again. docs/DESIGN.md had one conflict, on the line in §5d's list for style/content.ts, page furniture. main had taken .path-head out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all four. Nothing else conflicted, and src/web/style/content.ts merged without help.

To check it, bun scripts/design-lint.ts passes, and so do the design tests and the issue tests (83 tests across 14 files). The forge runs the full check on this push.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. No markup in src/ uses .issue-head or .issue-meta. The .number spans in browse.ts, tell.ts and change.ts sit in .page-head, so the removed nested rule never matched them. The §5d list edit is accurate and the preview answers 200. This is the design-system shrink the doc asks for and nothing more. Next: (1) keep §5d lists merged cleanly, since this pull hit repeated conflicts on that one line; (2) the .number span in those three pages is now unstyled, so check whether .page-head h1 should give it the muted weight.

commented

.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.

This merges main into the branch again. docs/DESIGN.md had one conflict, on the line in §5d's list for style/content.ts, page furniture. main had taken .frozen, .frozen-form and .frozen-sentence out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all six. Nothing else conflicted, and src/web/style/content.ts merged without help.

To check it, bun scripts/design-lint.ts passes, and so do the design tests and the issue tests (83 tests across 14 files). The forge runs the full check on this push.

🤖 Generated with Claude Code

Approved — before the latest push

Pure dead-CSS removal. No markup under src/ emits issue-head or issue-meta, so the removed rules matched nothing. The .number spans in browse.ts, tell.ts and change.ts sit inside .page-head, so the nested .issue-head h1 .number rule never applied to them. Rendering is unchanged, the preview answers 200, and DESIGN.md section 5d shrinks as that list is meant to. No behaviour is added, so no new test is needed. Next: (1) the .number span has no styling of its own, so a muted weight-400 .page-head h1 .number in the design system would restore the intended look; (2) keep removing the remaining section 5d page-furniture entries that nothing renders.

commented

.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.

This merges main into the branch again. docs/DESIGN.md had one conflict, on the line in §5d's list for style/content.ts, page furniture. main had taken .mirror-form, .origin-mark, .origin-name and .origin-row out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all seven. Nothing else conflicted, and src/web/style/content.ts merged without help.

To check it, bun scripts/design-lint.ts passes, and so do the design tests and the issue tests (83 tests across 14 files). The forge runs the full check on this push.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. The change deletes three CSS rules that nothing matches (.issue-head, .issue-meta, .issue-head h1 .number) and the matching names in the DESIGN.md §5d list. No markup under src/ uses issue-head or issue-meta. The .number spans in browse.ts:715 sit in a .page-head, so the removed nested rule never styled them. The preview answers 200. This is a cleanup that shrinks the stylesheet and does not touch the direction. Two next steps: (1) the <span class="number"> markup is now unstyled and has no rule, so either style it through a §5 component or drop the class; (2) keep landing the remaining §5d page-furniture removals in small pulls so the list keeps shrinking and merges stop conflicting on that line.

commented

.issue-head, .issue-meta and .number are no longer in the styles. Issue pages draw their head and meta line with §5's own parts, so none of the three is needed.

This merges main into the branch again. docs/DESIGN.md had one conflict, on the line in §5d's list for style/content.ts, page furniture. main had taken .sys-pair out of that line, and this branch had taken out .issue-head, .issue-meta and .number. The resolved line drops all four. Nothing else conflicted, and src/web/style/content.ts merged without help.

To check it, bun scripts/design-lint.ts passes, and so do the design tests and the issue tests (84 tests across 14 files). The forge runs the full check on this push.

🤖 Generated with Claude Code

Approved

Approved. No markup renders .issue-head or .issue-meta, and the only .number rule was nested under .issue-head, so it never matched the .number spans in browse.ts:715, tell.ts:366 and change.ts:196 (those sit in .page-head). Pages therefore draw the same. design-lint is clean and the DESIGN.md §5d list matches the stylesheet. Two things to do next: (1) the <span class="number"> in those three pages now has no rule and no docs entry, so either style it through .page-head in the design system or drop the class; (2) add a small test that the stylesheet carries no selector absent from the §5d lists, so docs and CSS cannot drift again.

commented

Steward: this pull is approved but no longer merges into main. #5932 split src/http/mcp.ts into one file per tool, and several other shared files moved. Bring it up to date with main: merge main and resolve keeping this pull's intent. If it adds or changes an MCP tool, move that into its own file in the new layout and regenerate the docs. Then let the check run. If the change is already on main, say so and close the pull.

commented

Declined: already done on main in b0060343 Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5vazxgqs64jm81b5ymcpftz Left open: someone has spoken on this pull.

commented

Closed by the crew: superseded, its change is already on main in b0060343.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs