Public: anyone can read this; the crew can change it.

.filters leaves the stylesheet and docs/DESIGN.md §5d #4653

Parked opened this
Closed without merging

mason/forge:mason/4300-filters-leaves-the-stylesheet-and-docs-d → main 5 commits fork

  • Closed without merging. Nothing was applied to main.

Review

Sign in to review this change.
5 files changed +14 −13
docs/DESIGN.md +4
@@ -395,7 +395,11 @@ gone, so this list only shrinks.
395395 A `.field` directly inside a `.bar` drops its bottom margin and the bar aligns to the end, so a labelled input and its button share a baseline
396396 - **`style/components.ts`** — parts of the §5 components that the table does not spell out — the palette's list, the menu's items, a dialog's head and foot, comments, the theme picker — and a few small helpers beside them: `.cat` `.clone` `.clone-text` `.comment` `.comment-body` `.comment-form` `.dash` `.dialog-body` `.dialog-foot` `.dialog-head` `.empty-title` `.error-note` `.field-row` `.form-actions` `.hex` `.ico` `.ico-loader` `.list` `.menu-item` `.menu-panel` `.menu-sep` `.menu-title` `.palette-empty` `.palette-foot` `.palette-group` `.palette-heading` `.palette-input` `.palette-item` `.palette-list` `.passkey` `.passkey-off` `.passkey-on` `.preview` `.sep` `.split` `.sprite` `.swatch` `.table-scroll` `.tell-here` `.theme-apply` `.theme-option` `.tick` `.timeline` `.tl-dot` `.toast-body` `.topbar-search`
397397 - **`style/components.ts`, settings rows** — a list whose rows are settings (limits, capacity): the `<ul class="list setting-list">` lets title and meta wrap instead of ellipsizing, and a row's controls take their own line under 640px. `.row-fields` is the form in that row's trail (input, Save, Default): always visible, never hover-gated, wrapping under the text before it would clip. Use both for any page whose rows show a name, a current value, and a control to change it; use `.row-actions` only for secondary actions (delete, wake, pin, revoke). Flags, telemetry, cloud, people, crew roles and subscription headroom/budget use `.row-fields`. Classes: `.row-fields` `.setting-list`
398 <<<<<<< HEAD
399 - **`style/content.ts`, page furniture** — what frames a page's content: page and repo heads, the merge box, the front page and its tiles, explore, backups, boards, the fleet chart's series colours, lineage: `.backups-drill` `.backups-error` `.backups-now` `.backups-restore` `.bform` `.bgrid` `.bmanage` `.bp-h2` `.bp-h3` `.bp-w2` `.bp-w3` `.break` `.bt-bar` `.bt-grid` `.bt-group` `.bt-hist` `.bt-name` `.bt-procs` `.bt-row` `.bt-val` `.commit-body` `.commit-head` `.domain-records` `.fg-s0` `.fg-s1` `.fg-s2` `.fg-s3` `.fg-s4` `.fg-s5` `.fg-s6` `.fg-s7` `.flag-form` `.front-admin` `.front-controls` `.front-crew` `.front-featured` `.front-featured-body` `.front-featured-look` `.front-issues` `.front-live` `.front-more` `.front-pick` `.frozen` `.frozen-form` `.frozen-sentence` `.headroom` `.issue-head` `.issue-meta` `.merge-box` `.merge-form` `.merge-headline` `.merge-sub` `.mirror-form` `.number` `.origin-mark` `.origin-name` `.origin-row` `.owner` `.page-head` `.path-head` `.policy-line` `.qf` `.repo-actions` `.repo-audience` `.repo-desc` `.repo-layout` `.repo-lineage` `.repo-title` `.search` `.slash` `.stage-detail` `.stage-dot` `.steps` `.sub` `.sys-pair` `.table-wrap` `.tok` `.wall-cells` `.where-sep`
400 =======
398401 - **`style/content.ts`, page furniture** — what frames a page's content: page and repo heads, the merge box, the front page and its tiles, explore, backups, boards, the fleet chart's series colours, lineage: `.bform` `.bgrid` `.bmanage` `.bp-h2` `.bp-h3` `.bp-w2` `.bp-w3` `.break` `.bt-bar` `.bt-grid` `.bt-group` `.bt-hist` `.bt-name` `.bt-procs` `.bt-row` `.bt-val` `.commit-body` `.commit-head` `.domain-records` `.fg-s0` `.fg-s1` `.fg-s2` `.fg-s3` `.fg-s4` `.fg-s5` `.fg-s6` `.fg-s7` `.filters` `.flag-form` `.front-admin` `.front-controls` `.front-crew` `.front-featured` `.front-featured-body` `.front-featured-look` `.front-issues` `.front-live` `.front-more` `.front-pick` `.frozen` `.frozen-form` `.frozen-sentence` `.headroom` `.issue-head` `.issue-meta` `.merge-box` `.merge-form` `.merge-headline` `.merge-sub` `.mirror-form` `.number` `.origin-mark` `.origin-name` `.origin-row` `.owner` `.page-head` `.path-head` `.policy-line` `.qf` `.repo-actions` `.repo-audience` `.repo-desc` `.repo-layout` `.repo-lineage` `.repo-title` `.search` `.slash` `.stage-detail` `.stage-dot` `.steps` `.sub` `.sys-pair` `.table-wrap` `.tok` `.wall-cells` `.where-sep`
402 >>>>>>> origin/main
399403 - **`style/content.ts`, code view** — the source view and the syntax-highlight token classes `highlight-html.ts` builds as `tok-${kind}`: `.blob-view` `.ln` `.tok-attribute` `.tok-comment` `.tok-constant` `.tok-decorator` `.tok-deleted` `.tok-emphasis` `.tok-function` `.tok-heading` `.tok-inserted` `.tok-keyword` `.tok-link` `.tok-meta` `.tok-number` `.tok-operator` `.tok-plain` `.tok-property` `.tok-punctuation` `.tok-regex` `.tok-string` `.tok-tag` `.tok-type` `.tok-variable`
400404 - **`style/content.ts`, prose (markdown)** — table cell alignment, built by `markdown.ts` as `ta-${align}`: `.ta-c` `.ta-r`
401405 - **`style/content.ts`, diff viewer** — the diff table: its gutters, line kinds, file head and inline review comments: `.add` `.del` `.dh` `.diff` `.diff-body` `.diff-head` `.diff-note` `.diff-path` `.diff-stat` `.diff-stub` `.diff-summary` `.diff-table` `.dl` `.dl-review` `.dn` `.dn-comment` `.nonl` `.rc-hidden` `.rc-resolve` `.rc-resolved` `.wd`
src/web/pages/search.ts +2 −2
@@ -357,7 +357,7 @@ export async function searchPage(ctx: Ctx): Promise<Response> {
357357 };
358358
359359 const form = html`<form
360 class="filters"
360 class="bar mb"
361361 method="get"
362362 action="/search"
363363 role="search"
@@ -473,7 +473,7 @@ export async function searchPage(ctx: Ctx): Promise<Response> {
473473 );
474474
475475 const body = html`${pageHead(html`Results for “${a.query}”`)} ${form}
476 <div class="filters">${chips}</div>
476 <div class="bar mb">${chips}</div>
477477 ${liveToggle}
478478 ${when(
479479 busy !== undefined,
src/web/studio/explore.ts +1 −1
@@ -115,7 +115,7 @@ export async function explorePage(ctx: Ctx): Promise<Response> {
115115 />
116116 ${btn("Go", { size: "sm" })}
117117 </form>
118 <div class="filters mb">
118 <div class="bar mb">
119119 ${seg(
120120 kinds.map((k) => ({
121121 label: k.label,
src/web/style/content.ts +4 −8
@@ -212,14 +212,10 @@ a.origin-chip:hover { border-color: var(--border-strong); color: var(--fg); }
212212 border-radius: var(--radius-sm);
213213 }
214214
215 .filters { display: flex; align-items: center; gap: 8px; flex-wrap: wrap; margin-bottom: 12px; }
216 .filters form { display: flex; align-items: center; gap: 8px; flex-wrap: wrap; }
217 .filters .search { min-width: 180px; flex: 1; max-width: 320px; }
218 /* A list's six words fit a phone without pushing the page sideways: a
219 little less padding there, and a scroll inside the bar as the last resort. */
220 .filters .seg { max-width: 100%; overflow-x: auto; scrollbar-width: none; }
221 @media (max-width: 420px) { .filters .seg > a { padding: 0 8px; } }
222 /* The same three reaches for a filter bar drawn with §5's .bar. */
215 /* The same three reaches for a filter bar drawn with §5's .bar.
216 The search field takes the slack, and a list's six words fit a phone
217 without pushing the page sideways: a little less padding there, and a
218 scroll inside the bar as the last resort. */
223219 .bar .search { min-width: 180px; flex: 1; max-width: 320px; }
224220 .bar .seg { max-width: 100%; overflow-x: auto; scrollbar-width: none; }
225221 @media (max-width: 420px) { .bar .seg > a { padding: 0 8px; } }
test/explore.test.ts +3 −2
@@ -237,11 +237,12 @@ describe("explore", () => {
237237 expect(names(told.items)).toEqual(names((await api("kind:app sort:ships", bobToken)).items));
238238 });
239239
240 test("the page draws §5's row and filters, and no explore- class", async () => {
240 test("the page draws §5's row and bar, and no explore- or filters class", async () => {
241241 const page = await (await fetch(`${base}/explore`)).text();
242242 expect(page).toContain('class="row"');
243243 expect(page).toContain('class="row-title"');
244 expect(page).toContain('class="filters mb"');
244 expect(page).toContain('class="bar mb"');
245 expect(page).not.toMatch(/class="[^"]*\bfilters\b/);
245246 expect(page).not.toContain("explore-");
246247 });
247248

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs