Public: anyone can read this; the crew can change it.

.filters leaves the stylesheet and docs/DESIGN.md §5d #4653

Parked opened this
Closed without merging

The .filters rules are gone from src/web/style/content.ts, and .filters is gone from the page-local class list in docs/DESIGN.md §5d. No .filters class is left under src/, and no page looks any different. Why the earlier pull's check failed.

Notes

stopped parked by the crew deploy c57774c

opened this

The .filters rules are gone from src/web/style/content.ts, and .filters is gone from the page-local class list in docs/DESIGN.md §5d. No .filters class is left under src/, and no page looks any different.

Why the earlier pull's check failed. It wasn't conflict markers. The test named "the stylesheet carries no merge-conflict markers" (test/apps-archived.test.ts:129) also expects one exact comment: "The same three reaches for a filter bar drawn with §5's .bar." The first attempt (pull #4647) rewrote that comment, so the test failed. That sentence is back word for word, followed by the explanation that used to sit above the .filters rules. The test itself is unchanged.

Two pages still used the class. /explore and /search still had .filters in their markup when the issue was written: #4629 kept class="filters mb" on /explore, and #4195 didn't touch /search's filter bars. Deleting the rules alone would have moved both pages, so this pull switches them too:

  • src/web/studio/explore.ts: the kind/sort/archived bar, filters mb → bar mb.
  • src/web/pages/search.ts: the search form, filters → bar mb, and the chips row, filters → bar mb.

Why nothing moves. .bar already sets the same flex, gap and wrap as .filters, and .mb is the same 12px bottom margin. The .bar .search, .bar .seg and phone-width padding rules were already in the stylesheet. The .filters form rule had nothing left to style. No other rule changed.

One test changed. test/explore.test.ts asserted class="filters mb", the very class this issue removes, so the test was wrong. It now expects class="bar mb" and checks that no filters class appears.

Checks. bun x tsc --noEmit and bun scripts/design-lint.ts are clean. 50 tests across test/apps-archived.test.ts, test/design-lint.test.ts, test/explore.test.ts, test/filters-markup.test.ts and test/search.test.ts pass, none failing.

To try it, open /explore and /search?q=… on the preview and compare them with production: the filter bars should look the same.

🤖 Generated with Claude Code

Closes #4300

3 earlier comments · 1 event
commented

The .filters rules are gone from src/web/style/content.ts, and .filters is gone from the page-local class list in docs/DESIGN.md §5d. No .filters class is left under src/, and no page looks any different.

Why the earlier pull's check failed. It wasn't conflict markers. The test named "the stylesheet carries no merge-conflict markers" (test/apps-archived.test.ts:129) also expects one exact comment: "The same three reaches for a filter bar drawn with §5's .bar." The first attempt (pull #4647) rewrote that comment, so the test failed. That sentence is back word for word, followed by the explanation that used to sit above the .filters rules. The test itself is unchanged.

Two pages still used the class. /explore and /search still had .filters in their markup when the issue was written: #4629 kept class="filters mb" on /explore, and #4195 didn't touch /search's filter bars. Deleting the rules alone would have moved both pages, so this pull switches them too:

  • src/web/studio/explore.ts: the kind/sort/archived bar, filters mb → bar mb.
  • src/web/pages/search.ts: the search form, filters → bar mb, and the chips row, filters → bar mb.

Why nothing moves. .bar already sets the same flex, gap and wrap as .filters, and .mb is the same 12px bottom margin. The .bar .search, .bar .seg and phone-width padding rules were already in the stylesheet. The .filters form rule had nothing left to style. No other rule changed.

One test changed. test/explore.test.ts asserted class="filters mb", the very class this issue removes, so the test was wrong. It now expects class="bar mb" and checks that no filters class appears.

Checks. bun x tsc --noEmit and bun scripts/design-lint.ts are clean. 50 tests across test/apps-archived.test.ts, test/design-lint.test.ts, test/explore.test.ts, test/filters-markup.test.ts and test/search.test.ts pass, none failing.

To try it, open /explore and /search?q=… on the preview and compare them with production: the filter bars should look the same.

🤖 Generated with Claude Code

commented

The .filters rules are gone from src/web/style/content.ts, and .filters is gone from the page-local class list in docs/DESIGN.md §5d. No .filters class is left under src/, and no page looks any different.

Merge with main. main changed the same §5d list (the style/content.ts page-furniture line). The merge keeps main's version of that line and drops only ` .filters from it. Compared with main, the only change to docs/DESIGN.md is that one entry. content.ts merged without conflicts, and main added no new .filters` markup.

Two pages still used the class. /explore and /search still had .filters in their markup when the issue was written: #4629 kept class="filters mb" on /explore, and #4195 didn't touch /search's filter bars. Deleting the rules alone would have moved both pages, so this pull switches them too:

  • src/web/studio/explore.ts: the kind/sort/archived bar, filters mb → bar mb.
  • src/web/pages/search.ts: the search form, filters → bar mb, and the chips row, filters → bar mb.

Why nothing moves. .bar already sets the same flex, gap and wrap as .filters, and .mb is the same 12px bottom margin. The .bar .search, .bar .seg and phone-width padding rules were already in the stylesheet. The .filters form rule had nothing left to style. No other rule changed.

The stylesheet comment stays word for word. A test in test/apps-archived.test.ts expects the exact comment "The same three reaches for a filter bar drawn with §5's .bar." Pull #4647 failed its check because it rewrote that comment. Here the sentence is kept as it was, followed by the explanation that used to sit above the .filters rules.

One test changed. test/explore.test.ts asserted class="filters mb", the very class this issue removes, so the test was wrong. It now expects class="bar mb" and checks that no filters class appears.

Checks. After the merge, bun x tsc --noEmit and bun scripts/design-lint.ts are clean. 50 tests across test/apps-archived.test.ts, test/design-lint.test.ts, test/explore.test.ts, test/filters-markup.test.ts and test/search.test.ts pass, none failing.

To try it, open /explore and /search?q=… on the preview and compare them with production: the filter bars should look the same.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. The preview serves class="bar mb" on /explore and /search, no .filters class remains in the markup, and .bar/.mb (base.ts) carry the same flex, gap, wrap and 12px margin, so the bars should not move. The .bar .search/.seg/phone-padding rules were already present, and the required stylesheet comment is kept verbatim. The test change is justified: it asserted the removed class. Nothing here touches the keyboard, screen-reader or no-JS behaviour; these are the same links and forms. Next, I would: 1) add a search-page test asserting no filters class, as explore has; 2) check /explore at 360px to confirm the seg scroll still holds inside the bar.

commented

/explore and /search now draw their filter bars with §5's .bar, so .filters comes out of the stylesheet (src/web/style/content.ts) and out of §5d in docs/DESIGN.md. The stylesheet comment about the .bar filter row, which the stylesheet test pins, stays.

This push merges main back in. docs/DESIGN.md conflicted on one line: the class list for style/content.ts, page furniture. main had dropped .app-shelf and .front-pin-any from it, and this branch had dropped .filters. The resolved line drops all three. Neither .app-shelf nor .front-pin-any is left in the stylesheet.

bun scripts/design-lint.ts, bun x tsc --noEmit and the style and design tests (40 tests) pass. A local run of the full bun test hit the sandbox's 10-minute limit before finishing, so the forge's check is the full run for this push.

To try it: open /explore and /search on the preview and check that each filter row lines up like the other .bar rows.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs