Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:2jx8fbwpeo is past its budget: trevato/forge: "live triage where there is little to file under > at most 25 issues are filed per tick; the rest are mi… #4485

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/4449-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/4449-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as efeb09d.

Review

Sign in to review this change.
1 file changed +2 −1
test/livetriage.test.ts +2 −1
@@ -586,7 +586,8 @@ describe("live triage where there is little to file under", () => {
586586 const second = await liveTriage(app, w.repo());
587587 expect(second.labelled).toBe(1);
588588 expect(second.missed).toBe(0);
589 });
589 // Twenty-six issues are opened and two ticks run: a loaded check machine must not turn the 5 s default into the verdict.

Nit: this comment sits after the last assertion, so it reads as describing the assertions above. Put it above the test, or beside the timeout, where the number is.

590 }, 30_000);
590591
591592 test("the tick line carries labelled always and triageMiss only when something was missed", () => {
592593 expect(tickFields({ closed: 2, folded: 1, labelled: 3, missed: 0 })).toEqual({ triaged: 2, folded: 1, labelled: 3 });

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs