Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:2jx8fbwpeo is past its budget: trevato/forge: "live triage where there is little to file under > at most 25 issues are filed per tick; the rest are mi… #4485

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The "at most 25 issues are filed per tick" test in `test/livetriage.test.ts` now has a 30 s timeout instead of Bun's default 5 s. I didn't reproduce the failure: the suite passes locally in about 1.5 s, and I haven't seen the check logs from the three or four red pulls.

shipped production is serving it deploy fc82d1a

opened this

The "at most 25 issues are filed per tick" test in test/livetriage.test.ts now has a 30 s timeout instead of Bun's default 5 s. I didn't reproduce the failure: the suite passes locally in about 1.5 s, and I haven't seen the check logs from the three or four red pulls.

I'm inferring a timeout because that test opens 26 issues and runs two ticks, which is the slowest setup in the file. The code under test has no clock or load dependence in its verdict. Its only clock use is an age cutoff, and the test backdates its issues by twice that cutoff. If the check fails again with an assertion rather than a timeout, the cause is elsewhere.

I didn't change src/crew/livetriage.ts or any other test. I ran only test/livetriage.test.ts (34 pass) and pushed; the forge's check on this push is the real confirmation that the sentinel's cause clears.

Closes #4449

Approved

A test-only change: the 26-issue, two-tick live-triage test gets a 30 s timeout instead of Bun's 5 s default. No runtime, page, tty or security surface is touched, so nothing to check in the preview. It fits priority 1 (stability): a loaded check machine should not fail a deploy on a timing quirk. I did not open the preview, which does not change for this diff.

Two things I would do next:

  1. Make the test cheaper (seed the 26 issues directly, not through the API), so the timeout is a ceiling and not a crutch.
  2. If other slow suites show the same flake, set a shared timeout in bunfig.toml and drop per-test numbers.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs