Public: anyone can read this; the crew can change it.

Design: the front page's featured app draws §5's card and the tiles' look, and front-featured* leave §5d #4246

Parked opened this
Closed without merging

mason/forge:mason/4084-design-the-front-page-s-featured-app-dra → main 3 commits fork

  • Closed without merging. Nothing was applied to main.

Review

Sign in to review this change.
4 files changed +33 −42
docs/DESIGN.md +1 −1
@@ -394,7 +394,7 @@ gone, so this list only shrinks.
394394 A `.field` directly inside a `.bar` drops its bottom margin and the bar aligns to the end, so a labelled input and its button share a baseline
395395 - **`style/components.ts`** — parts of the §5 components that the table does not spell out — the palette's list, the menu's items, a dialog's head and foot, comments, the theme picker — and a few small helpers beside them: `.cat` `.clone` `.clone-text` `.comment` `.comment-body` `.comment-form` `.dash` `.dialog-body` `.dialog-foot` `.dialog-head` `.empty-title` `.error-note` `.field-row` `.form-actions` `.hex` `.ico` `.ico-loader` `.list` `.live-status` `.menu-item` `.menu-panel` `.menu-sep` `.menu-title` `.palette-empty` `.palette-foot` `.palette-group` `.palette-heading` `.palette-input` `.palette-item` `.palette-list` `.passkey` `.passkey-lead` `.passkey-note` `.passkey-off` `.passkey-on` `.preview` `.sep` `.split` `.sprite` `.swatch` `.table-scroll` `.tell-here` `.theme-apply` `.theme-option` `.tick` `.timeline` `.tl-dot` `.toast-body` `.topbar-search`
396396 - **`style/components.ts`, settings rows** — a list whose rows are settings (limits, capacity): the `<ul class="list setting-list">` lets title and meta wrap instead of ellipsizing, and a row's controls take their own line under 640px. `.row-fields` is the form in that row's trail (input, Save, Default): always visible, never hover-gated, wrapping under the text before it would clip. Use both for any page whose rows show a name, a current value, and a control to change it; use `.row-actions` only for secondary actions (delete, wake, pin, revoke). Flags, telemetry, cloud, people, crew roles and subscription headroom/budget use `.row-fields`. Classes: `.row-fields` `.setting-list`
397 - **`style/content.ts`, page furniture** — what frames a page's content: page and repo heads, the merge box, the front page and its tiles, explore, backups, boards, the fleet chart's series colours, following, lineage: `.act` `.app-shelf` `.app-tile` `.app-tile-body` `.app-tile-desc` `.app-tile-look` `.app-tile-name` `.backups-drill` `.backups-error` `.backups-now` `.backups-restore` `.bform` `.bgrid` `.big` `.bmanage` `.boards-result` `.bp-h2` `.bp-h3` `.bp-w2` `.bp-w3` `.break` `.bt-bar` `.bt-grid` `.bt-group` `.bt-hist` `.bt-name` `.bt-procs` `.bt-row` `.bt-val` `.chart` `.chart-box` `.commit-body` `.commit-head` `.connect-more` `.connect-path` `.domain-records` `.explore-filters` `.explore-line` `.explore-main` `.explore-name` `.explore-row` `.fg-s0` `.fg-s1` `.fg-s2` `.fg-s3` `.fg-s4` `.fg-s5` `.fg-s6` `.fg-s7` `.filters` `.flag-form` `.following` `.following-actions` `.following-eyebrow` `.following-foot` `.following-head` `.following-sentence` `.fork-bar` `.front-admin` `.front-controls` `.front-crew` `.front-featured` `.front-featured-body` `.front-featured-look` `.front-issues` `.front-live` `.front-more` `.front-pick` `.front-pin-any` `.front-weights` `.frozen` `.frozen-form` `.frozen-sentence` `.handoff` `.handoff-links` `.headroom` `.issue-head` `.issue-meta` `.merge-box` `.merge-form` `.merge-headline` `.merge-sub` `.mirror-form` `.number` `.origin-link` `.origin-mark` `.origin-name` `.origin-row` `.owner` `.page-head` `.path-head` `.policy-line` `.qf` `.repo-actions` `.repo-audience` `.repo-desc` `.repo-layout` `.repo-lineage` `.repo-title` `.search` `.slash` `.stage-detail` `.stage-dot` `.steps` `.sub` `.sys-pair` `.table-wrap` `.terminal-line` `.tok` `.tree-row` `.tree-total` `.wall-cells` `.where-sep`
397 - **`style/content.ts`, page furniture** — what frames a page's content: page and repo heads, the merge box, the front page and its tiles, explore, backups, boards, the fleet chart's series colours, following, lineage: `.act` `.app-shelf` `.app-tile` `.app-tile-body` `.app-tile-desc` `.app-tile-look` `.app-tile-name` `.backups-drill` `.backups-error` `.backups-now` `.backups-restore` `.bform` `.bgrid` `.big` `.bmanage` `.boards-result` `.bp-h2` `.bp-h3` `.bp-w2` `.bp-w3` `.break` `.bt-bar` `.bt-grid` `.bt-group` `.bt-hist` `.bt-name` `.bt-procs` `.bt-row` `.bt-val` `.chart` `.chart-box` `.commit-body` `.commit-head` `.connect-more` `.connect-path` `.domain-records` `.explore-filters` `.explore-line` `.explore-main` `.explore-name` `.explore-row` `.fg-s0` `.fg-s1` `.fg-s2` `.fg-s3` `.fg-s4` `.fg-s5` `.fg-s6` `.fg-s7` `.filters` `.flag-form` `.following` `.following-actions` `.following-eyebrow` `.following-foot` `.following-head` `.following-sentence` `.fork-bar` `.front-admin` `.front-controls` `.front-crew` `.front-issues` `.front-live` `.front-more` `.front-pick` `.front-pin-any` `.front-weights` `.frozen` `.frozen-form` `.frozen-sentence` `.handoff` `.handoff-links` `.headroom` `.issue-head` `.issue-meta` `.merge-box` `.merge-form` `.merge-headline` `.merge-sub` `.mirror-form` `.number` `.origin-link` `.origin-mark` `.origin-name` `.origin-row` `.owner` `.page-head` `.path-head` `.policy-line` `.qf` `.repo-actions` `.repo-audience` `.repo-desc` `.repo-layout` `.repo-lineage` `.repo-title` `.search` `.slash` `.stage-detail` `.stage-dot` `.steps` `.sub` `.sys-pair` `.table-wrap` `.terminal-line` `.tok` `.tree-row` `.tree-total` `.wall-cells` `.where-sep`
398398 - **`style/content.ts`, code view** — the source view and the syntax-highlight token classes `highlight-html.ts` builds as `tok-${kind}`: `.blob-view` `.ln` `.tok-attribute` `.tok-comment` `.tok-constant` `.tok-decorator` `.tok-deleted` `.tok-emphasis` `.tok-function` `.tok-heading` `.tok-inserted` `.tok-keyword` `.tok-link` `.tok-meta` `.tok-number` `.tok-operator` `.tok-plain` `.tok-property` `.tok-punctuation` `.tok-regex` `.tok-string` `.tok-tag` `.tok-type` `.tok-variable`
399399 - **`style/content.ts`, prose (markdown)** — table cell alignment, built by `markdown.ts` as `ta-${align}`: `.ta-c` `.ta-r`
400400 - **`style/content.ts`, diff viewer** — the diff table: its gutters, line kinds, file head and inline review comments: `.add` `.del` `.dh` `.diff` `.diff-body` `.diff-head` `.diff-note` `.diff-path` `.diff-stat` `.diff-stub` `.diff-summary` `.diff-table` `.dl` `.dl-review` `.dn` `.dn-comment` `.nonl` `.rc-hidden` `.rc-resolve` `.rc-resolved` `.wd`
src/web/studio/home.ts +24 −20
@@ -357,25 +357,26 @@ function featuredCard(featured: NonNullable<FrontPage["featured"]>): Html {
357357 }),
358358 ])
359359 : null;
360 return html`<section class="front-featured" aria-label="Featured">
361 ${when(
362 picture,
363 (src) =>
364 html`<a class="front-featured-look" href="${base}"
365 ><img
366 src="${src}"
367 width="${LOOK_SIZES.thumb.width}"
368 height="${LOOK_SIZES.thumb.height}"
369 alt="${repo.name} as it looks now"
370 /></a>`,
371 )}
372 <div class="front-featured-body">
373 <span class="small muted">Featured</span>
374 <h2><a href="${base}">${repo.ownerName}/${repo.name}</a></h2>
375 ${when(repo.description, (d) => html`<p>${d}</p>`)} ${work}
376 <div class="bar">${btn("Open", { href: base, variant: "primary" })}</div>
377 </div>
378 </section>`;
360 return card(
361 html`${when(
362 picture,
363 (src) =>
364 html`<a class="look" href="${base}"
365 ><img
366 src="${src}"
367 width="${LOOK_SIZES.thumb.width}"
368 height="${LOOK_SIZES.thumb.height}"
369 alt="${repo.name} as it looks now"
370 /></a>`,
371 )}
372 <div class="card-body stack">
373 <span class="small muted">Featured</span>
374 <h2><a href="${base}">${repo.ownerName}/${repo.name}</a></h2>
375 ${when(repo.description, (d) => html`<p class="muted">${d}</p>`)} ${work}
376 <div class="bar">${btn("Open", { href: base, variant: "primary" })}</div>
377 </div>`,
378 { pad: false },
379 );
379380 }
380381
381382 /** A weight's name as the controls say it. */
@@ -532,7 +533,10 @@ export function studioDoor(ctx: Ctx): Response {
532533 </div>`,
533534 )}
534535 </section>
535 ${when(front.featured, (f) => html`<div class="mt">${featuredCard(f)}</div>`)}
536 ${when(
537 front.featured,
538 (f) => html`<section class="mt" aria-label="Featured">${featuredCard(f)}</section>`,
539 )}
536540 ${tiles.length > 0
537541 ? html`<div class="mt app-shelf">${tiles}</div>
538542 ${when(
src/web/style/content.ts +1 −19
@@ -435,21 +435,7 @@ form.inline { display: inline; margin-left: auto; }
435435 .explore-row > .btn { margin-left: 0; }
436436 }
437437
438 /* The featured repository: its picture and its crew at work, side by side
439 on a desk, stacked on a phone. */
440 .front-featured {
441 display: grid; gap: 0; max-width: 1040px; margin-inline: auto;
442 grid-template-columns: minmax(0, 3fr) minmax(0, 2fr);
443 border: 1px solid var(--border); border-radius: var(--radius);
444 overflow: hidden; background: var(--card);
445 }
446 .front-featured-look img { display: block; width: 100%; height: auto; background: var(--muted); }
447 .front-featured-body { display: grid; align-content: center; gap: 8px; padding: 20px 24px; min-width: 0; }
448 .front-featured-body > * { min-width: 0; }
449 .front-featured-body h2 { font-size: 20px; letter-spacing: -0.02em; }
450 .front-featured-body h2 a { color: inherit; text-decoration: none; }
451 .front-featured-body p { color: var(--muted-fg); text-wrap: pretty; }
452 .front-featured:not(:has(.front-featured-look)) { grid-template-columns: 1fr; }
438 /* The featured repository's crew at work, inside its §5 card. */
453439 .front-crew { display: flex; align-items: center; gap: 8px; font-size: 14px; }
454440 .front-live {
455441 width: 8px; height: 8px; border-radius: 50%; background: var(--success);
@@ -472,10 +458,6 @@ form.inline { display: inline; margin-left: auto; }
472458 .app-shelf { gap: 10px; grid-template-columns: repeat(2, minmax(0, 1fr)); }
473459 .app-tile-body { padding: 8px 10px; }
474460 }
475 @media (max-width: 720px) {
476 .front-featured { grid-template-columns: 1fr; }
477 .front-featured-body { padding: 16px; }
478 }
479461
480462 /* Every page grid, in one rule: a grid item's automatic minimum size is its
481463 *content*, so a column with a long unbreakable line pushes the page wider
test/front.test.ts +7 −2
@@ -428,10 +428,15 @@ describe("the front page", () => {
428428 const body = await door();
429429 // The most-forked app is featured — a stranger's, ahead of the owner's.
430430 const featured = body.slice(
431 body.indexOf('class="front-featured"'),
432 body.indexOf("</section>", body.indexOf('class="front-featured"')),
431 body.indexOf('aria-label="Featured"'),
432 body.indexOf("</section>", body.indexOf('aria-label="Featured"')),
433433 );
434434 expect(featured).toContain('href="/zed/loved"');
435 // It is a §5 card wearing the tiles' look, not a page-local block (#4084).
436 expect(featured).toContain('class="card"');
437 expect(featured).toMatch(/<a class="look" href="\/zed\/loved"\s*><img\s/);
438 expect(featured).toContain('alt="loved as it looks now"');
439 expect(body).not.toContain("front-featured");
435440 expect(body).not.toContain('href="/owner/down"');
436441 expect(body).not.toContain('href="/owner/bare"');
437442 expect(body).not.toContain("hush");

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs