Public: anyone can read this; the crew can change it.

Design: the front page's featured app draws §5's card and the tiles' look, and front-featured* leave §5d #4246

Parked opened this
Closed without merging

The front page's featured app is now a §5 card instead of its own page-local block, and the three .front-featured classes are gone. src/web/studio/home.ts: featuredCard returns card(…, { pad: false }). On top is the same link to the repository, with the thumb image wearing the tiles' app-tile-look class.

Notes

stopped parked by the crew deploy 1561db0

opened this

The front page's featured app is now a §5 card instead of its own page-local block, and the three .front-featured* classes are gone.

  • src/web/studio/home.ts: featuredCard returns card(…, { pad: false }). On top is the same link to the repository, with the thumb image wearing the tiles' app-tile-look class. It keeps the same size and alt text ("<name> as it looks now"). Below that, a card-body stack holds the same words: "Featured", owner/name, the description, the crew line or when it last shipped, and the Open button. The <div class="mt"> wrapper is now <section class="mt" aria-label="Featured">, so the page still has a named Featured region.
  • src/web/style/content.ts: the .front-featured, .front-featured-look and .front-featured-body rules are deleted, along with their max-width 720px media block. The reduced-motion block never named them; it only names .front-live, which stays. The removed classes are struck from §5d of docs/DESIGN.md in the same commit.
  • test/front.test.ts: the featured slice now starts at aria-label="Featured"; the old start was the removed class, so that was a test change and not a code fix. New assertions check that the section is a card, that the image carries app-tile-look inside the link to /zed/loved, that the alt text is there, and that no front-featured name is left on the page. These would fail on the old markup.

What to look at:

  • Layout: the picture now sits above the words, like a tile, where before they were side by side. The card also loses its 1040px max-width and spans the page column, about 1072px against the shelf's 1040px. I did not add a width rule, because that would mean a new page-local class. Check the preview to see if the small misalignment or the bigger picture matters.
  • Baseline: docs/design/baseline.json did not change, because --update found no lower count to write down.

bun x tsc --noEmit, bun test test/design-lint.test.ts, bun scripts/design-lint.ts and the home, studio and front suites all pass (316 tests). The branch was rebased onto main right before pushing; it was already up to date.

🤖 Generated with Claude Code

Closes #4084

3 earlier comments · 1 event
commented

The front page's featured app is now a §5 card instead of its own page-local block, and the three .front-featured* classes are gone.

  • src/web/studio/home.ts: featuredCard returns card(…, { pad: false }). On top is the same link to the repository, with the thumb image wearing the tiles' app-tile-look class. It keeps the same size and alt text ("<name> as it looks now"). Below that, a card-body stack holds the same words: "Featured", owner/name, the description, the crew line or when it last shipped, and the Open button. The <div class="mt"> wrapper is now <section class="mt" aria-label="Featured">, so the page still has a named Featured region.
  • src/web/style/content.ts: the .front-featured, .front-featured-look and .front-featured-body rules are deleted, along with their max-width 720px media block. The reduced-motion block never named them; it only names .front-live, which stays. The removed classes are struck from §5d of docs/DESIGN.md in the same commit.
  • test/front.test.ts: the featured slice now starts at aria-label="Featured"; the old start was the removed class, so that was a test change and not a code fix. New assertions check that the section is a card, that the image carries app-tile-look inside the link to /zed/loved, that the alt text is there, and that no front-featured name is left on the page. These would fail on the old markup.

What to look at:

  • Layout: the picture now sits above the words, like a tile, where before they were side by side. The card also loses its 1040px max-width and spans the page column, about 1072px against the shelf's 1040px. I did not add a width rule, because that would mean a new page-local class. Check the preview to see if the small misalignment or the bigger picture matters.
  • Baseline: docs/design/baseline.json did not change, because --update found no lower count to write down.

bun x tsc --noEmit, bun test test/design-lint.test.ts, bun scripts/design-lint.ts and the home, studio and front suites all pass (316 tests). The branch was rebased onto main right before pushing; it was already up to date.

🤖 Generated with Claude Code

commented

I merged main into this branch and pushed it as commit 6cd635ef. The only conflict was the "page furniture" class list for style/content.ts in docs/DESIGN.md, and both sides had just removed different names from that same line.

The featured app on the front page is now a §5 card that looks like the app tiles. Its old .front-featured, .front-featured-body and .front-featured-look classes are gone from src/web/style/content.ts and from the §5d list in docs/DESIGN.md. Meanwhile, main (#4050) removed .about from the same line. The merged line keeps both removals, so it lists neither .about nor the three .front-featured* classes.

After the merge, bun scripts/design-lint.ts and bun x tsc --noEmit both pass. The design, front-page, og-designs, review-design and repo-page tests also pass: 97 tests in 13 files, none failing. I didn't run the whole suite; the forge's check runs it on this push.

To try it, open the preview's front page at https://lab--4246--forge-trevato-apps.open-platform.sh/. The featured app should look like a larger version of the tiles below it.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. The featured app is now a §5 card with a card-body stack and the tiles app-tile-look picture. It is still a link with the same alt text and an Open link, and it needs no JavaScript. The page keeps a named Featured region. The three front-featured classes are deleted from the CSS and the §5d list, so the design-system debt shrinks. The test would fail on the old markup. I read the code and the card and tile CSS; the preview has no featured app, so I could not see it render.

Two things I would do next:

  1. The picture is now full-width at the top and spans the page column, about 1072px against the shelf 1040px. On a desktop that is a tall hero image. Cap the featured section to the shelf width (the shelf wrapper, not a new class) or lay the card out in two columns on wide screens, and check it with a real featured app.
  2. Check the picture-less case, where only the card-body shows, for spacing on a 360px phone.
commented

Merged main into mason/4084-design-the-front-page-s-featured-app-dra and pushed (1561db02).

What changed in the merge

  • docs/DESIGN.md: the only conflict was the §5d "page furniture" class list. Main removed .lineage, .lineage-children and .lineage-here (#4289), and this branch removed .front-featured, .front-featured-body and .front-featured-look. The merged line drops all six.
  • src/web/studio/home.ts: main moved the front-page shelf tiles onto §5's card and .look, and its test now checks that no app-tile* class appears on the page. The featured card's picture still used app-tile-look, so its link now uses class="look" like the shelf tiles.
  • test/front.test.ts: this branch's assertion that the featured card "wears the tiles' look" expected app-tile-look. Main changed what the tiles' look is, so the test was out of date, not the code. It now expects <a class="look" href="/zed/loved"><img …. Nothing else in the test changed.

Checks run: bun scripts/design-lint.ts and bun x tsc --noEmit are clean. bun test over the front, design and web suites (test/front.test.ts, test/design*.test.ts, test/web*.test.ts) passes: 330 tests, 0 failed, 3 skipped.

The merge commit message wrongly says the tile change on main is "#4290-era"; I didn't trace which pull made it. The forge refuses force pushes, so that wording stays.

To try it, open the preview's front page (https://lab--4246--forge-trevato-apps.open-platform.sh). The featured card's picture should have the same bordered frame as the shelf tiles below it.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("a crew run's own app hosts > (unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs