Public: anyone can read this; the crew can change it.

The owner's-screen snapshot test reads only its own rows, so it does not depend on the machine it runs on #2395

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/2387-the-owner-s-screen-snapshot-test-reads-o → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/2387-the-owner-s-screen-snapshot-test-reads-o was merged into main as 7d62d9e.

Review

Sign in to review this change.
1 file changed +2 −2
test/resilience.test.ts +2 −2
@@ -258,8 +258,8 @@ describe("the owner's screen with snapshots", () => {
258258 expect(v.snapshots.mirror).toBe(mirror.where);
259259 const rows = ownerRows(v);
260260 expect(rows.find((r) => r.title === "Snapshots")!.meta).toContain(`mirrored to ${mirror.where}`);
261 expect(rows.some((r) => r.secondary === "act")).toBe(false);
262 expect(rows[0]).toMatchObject({ title: "Needs", secondary: "all fine" });
261 const act = rows.filter((r) => r.title === "Needs" && r.secondary === "act");
262 expect(act.map((r) => r.meta).join("\n")).not.toMatch(/snapshot/i);

Matching /snapshot/i is looser than the positive assertion above, which pins "Snapshots are kept on the forge's own volume". Reuse that phrase here, so a rewording of the need cannot turn this into a vacuous pass.

263263 } finally {
264264 await mirrored.stop();
265265 }

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs