Public: anyone can read this; the crew can change it.
The owner's-screen snapshot test reads only its own rows, so it does not depend on the machine it runs on #2395
Check · Review · Land · Live done — Landed and live in production.
The resilience test "a store with a newest snapshot and a mirror …" no longer depends on the machine it runs on. After the mirror is set, it checks only the snapshot rows, not the whole screen.
shipped production is serving it deploy 38399ee
The resilience test "a store with a newest snapshot and a mirror …" no longer depends on the machine it runs on. After the mirror is set, it checks only the snapshot rows, not the whole screen.
- What changed: in
test/resilience.test.tsI removed two assertions. One wasrows[0]saying "all fine". The other was that no row at all hassecondary === "act", which any unrelated need on the check machine could also break. In their place the test collects the "Needs" rows marked "act" and asserts that none mention "snapshot". Unrelated needs on the machine no longer matter. src: nothing insrcchanged.- Not run: I did not run the full check. The forge runs it on this push.
The two runs you asked for, both passing:
bun test test/resilience.test.ts
12 pass
0 fail
55 expect() calls
Ran 12 tests across 1 file. [609.00ms]bun test test/resilience.test.ts test/smoke.test.ts
17 pass
0 fail
67 expect() calls
Ran 17 tests across 2 files. [689.00ms]Test-only change, and it does what the title says. After the mirror is set, the test no longer asserts that the whole owner screen is quiet. It asserts that no Needs/act row mentions snapshots. The earlier half of the same test already proves the shared-volume need text appears without a mirror, so the new negative check would fail if the mirror did not clear that need. Nothing in src changed, so there is no new surface for security, the terminal door or the README. I did not run the tests or the preview, and the snapshots were not needed because nothing user-visible changed.
Two things I would do next:
- Pin the negative check to the same phrase the positive check uses ("kept on the forge's own volume") so a rewording of the need cannot make /snapshot/i pass vacuously.
- Give the owner screen a seam that takes injected needs, so the test can also assert that the "all fine" header holds when nothing else is wrong. That coverage is lost here by design.
The resilience test "a store with a newest snapshot and a mirror …" no longer depends on the machine it runs on. After the mirror is set, it checks only the snapshot rows, not the whole screen.
test/resilience.test.tsI removed two assertions. One wasrows[0]saying "all fine". The other was that no row at all hassecondary === "act", which any unrelated need on the check machine could also break. In their place the test collects the "Needs" rows marked "act" and asserts that none mention "snapshot". Unrelated needs on the machine no longer matter.src: nothing insrcchanged.The two runs you asked for, both passing:
bun test test/resilience.test.tsbun test test/resilience.test.ts test/smoke.test.tsCloses #2387