Public: anyone can read this; the crew can change it.
A guided review's doors: the terminal walks and sets the steps, a how-to, the MCP read and the brief line #14229
Check · Review · Land · Live — No review yet.
This pull adds the terminal door for guided review: V walks an app pull's steps and E sets them. It also adds the how-to, the MCP read and the brief line. I rebuilt it from the issue because the branch torque/13653-review-steps-doors isn't on the forge.
look green — it answered, no tests were run, ready for a look deploy a527839
Check passeddeploy a527839
Website spec: 26 findings (report only)
- /board http://127.0.0.1:33959/board answered 303 — https://specification.website/
- /notes http://127.0.0.1:33959/notes answered 303 — https://specification.website/
- /review http://127.0.0.1:33959/review answered 303 — https://specification.website/
- /releases http://127.0.0.1:33959/releases answered 303 — https://specification.website/
- /system http://127.0.0.1:33959/system answered 303 — https://specification.website/
- /admin/limits http://127.0.0.1:33959/admin/limits answered 404 — https://specification.website/
- /maintenance http://127.0.0.1:33959/maintenance answered 303 — https://specification.website/
- /talk http://127.0.0.1:33959/talk answered 303 — https://specification.website/
- /flow http://127.0.0.1:33959/flow answered 303 — https://specification.website/
- /resilience http://127.0.0.1:33959/resilience answered 303 — https://specification.website/
- /boards?help http://127.0.0.1:33959/boards?help answered 303 — https://specification.website/
- /settings/crew http://127.0.0.1:33959/settings/crew answered 303 — https://specification.website/
- /settings/crew?help http://127.0.0.1:33959/settings/crew?help answered 303 — https://specification.website/
- /settings/security/controls http://127.0.0.1:33959/settings/security/controls answered 303 — https://specification.website/
- /settings/grants http://127.0.0.1:33959/settings/grants answered 303 — https://specification.website/
- /preview-admin/sample expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/drop http://127.0.0.1:33959/preview-admin/sample/drop answered 303 — https://specification.website/
- /preview-admin/sample/data-move http://127.0.0.1:33959/preview-admin/sample/data-move answered 303 — https://specification.website/
- /preview-admin/sample/cut-over http://127.0.0.1:33959/preview-admin/sample/cut-over answered 303 — https://specification.website/
- /preview-admin/sample/next?pick expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/space the first focusable element is not a skip link (an in-page #target link) — skip-link
- /looks/missing http://127.0.0.1:33959/looks/missing answered 404 — https://specification.website/
- /looks/failed http://127.0.0.1:33959/looks/failed answered 500 — https://specification.website/
- /nope/nothing http://127.0.0.1:33959/nope/nothing answered 404 — https://specification.website/
Look
10 pages beside main · 0 new to this pull
/apps
In the dark
at a527839 ·
/docs
In the dark
at a527839 ·
/explore
In the dark
at a527839 ·
/looks/failed
In the dark
at a527839 ·
/looks/missing
In the dark
at a527839 ·
/nope/nothing
In the dark
at a527839 ·
/notes
In the dark
at a527839 ·
/releases
In the dark
at a527839 ·
/review
In the dark
at a527839 ·
/security
In the dark
at a527839 ·
This pull adds the terminal door for guided review: V walks an app pull's steps and E sets them. It also adds the how-to, the MCP read and the brief line. I rebuilt it from the issue because the branch torque/13653-review-steps-doors isn't on the forge. #13701's core, actions and API were already on main.
bun x tsc --noEmit and bun scripts/gate.ts --fix are clean. The new and edited tests pass: test/tui-pull-review.test.ts, test/review-steps.test.ts, test/mcp-size.test.ts, test/feature-orphans.test.ts. So do the brief, MCP-pull and TUI-pull suites I ran by hand. I did not run bun scripts/design-lint.ts: it hit a sandbox network denial and timed out. It should have nothing to check, since I touched nothing in src/web/.
What changed
V: on an app's pull,Vopenssrc/tui/screens/pull_review.ts. Each step shows what to look at, what to expect and the question.oopens the step's preview page, or shows its address to copy.w,b(then a one-line note) andsanswer it. After the last answer ONE comment goes to the pull throughsendReviewAnswers, the same as the page's.E: a writer on an open pull sets the script from one line of JSON. A bad list names the step that is wrong and sets nothing. Both keys are listed on the pull screen.- Shared gates:
src/actions/review_steps.tsgainsreadAnswerLine(w,b <note>,s; notes capped at 500 characters and stripped of control characters) andsetWords(the words for a refused write). - MCP: the
pulltool now carriesreviewSteps, the same list asGET …/pulls/:number/review. It is an added field, not a new tool. - Brief:
src/crew/brief.tsasks a builder to end a page-changing pull with a fencedreviewblock of 1–12 steps. - Docs: new
docs/features/review-steps.mdwith its row indocs/features/README.md, and the AGENTS.md entry forreadsinsrc/core/review_steps.tsand the terminal door. - Tests:
test/tui-pull-review.test.tscovers setting steps (a bad list, a non-writer, a good list) and walking them to one comment.test/review-steps.test.tsgainsreadAnswerLineandsetWordscases.
Left out
- The walk keeps answers in memory, so leaving it before the last step discards them.
Etakes one line of JSON, not a multi-line editor.- The step's
lookselector is shown in the terminal as text only. The highlight is the preview tour's job.
Try it
Open an app's pull in the terminal and press E to set steps, then V to walk them. Or read reviewSteps from the MCP pull tool.
🤖 Generated with Claude Code
This pull adds the terminal door for guided review:
Vwalks an app pull's steps andEsets them. It also adds the how-to, the MCP read and the brief line. I rebuilt it from the issue because the branchtorque/13653-review-steps-doorsisn't on the forge. #13701's core, actions and API were already on main.bun x tsc --noEmitandbun scripts/gate.ts --fixare clean. The new and edited tests pass:test/tui-pull-review.test.ts,test/review-steps.test.ts,test/mcp-size.test.ts,test/feature-orphans.test.ts. So do the brief, MCP-pull and TUI-pull suites I ran by hand. I did not runbun scripts/design-lint.ts: it hit a sandbox network denial and timed out. It should have nothing to check, since I touched nothing insrc/web/.What changed
V: on an app's pull,Vopenssrc/tui/screens/pull_review.ts. Each step shows what to look at, what to expect and the question.oopens the step's preview page, or shows its address to copy.w,b(then a one-line note) andsanswer it. After the last answer ONE comment goes to the pull throughsendReviewAnswers, the same as the page's.E: a writer on an open pull sets the script from one line of JSON. A bad list names the step that is wrong and sets nothing. Both keys are listed on the pull screen.src/actions/review_steps.tsgainsreadAnswerLine(w,b <note>,s; notes capped at 500 characters and stripped of control characters) andsetWords(the words for a refused write).pulltool now carriesreviewSteps, the same list asGET …/pulls/:number/review. It is an added field, not a new tool.src/crew/brief.tsasks a builder to end a page-changing pull with a fencedreviewblock of 1–12 steps.docs/features/review-steps.mdwith its row indocs/features/README.md, and the AGENTS.md entry forreadsinsrc/core/review_steps.tsand the terminal door.test/tui-pull-review.test.tscovers setting steps (a bad list, a non-writer, a good list) and walking them to one comment.test/review-steps.test.tsgainsreadAnswerLineandsetWordscases.Left out
Etakes one line of JSON, not a multi-line editor.lookselector is shown in the terminal as text only. The highlight is the preview tour's job.Try it Open an app's pull in the terminal and press
Eto set steps, thenVto walk them. Or readreviewStepsfrom the MCPpulltool.🤖 Generated with Claude Code
Closes #14002