Public: anyone can read this; the crew can change it.

A guided review's doors: the terminal walks and sets the steps, a how-to, the MCP read and the brief line #14229

opened this

Check · Review · Land · Live — No review yet. Next: reviewer, no review yet.

Ready to land

This pull adds the terminal door for guided review: V walks an app pull's steps and E sets them. It also adds the how-to, the MCP read and the brief line. I rebuilt it from the issue because the branch torque/13653-review-steps-doors isn't on the forge.

Notes · 10 files · +328 −3

look green — it answered, no tests were run, ready for a look deploy a527839

Check passeddeploy a527839

Website spec: 26 findings (report only)
opened this

This pull adds the terminal door for guided review: V walks an app pull's steps and E sets them. It also adds the how-to, the MCP read and the brief line. I rebuilt it from the issue because the branch torque/13653-review-steps-doors isn't on the forge. #13701's core, actions and API were already on main.

bun x tsc --noEmit and bun scripts/gate.ts --fix are clean. The new and edited tests pass: test/tui-pull-review.test.ts, test/review-steps.test.ts, test/mcp-size.test.ts, test/feature-orphans.test.ts. So do the brief, MCP-pull and TUI-pull suites I ran by hand. I did not run bun scripts/design-lint.ts: it hit a sandbox network denial and timed out. It should have nothing to check, since I touched nothing in src/web/.

What changed

  • V: on an app's pull, V opens src/tui/screens/pull_review.ts. Each step shows what to look at, what to expect and the question. o opens the step's preview page, or shows its address to copy. w, b (then a one-line note) and s answer it. After the last answer ONE comment goes to the pull through sendReviewAnswers, the same as the page's.
  • E: a writer on an open pull sets the script from one line of JSON. A bad list names the step that is wrong and sets nothing. Both keys are listed on the pull screen.
  • Shared gates: src/actions/review_steps.ts gains readAnswerLine (w, b <note>, s; notes capped at 500 characters and stripped of control characters) and setWords (the words for a refused write).
  • MCP: the pull tool now carries reviewSteps, the same list as GET …/pulls/:number/review. It is an added field, not a new tool.
  • Brief: src/crew/brief.ts asks a builder to end a page-changing pull with a fenced review block of 1–12 steps.
  • Docs: new docs/features/review-steps.md with its row in docs/features/README.md, and the AGENTS.md entry for reads in src/core/review_steps.ts and the terminal door.
  • Tests: test/tui-pull-review.test.ts covers setting steps (a bad list, a non-writer, a good list) and walking them to one comment. test/review-steps.test.ts gains readAnswerLine and setWords cases.

Left out

  • The walk keeps answers in memory, so leaving it before the last step discards them.
  • E takes one line of JSON, not a multi-line editor.
  • The step's look selector is shown in the terminal as text only. The highlight is the preview tour's job.

Try it Open an app's pull in the terminal and press E to set steps, then V to walk them. Or read reviewSteps from the MCP pull tool.

🤖 Generated with Claude Code

Closes #14002

commented

This pull adds the terminal door for guided review: V walks an app pull's steps and E sets them. It also adds the how-to, the MCP read and the brief line. I rebuilt it from the issue because the branch torque/13653-review-steps-doors isn't on the forge. #13701's core, actions and API were already on main.

bun x tsc --noEmit and bun scripts/gate.ts --fix are clean. The new and edited tests pass: test/tui-pull-review.test.ts, test/review-steps.test.ts, test/mcp-size.test.ts, test/feature-orphans.test.ts. So do the brief, MCP-pull and TUI-pull suites I ran by hand. I did not run bun scripts/design-lint.ts: it hit a sandbox network denial and timed out. It should have nothing to check, since I touched nothing in src/web/.

What changed

  • V: on an app's pull, V opens src/tui/screens/pull_review.ts. Each step shows what to look at, what to expect and the question. o opens the step's preview page, or shows its address to copy. w, b (then a one-line note) and s answer it. After the last answer ONE comment goes to the pull through sendReviewAnswers, the same as the page's.
  • E: a writer on an open pull sets the script from one line of JSON. A bad list names the step that is wrong and sets nothing. Both keys are listed on the pull screen.
  • Shared gates: src/actions/review_steps.ts gains readAnswerLine (w, b <note>, s; notes capped at 500 characters and stripped of control characters) and setWords (the words for a refused write).
  • MCP: the pull tool now carries reviewSteps, the same list as GET …/pulls/:number/review. It is an added field, not a new tool.
  • Brief: src/crew/brief.ts asks a builder to end a page-changing pull with a fenced review block of 1–12 steps.
  • Docs: new docs/features/review-steps.md with its row in docs/features/README.md, and the AGENTS.md entry for reads in src/core/review_steps.ts and the terminal door.
  • Tests: test/tui-pull-review.test.ts covers setting steps (a bad list, a non-writer, a good list) and walking them to one comment. test/review-steps.test.ts gains readAnswerLine and setWords cases.

Left out

  • The walk keeps answers in memory, so leaving it before the last step discards them.
  • E takes one line of JSON, not a multi-line editor.
  • The step's look selector is shown in the terminal as text only. The highlight is the preview tour's job.

Try it Open an app's pull in the terminal and press E to set steps, then V to walk them. Or read reviewSteps from the MCP pull tool.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs