Public: anyone can read this; the crew can change it.

Revert "A secret's value is masked in every run log line and check log line" #13236

opened this

Check · Review · Land · Live — It conflicts with its base. Next: builder, it conflicts with its base.

Conflicts with main

Reverts #13180: verifying main after landing found it broke "healthz answers within 1 s throughout a boot beside a draining forge's batch of 8, and work starts once it lets go" and 1 more in test/boot-beside-peer.test.ts, test/no-closed-overlay.test.ts — found by bisecting d357679..5520683 in 6 steps.

Notes · 4 files · +12 −225

look it conflicts with main in src/runs/log.ts, test/run-log-mask.test.ts — bring the branch up to date and it can land deploy df1d5d8

Conflicts in 2 filesdeploy df1d5d8

Website spec: 19 findings (report only)

Look

6 pages beside main · 1 new to this pull

/apps

main

at 59903fa ·

this pull

In the dark

main

at 59903fa ·

this pull

at df1d5d8 ·

/docs

main

at 59903fa ·

this pull

In the dark

main

at 59903fa ·

this pull

at df1d5d8 ·

/explore

main

at 59903fa ·

this pull

In the dark

main

at 59903fa ·

this pull

at df1d5d8 ·

/map

main has no picture of /map yet.

In the dark

main has no picture of /map yet.

at df1d5d8 ·

/notes

main

at 59903fa ·

this pull

In the dark

main

at 59903fa ·

this pull

at df1d5d8 ·

/releases

main

at 59903fa ·

this pull

In the dark

main

at 59903fa ·

this pull

at df1d5d8 ·

/review

main

at 59903fa ·

this pull

In the dark

main

at 59903fa ·

this pull

at df1d5d8 ·

opened this

Reverts #13180: verifying main after landing found it broke "healthz answers within 1 s throughout a boot beside a draining forge's batch of 8, and work starts once it lets go" and 1 more in test/boot-beside-peer.test.ts, test/no-closed-overlay.test.ts — found by bisecting d357679..5520683 in 6 steps.

Main's verification 01m7fc06wv3f9mhcrqr071apaz is red at 5520683; each failed test fails alone too.

Proposed by the forge; a person lands it.

Files: test/boot-beside-peer.test.ts, test/no-closed-overlay.test.ts

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs