Public: anyone can read this; the crew can change it.
Revert "A secret's value is masked in every run log line and check log line" #13236
Check · Review · Land · Live — It conflicts with its base.
Reverts #13180: verifying main after landing found it broke "healthz answers within 1 s throughout a boot beside a draining forge's batch of 8, and work starts once it lets go" and 1 more in test/boot-beside-peer.test.ts, test/no-closed-overlay.test.ts — found by bisecting d357679..5520683 in 6 steps.
look it conflicts with main in src/runs/log.ts, test/run-log-mask.test.ts — bring the branch up to date and it can land deploy df1d5d8
Conflicts in 2 filesdeploy df1d5d8
Website spec: 19 findings (report only)
- /board http://127.0.0.1:34105/board answered 303 — https://specification.website/
- /notes http://127.0.0.1:34105/notes answered 303 — https://specification.website/
- /review http://127.0.0.1:34105/review answered 303 — https://specification.website/
- /releases http://127.0.0.1:34105/releases answered 303 — https://specification.website/
- /map http://127.0.0.1:34105/map answered 303 — https://specification.website/
- /system http://127.0.0.1:34105/system answered 303 — https://specification.website/
- /maintenance http://127.0.0.1:34105/maintenance answered 303 — https://specification.website/
- /talk http://127.0.0.1:34105/talk answered 303 — https://specification.website/
- /flow http://127.0.0.1:34105/flow answered 303 — https://specification.website/
- /resilience http://127.0.0.1:34105/resilience answered 303 — https://specification.website/
- /boards?help http://127.0.0.1:34105/boards?help answered 303 — https://specification.website/
- /settings/crew http://127.0.0.1:34105/settings/crew answered 303 — https://specification.website/
- /settings/crew?help http://127.0.0.1:34105/settings/crew?help answered 303 — https://specification.website/
- /settings/security/controls http://127.0.0.1:34105/settings/security/controls answered 303 — https://specification.website/
- /preview-admin/sample expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/next?pick expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/space the first focusable element is not a skip link (an in-page #target link) — skip-link
Sign in to join this conversation.
new above
offline
Reverts #13180: verifying main after landing found it broke "healthz answers within 1 s throughout a boot beside a draining forge's batch of 8, and work starts once it lets go" and 1 more in
test/boot-beside-peer.test.ts,test/no-closed-overlay.test.ts— found by bisecting d357679..5520683 in 6 steps.Main's verification 01m7fc06wv3f9mhcrqr071apaz is red at 5520683; each failed test fails alone too.
Proposed by the forge; a person lands it.
Files: test/boot-beside-peer.test.ts, test/no-closed-overlay.test.ts