Public: anyone can read this; the crew can change it.

small: the space page has before and after looks: `/space` joins app.looks in forge.json #12778

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/12772-small-the-space-page-has-before-and-afte → main 1 commit fork

  • Merged. scout/12772-small-the-space-page-has-before-and-afte was merged into main as e39d196.

Review

Sign in to review this change.
2 files changed +3 −3
forge.json +2 −2
@@ -4,8 +4,8 @@
44 "api.github.com"
55 ],
66 "app": {
7 "looks": ["/", "/front", "/explore", "/board", "/notes", "/feed", "/review", "/releases", "/apps", "/repos", "/map", "/system", "/talk", "/flow", "/resilience", "/boards?help", "/settings/crew", "/settings/crew?help", "/preview-admin/sample", "/preview-admin/sample/pulls/3", "/preview-admin/sample/next?pick", "/preview-admin/sample/bets", "/preview-admin/sample/waves", "/preview-admin/sample/milestones"],
8 "looksAsOwner": ["/", "/board", "/flow", "/boards?help", "/settings/crew", "/settings/crew?help", "/talk", "/system", "/resilience", "/preview-admin/sample", "/preview-admin/sample/pulls/3", "/preview-admin/sample/next?pick", "/preview-admin/sample/bets", "/preview-admin/sample/waves", "/preview-admin/sample/milestones"],
7 "looks": ["/", "/front", "/explore", "/board", "/notes", "/feed", "/review", "/releases", "/apps", "/repos", "/map", "/system", "/talk", "/flow", "/resilience", "/boards?help", "/settings/crew", "/settings/crew?help", "/preview-admin/sample", "/preview-admin/sample/pulls/3", "/preview-admin/sample/next?pick", "/preview-admin/sample/bets", "/preview-admin/sample/waves", "/preview-admin/sample/space"],
8 "looksAsOwner": ["/", "/board", "/flow", "/boards?help", "/settings/crew", "/settings/crew?help", "/talk", "/system", "/resilience", "/preview-admin/sample", "/preview-admin/sample/pulls/3", "/preview-admin/sample/next?pick", "/preview-admin/sample/bets", "/preview-admin/sample/waves", "/preview-admin/sample/space"],
99 "run": "bun run src/main.ts",
1010 "install": "",
1111 "health": "/healthz",
test/looks-owner.test.ts +1 −1
@@ -312,7 +312,7 @@ describe("the forge's own owner looks, over the preview seed", () => {
312312 test("forge.json takes the seed's other pages as the owner, and the seed's pull is the one the named list pictures", () => {
313313 const manifest = parseManifest(readFileSync(join(import.meta.dir, "..", "forge.json"), "utf8"), undefined);
314314 if (!manifest.ok) throw new Error(JSON.stringify(manifest.error));
315 for (const page of ["next", "bets", "waves", "milestones"].map((p) => `${repoHome}/${p === "next" ? "next?pick" : p}`)) { // the next page is pictured with its first row chosen
315 for (const page of ["next", "bets", "waves", "space"].map((p) => `${repoHome}/${p === "next" ? "next?pick" : p}`)) { // milestones left for the space page (the cap of 24 is spent); the preview's owner list still pictures it (test/milestones-fit.test.ts). The next page is pictured with its first row chosen
316316 expect(manifest.value.looks).toContain(page);
317317 expect(manifest.value.looksAsOwner).toContain(page);
318318 }

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs