Public: anyone can read this; the crew can change it.

small: the space page has before and after looks: `/space` joins app.looks in forge.json #12778

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The space page now has looks: /preview-admin/sample/space is in app.looks and app.looksAsOwner in forge.json, so the service takes it in light and dark. app.looks was already at its cap of 24 paths (LOOKSMAX).

Notes

shipped production is serving it deploy 5bb6da3

opened this

The space page now has looks: /preview-admin/sample/space is in app.looks and app.looksAsOwner in forge.json, so the service takes it in light and dark.

app.looks was already at its cap of 24 paths (LOOKS_MAX). To make room I took out /preview-admin/sample/milestones, which the preview's owner list (PREVIEW_OWNER_LOOKS) already pictures at desktop and phone. I left the cap alone.

Test change: I changed test/looks-owner.test.ts because it required milestones in forge.json. It now requires space there instead. test/milestones-fit.test.ts still covers milestones' own looks.

Checks run: test/forge-looks.test.ts, test/looks-owner.test.ts, test/milestones-fit.test.ts, bun scripts/gate.ts, bun scripts/design-lint.ts and bun x tsc --noEmit all pass.

Not done:

  • I didn't take or attach the two pictures. The sandbox can't run a browser, so they appear on the pull once the preview builds.
  • I didn't check that the sample repo's space page answers 200 as the owner. Only test/forge-looks.test.ts's top-level pages are fetched; this deeper path isn't.

To try: open the preview and look for the /preview-admin/sample/space light and dark pictures on this pull.

Closes #12772

commented

The space page now has looks: /preview-admin/sample/space is in app.looks and app.looksAsOwner in forge.json, so the service takes it in light and dark.

app.looks was already at its cap of 24 paths (LOOKS_MAX). To make room I took out /preview-admin/sample/milestones, which the preview's owner list (PREVIEW_OWNER_LOOKS) already pictures at desktop and phone. I left the cap alone.

Test change: I changed test/looks-owner.test.ts because it required milestones in forge.json. It now requires space there instead. test/milestones-fit.test.ts still covers milestones' own looks.

Checks run: test/forge-looks.test.ts, test/looks-owner.test.ts, test/milestones-fit.test.ts, bun scripts/gate.ts, bun scripts/design-lint.ts and bun x tsc --noEmit all pass.

Not done:

  • I didn't take or attach the two pictures. The sandbox can't run a browser, so they appear on the pull once the preview builds.
  • I didn't check that the sample repo's space page answers 200 as the owner. Only test/forge-looks.test.ts's top-level pages are fetched; this deeper path isn't.

To try: open the preview and look for the /preview-admin/sample/space light and dark pictures on this pull.

commented

The preview isn't broken: I found nothing to fix, and I pushed nothing new.

  • The deploy log line: "running at https://lab--12778--forge-trevato-apps.open-platform.sh · no tests declared, none run" is the success summary (src/apps/runtime.ts:1486). The no tests declared tail appears whenever forge.json has no app.test. This repo's forge.json has never had one, and my change didn't touch that.
  • The preview itself: /healthz on it answers 200 right now.
  • The log excerpt: the lines you pasted are routine background logging, with no error in them.
  • Tests: the repo's tests run in the forge's check, not in the deploy. The ones covering my change pass, along with the gate, the design lint and tsc.

If the deploy was marked failed for another reason, the log tail doesn't show it. Send the earlier part of the log or the verdict text and I'll look again.

Approved

Approved. /preview-admin/sample/space answers 200 on the preview, and the forge took phone and desktop pictures of it. The cap of 24 is kept by swapping out milestones, which the preview owner list still pictures. Next: (1) have a test assert looks length <= LOOKS_MAX so the next addition fails loudly instead of by trial; (2) add milestones back to the looks when the cap allows or the list is split by area.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs