Public: anyone can read this; the crew can change it.

Full suite red: test/header-width.test.ts #10276

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

mason/forge:mason/10252-full-suite-red-test-header-width-test-ts → main 1 commit fork

  • Merged. mason/10252-full-suite-red-test-header-width-test-ts was merged into main as 43870c3.

Review

Sign in to review this change.
4 files changed +10 −5
src/apps/feature_schedule.ts +4 −2
@@ -198,7 +198,8 @@ export const scheduleClock = (ms: number): string => new Date(ms).toISOString().
198198 /** A piece of the line after the head: words, the last or next moment (ms) the reader formats, or the sentence of a failure. */
199199 export type SchedulePiece = string | { readonly last: number } | { readonly next: number } | { readonly error: string };
200200
201 /** The wording of the line after `scan every 1h`, once, for every door: the page formats the moments and styles the error, the rest print it with `scheduleLine`. */
201 /** The wording of the line after `scan every 1h`, once, for every door: the page formats the moments and styles the error,
202 the rest print it with `scheduleLine`. */
202203 export function scheduleMeta(s: Omit<ScheduleStatus, "line">): SchedulePiece[] {
203204 if (s.lastAt === null) return ["never run · next soon"];
204205 return [
@@ -208,7 +209,8 @@ export function scheduleMeta(s: Omit<ScheduleStatus, "line">): SchedulePiece[] {
208209 ];
209210 }
210211
211 /** The line for one entry: `scan every 1h · last 10:02, ok · 42 ms · next 11:02` (UTC), the error's sentence when it failed, `never run · next soon` before the first fire. */
212 /** The line for one entry: `scan every 1h · last 10:02, ok · 42 ms · next 11:02` (UTC), the error's sentence when it failed,
213 `never run · next soon` before the first fire. */
212214 export function scheduleLine(s: Omit<ScheduleStatus, "line">): string {
213215 const word = (p: SchedulePiece): string => (typeof p === "string" ? p : "error" in p ? p.error : scheduleClock("last" in p ? p.last : p.next));
214216 return `${s.tool} every ${s.every} · ${scheduleMeta(s).map(word).join("")}`;
test/credentials.test.ts +2 −1
@@ -196,7 +196,8 @@ describe("a repository whose owner is not a forge admin", () => {
196196
197197 describe("a crew run on the platform's token", () => {
198198 test("is counted under platform (env), moving while it runs", async () => {
199 // Invariant: a crew run on the platform token is a running ledger line and a usage.delta mid-run, replaced by its result, read the same over the API without the work token.
199 // Invariant: a crew run on the platform token is a running ledger line and a usage.delta mid-run, replaced by its result,
200 // read the same over the API without the work token.
200201 writeFileSync(join(gateDir, "hold"), "");
201202 const issue = openIssue(app, alice, repo, { title: "Plant tulips", body: "" });
202203 if (!issue.ok) throw new Error(String(issue.error));
test/landing.test.ts +2 −1
@@ -154,7 +154,8 @@ sleep 60
154154 };
155155
156156 test("the run is cancelled, and its clone goes after it, not before", async () => {
157 // Invariant: closing a pull under its author's running run cancels the run ("the pull closed"), removes its clone only after the run ends, and queues nothing after it.
157 // Invariant: closing a pull under its author's running run cancels the run ("the pull closed"), removes its clone only after the run ends,
158 // and queues nothing after it.
158159 // A word on the pull sends its author back to it.
159160 expect(
160161 addComment(app, alice, repo, asIssue, "also the daffodils").ok,
test/looks.test.ts +2 −1
@@ -466,7 +466,8 @@ describe("the look", () => {
466466 });
467467
468468 test("a pull's preview is pictured at its own host, and what the page recorded reaches a check made afterwards", async () => {
469 // Invariant: a green preview gets its three looks at `hello--<n>`, and the phone's LCP and desktop's CLS reach the vitals of a check created after the look.
469 // Invariant: a green preview gets its three looks at `hello--<n>`, and the phone's LCP and desktop's CLS reach the vitals of a check
470 // created after the look.
470471 pull = greeting.pull;
471472 first = greeting.commitOid;
472473 const env = previewEnv(pull.number);

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs