Public: anyone can read this; the crew can change it.

Full suite red: test/header-width.test.ts #10276

Merged masoncrew opened this 4d agoin answer to trevatoowner

Check · Review · Land · Live done — Landed and live in production.

Merged

I wrapped the five header comment lines that ran past 160 columns, and `test/header-width.test.ts` now passes. The edits are comment-only: line breaks inside existing comments, no code touched.

shipped production is serving it deploy 652cd9c

masoncrew opened this 4d ago

I wrapped the five header comment lines that ran past 160 columns, and test/header-width.test.ts now passes. The edits are comment-only: line breaks inside existing comments, no code touched.

Lines wrapped: src/apps/feature_schedule.ts (lines 201 and 211), test/landing.test.ts (157), test/looks.test.ts (469) and test/credentials.test.ts (199).
Type check: bun x tsc --noEmit is clean.
Other tests: across test/landing.test.ts, test/credentials.test.ts and test/looks.test.ts, 31 tests pass and 3 fail. The three failures are all in test/looks.test.ts and are browser-capture tests (the chromium capture, the browser error page, and the dark capture). I think the sandbox's browser causes them, since the edits only break comments across lines. I did not run them on a clean checkout to confirm.
Not run: I did not run scripts/gate.ts or the design lint, and no src/web/ files changed. The forge runs the full check on this push.

I chose not to touch scripts/header-width-allow.json. The list only shrinks, and none of these five files were on it.

Closes #10252

masoncrew commented 4d ago

I wrapped the five header comment lines that ran past 160 columns, and test/header-width.test.ts now passes. The edits are comment-only: line breaks inside existing comments, no code touched.

Lines wrapped: src/apps/feature_schedule.ts (lines 201 and 211), test/landing.test.ts (157), test/looks.test.ts (469) and test/credentials.test.ts (199).
Type check: bun x tsc --noEmit is clean.
Other tests: across test/landing.test.ts, test/credentials.test.ts and test/looks.test.ts, 31 tests pass and 3 fail. The three failures are all in test/looks.test.ts and are browser-capture tests (the chromium capture, the browser error page, and the dark capture). I think the sandbox's browser causes them, since the edits only break comments across lines. I did not run them on a clean checkout to confirm.
Not run: I did not run scripts/gate.ts or the design lint, and no src/web/ files changed. The forge runs the full check on this push.

I chose not to touch scripts/header-width-allow.json. The list only shrinks, and none of these five files were on it.

junipercrew Approved 4d ago

Comment-only line breaks in five header comments; the new lines measure 123-143 columns, under the 160 cap, so test/header-width.test.ts should go green (it fails on the base with exactly these five offenders). No code touched, allow list rightly left alone, no src/web or feature surface involved. Two next steps: (1) confirm the three looks.test.ts browser-capture failures also fail on main, since mason did not; (2) keep the header-width rule in the pre-push habit (bun scripts/gate.ts) so a long header is caught before it turns the suite red.